Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-05-29 Thread via GitHub
FrankYang0529 commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2919608671 @AndrewJSchofield The `CoordinatorRecordType.java` is automatically generated. Do you mean that we can change ShareGroupMemberMetadata to 9, SHARE_GROUP_METADATA to 10, and so on?

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-05-29 Thread via GitHub
jim0987795064 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2114114865 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -41,12 +42,18 @@ abstract class AbstractApiVersionsRequestTest(cluster: Clus

[jira] [Commented] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954965#comment-17954965 ] Chia-Ping Tsai commented on KAFKA-19351: the unit test is shown below {code:jav

[jira] [Updated] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19351: --- Labels: async-client (was: ) > AsyncConsumer#commitAsync should copy the input offsets > --

Re: [PR] KAFKA-19042: [11/N] move ConsumerWithLegacyMessageFormatIntegrationTest to clients-integration-tests module [kafka]

2025-05-29 Thread via GitHub
chia7712 merged PR #19810: URL: https://github.com/apache/kafka/pull/19810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19042: [11/N] move ConsumerWithLegacyMessageFormatIntegrationTest to clients-integration-tests module [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on PR #19810: URL: https://github.com/apache/kafka/pull/19810#issuecomment-2920132070 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-7542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19305 Ensure all image classes are immutable [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on code in PR #19847: URL: https://github.com/apache/kafka/pull/19847#discussion_r2114462113 ## metadata/src/main/java/org/apache/kafka/image/ClientQuotaImage.java: ## @@ -45,7 +45,7 @@ public final class ClientQuotaImage { private final Map quotas;

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114387246 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2114648172 ## clients/src/main/resources/common/message/ListConfigResourcesRequest.json: ## @@ -17,10 +17,15 @@ "apiKey": 74, "type": "request", "listeners": ["broker"],

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-29 Thread via GitHub
lianetm commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2114553642 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -129,6 +130,186 @@ public class SaslConfigs { + " authentication provider."

[jira] [Created] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Bolin Lin (Jira)
Bolin Lin created KAFKA-19352: - Summary: PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated Key: KAFKA-19352 URL: https://issues.apache.org/jira/browse/KAFKA-19352

[jira] [Commented] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954974#comment-17954974 ] Lianet Magrans commented on KAFKA-19352: Thanks for reporting! Just heads up, th

[jira] [Updated] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bolin Lin updated KAFKA-19352: -- Description: saw in pr: https://github.com/apache/kafka/pull/19807 PlaintextConsumerCommitTest > test

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-29 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955031#comment-17955031 ] Arpit Goyal commented on KAFKA-19259: - Thanks [~lianetm] for the videos. I will chec

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114517892 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2250,13 +2250,16 @@ void testFollowerSendsUpdateVoterWithKraftVersion0(Errors u

Re: [PR] KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on PR #19808: URL: https://github.com/apache/kafka/pull/19808#issuecomment-2920322851 not sure if I overlooked the vote, but the vote does not pass yet (https://lists.apache.org/thread/bmr5l38gfnqrws3qfpxqfp7y9r7lzdrc). Is there another vote thread? -- This is an autom

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114517892 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2250,13 +2250,16 @@ void testFollowerSendsUpdateVoterWithKraftVersion0(Errors u

Re: [PR] KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on PR #19808: URL: https://github.com/apache/kafka/pull/19808#issuecomment-2920330117 > not sure if I overlooked the vote, but the vote does not pass yet (https://lists.apache.org/thread/bmr5l38gfnqrws3qfpxqfp7y9r7lzdrc). Is there another vote thread? Sorry that I

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114517892 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2250,13 +2250,16 @@ void testFollowerSendsUpdateVoterWithKraftVersion0(Errors u

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114517892 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2250,13 +2250,16 @@ void testFollowerSendsUpdateVoterWithKraftVersion0(Errors u

[jira] [Commented] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955035#comment-17955035 ] Chia-Ping Tsai commented on KAFKA-19352: [~lianetm] Thanks for the heads-up. We

Re: [PR] MINOR: Removed stale comment [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield merged PR #19848: URL: https://github.com/apache/kafka/pull/19848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
DL1231 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113951640 ## core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala: ## @@ -233,16 +234,16 @@ class DelayedRemoteFetchTest { private def buildReadResult(erro

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
brandboat commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2114281965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[PR] KAFKA-19193 Support rack-aware partitioning for Kafka producer [kafka]

2025-05-29 Thread via GitHub
ivanyu opened a new pull request, #19850: URL: https://github.com/apache/kafka/pull/19850 According to KIP-1123, this commit adds the support for rack-aware partitioning to `BuiltInPartitioner`. It comes with two new configs for the producer: `partitioner.rack.aware` and `client.rack`, whic

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114387246 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

Re: [PR] KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield merged PR #19808: URL: https://github.com/apache/kafka/pull/19808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114387246 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114387246 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

[jira] [Resolved] (KAFKA-19337) Bug in ShareCoordinatorShard.generateShareStateRecord causes stateEpoch update misses.

2025-05-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19337. -- Fix Version/s: 4.1.0 Resolution: Fixed > Bug in ShareCoordinatorShard.generateS

[jira] [Updated] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bolin Lin updated KAFKA-19352: -- Description: happens in pr: [https://github.com/apache/kafka/pull/19807] PlaintextConsumerCommitTest

[PR] MINOR: Remove unused code from storage classes [kafka]

2025-05-29 Thread via GitHub
wernerdv opened a new pull request, #19853: URL: https://github.com/apache/kafka/pull/19853 Remove unused code from storage classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] MINOR: Remove unused code from storage classes [kafka]

2025-05-29 Thread via GitHub
wernerdv commented on PR #19853: URL: https://github.com/apache/kafka/pull/19853#issuecomment-2920538840 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-29 Thread via GitHub
josefk31 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2114220408 ## core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala: ## @@ -163,7 +163,7 @@ class RequestQuotaTest extends BaseRequestTest { @Test def testExemptRequ

[PR] KAFKA-19349: Move CreateTopicsRequestWithPolicyTest to clients-integration-tests [kafka]

2025-05-29 Thread via GitHub
Rancho-7 opened a new pull request, #19849: URL: https://github.com/apache/kafka/pull/19849 jira: https://issues.apache.org/jira/browse/KAFKA-19349 Move CreateTopicsRequestWithPolicyTest to clients-integration-tests. -- This is an automated message from the Apache Git Service. To re

Re: [PR] KAFKA-16894: share.version becomes stable feature for preview [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on PR #19831: URL: https://github.com/apache/kafka/pull/19831#issuecomment-2920306289 How about adding this change to docs (`upgrade.html`)? Users can update the version of Share using the feature tool. -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-19337: Write state writes snapshot for higher state epoch. [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield merged PR #19843: URL: https://github.com/apache/kafka/pull/19843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Assigned] (KAFKA-18105) Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders

2025-05-29 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang Chi Hsu reassigned KAFKA-18105: - Assignee: Chang Chi Hsu (was: Chia-Ping Tsai) > Fix flaky PlaintextAdminIntegrationTes

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
apoorvmittal10 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113903699 ## core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala: ## @@ -233,16 +234,16 @@ class DelayedRemoteFetchTest { private def buildReadRes

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
ijuma commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2113966539 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] KAFKA-19347 Don't update timeline data structures in createAcls [kafka]

2025-05-29 Thread via GitHub
mumrah commented on PR #19840: URL: https://github.com/apache/kafka/pull/19840#issuecomment-2919501774 @ahuang98 i was reading through the ACLs code on the controller to remember how we deal with batches of ACLs and I just noticed the `put` call in createAcls method as well as in the replay

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2114139043 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java: ## @@ -226,4 +249,205 @@ var record = new ProducerRecord<>(

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2919678252 > @AndrewJSchofield The `CoordinatorRecordType.java` is automatically generated. Do you mean that we can change ShareGroupMemberMetadata to 9, SHARE_GROUP_METADATA to 10, and so

[jira] [Assigned] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19351: Assignee: Lan Ding (was: Chia-Ping Tsai) > AsyncConsumer#commitAsync should copy the input offse

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-29 Thread via GitHub
josefk31 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2114203951 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -13321,6 +13323,284 @@ class KafkaApisTest extends Logging { assertEquals(alterShareGroupOffse

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-29 Thread via GitHub
josefk31 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2114212111 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -13321,6 +13323,284 @@ class KafkaApisTest extends Logging { assertEquals(alterShareGroupOffse

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114516348 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114517892 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2250,13 +2250,16 @@ void testFollowerSendsUpdateVoterWithKraftVersion0(Errors u

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-05-29 Thread via GitHub
ahuang98 commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2114524509 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -264,13 +267,15 @@ public short partitionRecordVersion() { } publ

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
dengziming commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2113867108 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
ijuma commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2113966539 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] KAFKA-6629: parameterise SegmentedCacheFunctionTest for session key schemas [kafka]

2025-05-29 Thread via GitHub
bbejeck merged PR #19404: URL: https://github.com/apache/kafka/pull/19404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-6629: parameterise SegmentedCacheFunctionTest for session key schemas [kafka]

2025-05-29 Thread via GitHub
bbejeck commented on PR #19404: URL: https://github.com/apache/kafka/pull/19404#issuecomment-2919855332 Merged #19404 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (KAFKA-19352) PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated

2025-05-29 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19352: --- Labels: client flaky-test integration-test (was: flaky-test integration-test) > PlaintextC

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-05-29 Thread via GitHub
YutaLin commented on PR #19807: URL: https://github.com/apache/kafka/pull/19807#issuecomment-2919733439 We will continue tracking the failing test PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated, which is recorded in https://issues.apache.or

[jira] [Resolved] (KAFKA-6629) SegmentedCacheFunctionTest does not cover session window serdes

2025-05-29 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-6629. Resolution: Fixed > SegmentedCacheFunctionTest does not cover session window serdes > -

[jira] [Updated] (KAFKA-6629) SegmentedCacheFunctionTest does not cover session window serdes

2025-05-29 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-6629: --- Fix Version/s: 4.1.0 > SegmentedCacheFunctionTest does not cover session window serdes >

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-29 Thread via GitHub
jolshan merged PR #19714: URL: https://github.com/apache/kafka/pull/19714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
brandboat commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2114281965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (4/n) [kafka]

2025-05-29 Thread via GitHub
sjhajharia commented on PR #19805: URL: https://github.com/apache/kafka/pull/19805#issuecomment-2920030262 Hey @frankvicky Thanks for the initial look. I have addressed most of the comments. Answered one. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114387246 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -62,30 +70,35 @@ public RequestManager( } /** - * Returns true if there are an

[jira] [Updated] (KAFKA-16092) Queues for Kafka

2025-05-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16092: - Fix Version/s: (was: 4.1.0) > Queues for Kafka > > >

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-05-29 Thread via GitHub
jim0987795064 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2114114865 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -41,12 +42,18 @@ abstract class AbstractApiVersionsRequestTest(cluster: Clus

[jira] [Updated] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19351: --- Description: see the docs: https://github.com/apache/kafka/blob/trunk/clients/src/main/java

[jira] [Created] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19351: -- Summary: AsyncConsumer#commitAsync should copy the input offsets Key: KAFKA-19351 URL: https://issues.apache.org/jira/browse/KAFKA-19351 Project: Kafka I

[jira] [Updated] (KAFKA-19351) AsyncConsumer#commitAsync should copy the input offsets

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19351: --- Fix Version/s: 4.1.0 > AsyncConsumer#commitAsync should copy the input offsets > ---

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-29 Thread via GitHub
brandboat commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2114281965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[PR] MINOR: Cleanup KafkaApisTest `asJava` conversions [kafka]

2025-05-29 Thread via GitHub
sjhajharia opened a new pull request, #19851: URL: https://github.com/apache/kafka/pull/19851 We have got rid of almost all of `asJava` conversions in KafkaApisTest. This is a final attempt at the cleanups in the class. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114456146 ## raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java: ## @@ -256,25 +398,25 @@ public void testAnyInflightRequestWithAnyRequest() { rando

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
jsancio commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114266052 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2744,7 +2746,11 @@ private void handleInboundMessage(RaftMessage message, long currentTimeMs)

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114485386 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState state, long current

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114485386 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState state, long current

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114486431 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2849,14 +2858,15 @@ private long maybeSendRequest( long currentTimeMs, Set

[PR] MINOR: Cleanup ShareFetchAcknowledgeRequestTest [kafka]

2025-05-29 Thread via GitHub
sjhajharia opened a new pull request, #19852: URL: https://github.com/apache/kafka/pull/19852 Now that Kafka supports Java 17, this PR cleans up the ShareFetchAcknowledgeRequestTest. The changes mostly include: - Collections.singletonList() is replaced with List.of() - Get rid of a

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-29 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2114492022 ## raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java: ## @@ -234,15 +330,61 @@ public void testFindReadyWithRequestTimedOut() { );

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-29 Thread via GitHub
CalvinConfluent commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2114751548 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -261,6 +264,62 @@ class KafkaApis(val requestChannel: RequestChannel, } } + def handleGetR

Re: [PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

2025-05-29 Thread via GitHub
Chuckame commented on PR #19837: URL: https://github.com/apache/kafka/pull/19837#issuecomment-2920608377 Nice catch also @chia7712, done. I did not find other uses of this `optimizeFiltersForHits` now 😄 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-29 Thread via GitHub
josefk31 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2114762369 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -261,6 +264,62 @@ class KafkaApis(val requestChannel: RequestChannel, } } + def handleGetReplicaL

[jira] [Reopened] (KAFKA-16092) Queues for Kafka

2025-05-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reopened KAFKA-16092: --- > Queues for Kafka > > > Key: KAFKA-16092 > URL

[PR] MINOR: Removed stale comment [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield opened a new pull request, #19848: URL: https://github.com/apache/kafka/pull/19848 Removed a trivial stale comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (KAFKA-16092) Queues for Kafka

2025-05-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-16092: -- Fix Version/s: 4.1.0 > Queues for Kafka > > > Key: KAFKA-1609

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-29 Thread via GitHub
omkreddy commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2113434321 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java: ## @@ -239,14 +275,46 @@ public T get(String name) {

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-29 Thread via GitHub
omkreddy commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2113774135 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -215,6 +396,23 @@ public static void addClientSaslSupport(ConfigDef config) {

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-29 Thread via GitHub
omkreddy commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2113775829 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -190,6 +194,23 @@ public class BrokerSecurityConfigs {

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-29 Thread via GitHub
chia7712 merged PR #19741: URL: https://github.com/apache/kafka/pull/19741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on code in PR #19828: URL: https://github.com/apache/kafka/pull/19828#discussion_r2113475427 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,7 +267,8 @@ public long newActiveControllers() { } p

[jira] [Resolved] (KAFKA-19056) Move EndToEndClusterIdTest to server module

2025-05-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19056. Fix Version/s: 4.1.0 Resolution: Fixed > Move EndToEndClusterIdTest to server modul

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-05-29 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2113740647 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -116,6 +116,9 @@ public enum MetadataVersion { // Streams groups are earl

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2113744859 ## server-common/src/test/java/integration/kafka/server/IntegrationTestUtils.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-05-29 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2113736930 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -264,13 +267,15 @@ public short partitionRecordVersion() { } publi

Re: [PR] KAFKA-19290: Exploit mapKey optimisation in protocol requests and responses (wip) [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield commented on code in PR #19815: URL: https://github.com/apache/kafka/pull/19815#discussion_r2113705265 ## share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorShardTest.java: ## @@ -451,15 +451,15 @@ public void testWriteStateFenced

[jira] [Assigned] (KAFKA-16869) Rewrite HighAvailabilityTaskAssignor to implement the new TaskAssignor interface

2025-05-29 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-16869: -- Assignee: Lorcan > Rewrite HighAvailabilityTaskAssignor to implement the new TaskAssignor > interfac

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-29 Thread via GitHub
chia7712 commented on PR #19685: URL: https://github.com/apache/kafka/pull/19685#issuecomment-2919116625 > While I would love to help, I think you meant @Rancho-7 Sorry, fat finger :( -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-29 Thread via GitHub
TaiJuWu commented on code in PR #19773: URL: https://github.com/apache/kafka/pull/19773#discussion_r2113113850 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerAssignTest.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apac

[PR] (WIP)KAFKA-19305 Ensure all image classes are immutable [kafka]

2025-05-29 Thread via GitHub
jim0987795064 opened a new pull request, #19847: URL: https://github.com/apache/kafka/pull/19847 This pull request addresses KAFKA-19305 by ensuring that collections used in these classes are fully immutable. ## Changes - Updated `ClientQuotaImage` and `TopicImage` by using `C

Re: [PR] MINOR: removed test cases with combined_kraft mode in share_consumer_test.py [kafka]

2025-05-29 Thread via GitHub
AndrewJSchofield merged PR #19841: URL: https://github.com/apache/kafka/pull/19841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-16717) Add AdminClient.alterShareGroupOffsets

2025-05-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954896#comment-17954896 ] Andrew Schofield commented on KAFKA-16717: -- [~jimmywang611] This task is almost

[jira] [Resolved] (KAFKA-19316) Add share_group_command_test.py system test

2025-05-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19316. -- Fix Version/s: 4.1.0 Resolution: Fixed > Add share_group_command_test.py system

Re: [PR] [WIP] MINOR: bump dependency test [kafka]

2025-05-29 Thread via GitHub
showuon closed pull request #19833: [WIP] MINOR: bump dependency test URL: https://github.com/apache/kafka/pull/19833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [WIP] MINOR: bump dependency test [kafka]

2025-05-29 Thread via GitHub
showuon closed pull request #19834: [WIP] MINOR: bump dependency test URL: https://github.com/apache/kafka/pull/19834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

  1   2   >