chia7712 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2114648172
########## clients/src/main/resources/common/message/ListConfigResourcesRequest.json: ########## @@ -17,10 +17,15 @@ "apiKey": 74, "type": "request", "listeners": ["broker"], - "name": "ListClientMetricsResourcesRequest", - "validVersions": "0", + "name": "ListConfigResourcesRequest", Review Comment: it seems we overlooked the metrics deprecation caused by this renaming. In the request metrics, the metrics have the tag `request -> name`. Consequently, this renaming destroyed the metrics `request -> ListClientMetricsResourcesRequest` for v0. While this is not a critical issue, it's worth rethinking. A safe approach would be to add the `request -> ListClientMetricsResourcesRequest` for v0. That is not difficult to address, as there are already some `non-ApiKeys` in the request metrics. @FrankYang0529 @AndrewJSchofield WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
