ahuang98 commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2114524509
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -264,13 +267,15 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_9_IV0)) {
+ if (isAtLeast(IBP_4_1_IV1)) {
+ return 18;
Review Comment:
I think the part I was missing is - MV can gate whether or not the new HW
field is acted on by the receiver - but the receiver will populate the new HW
field with the default value regardless (as long as it has a current enough
kafka version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
