kamalcph commented on PR #19673:
URL: https://github.com/apache/kafka/pull/19673#issuecomment-2869962173
LGTM, thanks for fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 merged PR #19662:
URL: https://github.com/apache/kafka/pull/19662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950784#comment-17950784
]
Chia-Ping Tsai commented on KAFKA-19267:
related code:
https://github.com/apach
Chia-Ping Tsai created KAFKA-19267:
--
Summary: the min version used by ListOffsetsRequest should be 1
rather than 0
Key: KAFKA-19267
URL: https://issues.apache.org/jira/browse/KAFKA-19267
Project: Kaf
[
https://issues.apache.org/jira/browse/KAFKA-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yunchi Pang reassigned KAFKA-19267:
---
Assignee: Yunchi Pang (was: Chia-Ping Tsai)
> the min version used by ListOffsetsRequest s
frankvicky commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083898755
##
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
pu
AndrewJSchofield commented on code in PR #19659:
URL: https://github.com/apache/kafka/pull/19659#discussion_r2083611522
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -746,6 +747,29 @@ private Consumer>
failedShareAcknowledgeMetricsHandler() {
squah-confluent opened a new pull request, #19678:
URL: https://github.com/apache/kafka/pull/19678
Minor updates to RangeSet:
* Fix size() to return 0 when to < from
* Fix equals() so that all empty RangeSets are equal, to follow the Set
interface definition better.
* Reimplement
mjsax merged PR #19676:
URL: https://github.com/apache/kafka/pull/19676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
m1a2st commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083766600
##
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
public
github-actions[bot] commented on PR #17593:
URL: https://github.com/apache/kafka/pull/17593#issuecomment-2870720484
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
YutaLin commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083773873
##
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
publi
m1a2st commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083777217
##
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
public
Abhinav Dixit created KAFKA-19266:
-
Summary: Eliminate flakiness in test
SharePartitionTest.testAcquisitionLockTimeoutForBatchesPostStartOffsetMovement
Key: KAFKA-19266
URL: https://issues.apache.org/jira/browse/K
AndrewJSchofield commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2083622116
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3620,7 +3620,50 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleAlterShareGro
frankvicky merged PR #19680:
URL: https://github.com/apache/kafka/pull/19680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
frankvicky commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083748605
##
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
pu
github-actions[bot] commented on PR #19636:
URL: https://github.com/apache/kafka/pull/19636#issuecomment-2870683846
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19553:
URL: https://github.com/apache/kafka/pull/19553#issuecomment-2870683892
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19517:
URL: https://github.com/apache/kafka/pull/19517#issuecomment-2870683922
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
ijuma commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2083606229
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2083606336
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18695.
Fix Version/s: 4.1.0
Resolution: Fixed
> Remove quorum=kraft and kip932 from all in
[
https://issues.apache.org/jira/browse/KAFKA-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18695:
---
Summary: Remove quorum=kraft and kip932 from all integration tests (was:
Remove quorum=kraf
chia7712 merged PR #19633:
URL: https://github.com/apache/kafka/pull/19633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax opened a new pull request, #19676:
URL: https://github.com/apache/kafka/pull/19676
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
AndrewJSchofield commented on code in PR #19493:
URL: https://github.com/apache/kafka/pull/19493#discussion_r2083608078
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -10929,47 +10928,231 @@ class KafkaApisTest extends Logging {
}
@Test
- def testLi
chia7712 merged PR #19673:
URL: https://github.com/apache/kafka/pull/19673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19264.
Fix Version/s: 4.1.0
Resolution: Fixed
> Remove fallback for thread pool sizes in R
Mirai1129 opened a new pull request, #19674:
URL: https://github.com/apache/kafka/pull/19674
This parameter `log.cleaner.enable` has been deprecated, in Kafka 5.0 later
cannot disable cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 commented on code in PR #19674:
URL: https://github.com/apache/kafka/pull/19674#discussion_r2083581944
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -629,6 +629,8 @@ class LogManager(logDirs: Seq[File],
if (cleanerConfig.enableCleaner) {
_cleaner
Mirai1129 commented on code in PR #19674:
URL: https://github.com/apache/kafka/pull/19674#discussion_r2083583209
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -629,6 +629,8 @@ class LogManager(logDirs: Seq[File],
if (cleanerConfig.enableCleaner) {
_cleaner
squah-confluent commented on PR #19677:
URL: https://github.com/apache/kafka/pull/19677#issuecomment-2870221833
Benchmarks before and after
Scroll right for after numbers.
```
Benchmark: ServerSideAssignorBenchmark.doAssignment
assignorType: UNIFORM
isRackAware: fal
frankvicky opened a new pull request, #19680:
URL: https://github.com/apache/kafka/pull/19680
When building RC, the current version of Jetty has been reporting for CVE.
Hence, we should upgrade the Jetty version to fix it.
--
This is an automated message from the Apache Git Ser
Kuan Po Tseng created KAFKA-19264:
-
Summary: Remove fallback for thread pool sizes in
RemoteLogManagerConfig
Key: KAFKA-19264
URL: https://issues.apache.org/jira/browse/KAFKA-19264
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-19264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng updated KAFKA-19264:
--
Description:
The fallback mechanism was first introduced in
[KIP-950|https://cwiki.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu resolved KAFKA-19139.
-
Resolution: Fixed
> Plugin#wrapInstance should use LinkedHashMap instead of Map
> -
brandboat opened a new pull request, #19673:
URL: https://github.com/apache/kafka/pull/19673
The fallback mechanism for `remote.log.manager.copier.thread.pool.size` and
`remote.log.manager.expiration.thread.pool.size` defaulting to
`remote.log.manager.thread.pool.size` was introduced in KIP
[
https://issues.apache.org/jira/browse/KAFKA-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-19265:
---
Description: This is an incremental approach to the remote log metadata
snapshot mechanism a
Satish Duggana created KAFKA-19265:
--
Summary: Use snapshotting of remote log metedata topic that is
used when a broker is restarted.
Key: KAFKA-19265
URL: https://issues.apache.org/jira/browse/KAFKA-19265
[
https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950756#comment-17950756
]
Chia-Ping Tsai commented on KAFKA-13610:
We should change the min value of log.c
黃竣陽 created KAFKA-19262:
---
Summary: Add a test to verify all metrics naming pattern
Key: KAFKA-19262
URL: https://issues.apache.org/jira/browse/KAFKA-19262
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-19263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Chia Ma reassigned KAFKA-19263:
--
Assignee: Yu Chia Ma
> The docs of delete.topic.enable used by Admin#deletetopics is out-of-
Chia-Ping Tsai created KAFKA-19263:
--
Summary: The docs of delete.topic.enable used by
Admin#deletetopics is out-of-date
Key: KAFKA-19263
URL: https://issues.apache.org/jira/browse/KAFKA-19263
Projec
chickenchickenlove commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2869870166
@dajac
Sorry to bother you...!
Gently ping 🙇♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Mirai1129 opened a new pull request, #19675:
URL: https://github.com/apache/kafka/pull/19675
If delete.topic.enable is false on the brokers, deleteTopics will mark the
topics for deletion, but not actually delete them. The futures will return
successfully in this case.
It is not true
YutaLin opened a new pull request, #19679:
URL: https://github.com/apache/kafka/pull/19679
* In ConsoleShareConsumerTest, add @SuppressWarnings("unchecked") annotation
in method shouldUpgradeDeliveryCount
* In ListConsumerGroupOffsetsHandlerTest, add generic parameters to HashSet
constru
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083791909
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083796590
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
49 matches
Mail list logo
