chia7712 commented on code in PR #19674: URL: https://github.com/apache/kafka/pull/19674#discussion_r2083581944
########## core/src/main/scala/kafka/log/LogManager.scala: ########## @@ -629,6 +629,8 @@ class LogManager(logDirs: Seq[File], if (cleanerConfig.enableCleaner) { _cleaner = new LogCleaner(cleanerConfig, liveLogDirs.asJava, currentLogs, logDirFailureChannel, time) _cleaner.startup() + } else { + warn("The parameter `log.cleaner.enable` is deprecated and will be removed in Kafka 5.0.") Review Comment: `parameter` -> `config`. Also, could you please highlight that in 5.0 the cleaner is always enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org