YutaLin commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083773873
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
public void testTopicDeltaElectionStatsWithEmptyImage() {
- TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.EMPTY_MAP);
+ TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.<Integer, PartitionRegistration>emptyMap());
Review Comment:
Hi @frankvicky, here it is. Just wondering, what's the purpose of the
screenshot?
<img width="1290" alt="Screenshot 2025-05-11 at 11 45 58 PM"
src="https://github.com/user-attachments/assets/1e208779-94d2-4917-b971-54d97902ffda";
/>
Hi @m1a2st
What's the benefit to use `Map.of()` instead of `Collections.emptyMap()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
