Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-01 Thread via GitHub
ijuma commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2070951806 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +336,106 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-05-01 Thread via GitHub
jsancio commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2070577759 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -99,6 +100,13 @@ public class QuorumConfig { public static final String QUORUM_RETRY_BACKOFF_M

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-05-01 Thread via GitHub
jsancio commented on PR #19589: URL: https://github.com/apache/kafka/pull/19589#issuecomment-2845358548 > Feature description: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217391519#KIP853:KRaftControllerMembershipChanges-Controllerautojoining > > Add the `controll

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-05-01 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2070589768 ## raft/src/main/java/org/apache/kafka/raft/FollowerState.java: ## @@ -42,6 +42,8 @@ public class FollowerState implements EpochState { private final Timer fetc

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-05-01 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2070595633 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /**

[PR] MINOR: Improve output for delete-offset of kafka-consumer-groups.sh [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield opened a new pull request, #19610: URL: https://github.com/apache/kafka/pull/19610 The output from the delete-offsets option of kafka-consumer-groups.sh can be improved. For example, the column widths are excessive which looks untidy, and the error messages from the broker

[jira] [Resolved] (KAFKA-18760) Deprecate Optional and return String from public EndPoint#Listener

2025-05-01 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18760. --- Fix Version/s: 4.1.0 Resolution: Fixed > Deprecate Optional and return String from public End

[PR] MINOR: Move AdminCommandFailedException and AdminOperationException to tools module [kafka]

2025-05-01 Thread via GitHub
Yunyung opened a new pull request, #19614: URL: https://github.com/apache/kafka/pull/19614 AdminCommandFailedException and AdminOperationException are used only in tools module, so move both into tools module. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-01 Thread via GitHub
squah-confluent commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2070408828 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +219,50 @@ void validateOffsetFetch( default boolean shouldE

Re: [PR] KAFKA-19160;KAFKA-19164; Improve performance of fetching stable offsets [kafka]

2025-05-01 Thread via GitHub
squah-confluent commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2070405167 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -192,10 +193,165 @@ public OffsetMetadataManager build()

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-05-01 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19329: URL: https://github.com/apache/kafka/pull/19329#discussion_r2069960577 ## core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala: ## @@ -2052,12 +2052,98 @@ class ShareFetchAcknowledgeRequestTest(cluster: Clus

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-05-01 Thread via GitHub
DL1231 commented on PR #19430: URL: https://github.com/apache/kafka/pull/19430#issuecomment-2845094174 @AndrewJSchofield @apoorvmittal10 Thanks for your suggestion. I’ll finish it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (KAFKA-19169) Enhance AuthorizerIntegrationTest for share group APIs

2025-05-01 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19169. -- Fix Version/s: 4.1.0 Resolution: Fixed > Enhance AuthorizerIntegrationTest for

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-05-01 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2070246819 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /**

Re: [PR] MINOR: printing share group describe result in sorted order [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield merged PR #19599: URL: https://github.com/apache/kafka/pull/19599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-05-01 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2070648299 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3328,6 +3405,23 @@ private UpdateRaftVoterRequestData buildUpdateVoterRequest() {

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-05-01 Thread via GitHub
CalvinConfluent commented on PR #19355: URL: https://github.com/apache/kafka/pull/19355#issuecomment-2845169525 @chia7712 Any other comments? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-01 Thread via GitHub
frankvicky commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2070104164 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -117,9 +116,9 @@ public void testEnsureCloseStopsRunningTh

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield merged PR #19329: URL: https://github.com/apache/kafka/pull/19329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-19015) Remove share session from cache on connection drop

2025-05-01 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19015. -- Fix Version/s: 4.1.0 Resolution: Fixed > Remove share session from cache on con

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield merged PR #19430: URL: https://github.com/apache/kafka/pull/19430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-19210) investigate flakiness in GroupMetadataManagerTest.testShareGroupHeartbeatInitializeOnPartitionUpdate

2025-05-01 Thread Chirag Wadhwa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Wadhwa resolved KAFKA-19210. --- Resolution: Fixed > investigate flakiness in > GroupMetadataManagerTest.testShareGroupHeart

Re: [PR] KAFKA-19204: Allow persister retry of initializing topics. [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19603: URL: https://github.com/apache/kafka/pull/19603#discussion_r2070296330 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2058,7 +2058,8 @@ public void testComplexSh

Re: [PR] MINOR: Clean up CloseOptions [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on code in PR #19571: URL: https://github.com/apache/kafka/pull/19571#discussion_r2070537206 ## clients/src/main/java/org/apache/kafka/clients/consumer/CloseOptions.java: ## @@ -84,10 +77,7 @@ public static CloseOptions timeout(final Duration timeout) {

Re: [PR] KAFKA-19182: Move SchedulerTest to server module [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on PR #19608: URL: https://github.com/apache/kafka/pull/19608#issuecomment-2845288511 @UladzislauBlok please fix the following import error: ``` src/test/java/org/apache/kafka/server/util/SchedulerTest.java @@ -31,6 +31,7 @@ import·org

[PR] KAFKA-19227: Piggybacked share fetch acknowledgements performance issue [kafka]

2025-05-01 Thread via GitHub
apoorvmittal10 opened a new pull request, #19612: URL: https://github.com/apache/kafka/pull/19612 The PR fixes the issue when ShareAcknowledgements are piggybacked on ShareFetch. The current default configuration in clients sets `batch size` and `max fetch records` as per the `max.poll.reco

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-05-01 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2070542742 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

Re: [PR] KAFKA-16894: Correct definition of ShareVersion [kafka]

2025-05-01 Thread via GitHub
chia7712 merged PR #19606: URL: https://github.com/apache/kafka/pull/19606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19207: Move ForwardingManagerMetrics and ForwardingManagerMetricsTest to server module [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on code in PR #19574: URL: https://github.com/apache/kafka/pull/19574#discussion_r2070569672 ## server/src/main/java/org/apache/kafka/server/metrics/ForwardingManagerMetrics.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-19169: Enhance AuthorizerIntegrationTest for share group APIs [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield merged PR #19540: URL: https://github.com/apache/kafka/pull/19540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2070226537 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -178,7 +177,7 @@ public void testMaximumTimeToWait()

[jira] [Updated] (KAFKA-19205) inconsistent result of beginningOffsets/endoffset between classic consumer and async consumer with zero timeout

2025-05-01 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19205: --- Fix Version/s: 4.1.0 > inconsistent result of beginningOffsets/endoffset between classic con

[jira] [Updated] (KAFKA-14648) Do not fail clients if bootstrap servers is not immediately resolvable

2025-05-01 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-14648: --- Component/s: clients > Do not fail clients if bootstrap servers is not immediately resolvabl

[jira] [Created] (KAFKA-19226) Add test_console_share_consumer system test

2025-05-01 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19226: - Summary: Add test_console_share_consumer system test Key: KAFKA-19226 URL: https://issues.apache.org/jira/browse/KAFKA-19226 Project: Kafka Issue Type: Sub

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-05-01 Thread via GitHub
chia7712 merged PR #19355: URL: https://github.com/apache/kafka/pull/19355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19227) Fix performance for share fetch with piggyback acknowledgements

2025-05-01 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19227: - Summary: Fix performance for share fetch with piggyback acknowledgements Key: KAFKA-19227 URL: https://issues.apache.org/jira/browse/KAFKA-19227 Project: Kafka

[jira] [Resolved] (KAFKA-19073) Add Transactional ID pattern filter to ListTransactions API

2025-05-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19073. Fix Version/s: 4.1.0 Resolution: Fixed > Add Transactional ID pattern filter to Lis

[jira] [Assigned] (KAFKA-19216) Eliminate flakiness in kafka.server.share.SharePartitionTest

2025-05-01 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-19216: - Assignee: Abhinav Dixit > Eliminate flakiness in kafka.server.share.SharePartitionTest

Re: [PR] KAFKA-19131: Adjust remote storage reader thread maximum pool size to avoid illegal argument [kafka]

2025-05-01 Thread via GitHub
kamalcph commented on PR #19532: URL: https://github.com/apache/kafka/pull/19532#issuecomment-2845267563 @FrankYang0529 Could you also open this PR against [4.0](https://github.com/apache/kafka/tree/4.0) branch to backport the fix? Thanks! -- This is an automated message

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2070530816 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -154,16 +153,12 @@ void runOnce() { lastPollTimeMs = cu

Re: [PR] KAFKA-19087: Move TransactionState to transaction-coordinator module [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on PR #19568: URL: https://github.com/apache/kafka/pull/19568#issuecomment-2845275671 @FrankYang0529 please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (KAFKA-19182) Move SchedulerTest to server module

2025-05-01 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948671#comment-17948671 ] Uladzislau Blok commented on KAFKA-19182: - Hey [~chia7712] . Path is available.

Re: [PR] KAFKA-19215: Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19598: URL: https://github.com/apache/kafka/pull/19598#discussion_r2069993467 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1338,26 +1344,33 @@ public boolean maybeAcquireFetchLock() { long currentTime

[PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl (wip) [kafka]

2025-05-01 Thread via GitHub
FrankYang0529 opened a new pull request, #19611: URL: https://github.com/apache/kafka/pull/19611 Replace `TopicMetadata` with `subscriptionTopicIdSet` and `MetadataImage` in `SubscribedTopicDescriberImpl`. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] MINOR: Improve output for delete-offset of kafka-consumer-groups.sh [kafka]

2025-05-01 Thread via GitHub
AndrewJSchofield commented on PR #19610: URL: https://github.com/apache/kafka/pull/19610#issuecomment-2844803489 Here's a sample of the output before the change: Success: ``` bin/kafka-consumer-groups.sh --bootstrap-server localhost:9092 --delete-offsets --group group1 --topic T

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-01 Thread via GitHub
junrao commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r207063 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -668,21 +677,24 @@ private void processRemoteFetchOrException( private boolean maybeCompleteP

Re: [PR] KAFKA-19146: Merge OffsetAndEpoch from raft to server-common [kafka]

2025-05-01 Thread via GitHub
chia7712 merged PR #19475: URL: https://github.com/apache/kafka/pull/19475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19146) Merge org.apache.kafka.server.common.OffsetAndEpoch and org.apache.kafka.raft.OffsetAndEpoch

2025-05-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19146. Fix Version/s: 4.1.0 Resolution: Fixed > Merge org.apache.kafka.server.common.Offse

Re: [PR] KAFKA-19212: Correct the unclean leader election metric calculation [kafka]

2025-05-01 Thread via GitHub
CalvinConfluent commented on code in PR #19590: URL: https://github.com/apache/kafka/pull/19590#discussion_r2070927258 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -334,11 +334,11 @@ private void tryElection(PartitionChangeRecord recor

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-01 Thread via GitHub
apoorvmittal10 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2846030610 @JimmyWang6 Just following up, do you need help to wrap up the work in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-17942) Fix testAcknowledgementCommitCallbackInvalidRecordStateException

2025-05-01 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948788#comment-17948788 ] Apoorv Mittal commented on KAFKA-17942: --- [~shivsundar] Can you please check if the

[jira] [Commented] (KAFKA-18574) Quarantined test list should be sorted

2025-05-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948787#comment-17948787 ] Kirk True commented on KAFKA-18574: --- [~harshk10] happy for you to take it. I wasn't ab

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-01 Thread via GitHub
ijuma commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2070948145 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +336,106 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-01 Thread via GitHub
ijuma commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2070950389 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Created] (KAFKA-19230) Fail build for FunctionalInterfaceMethodChanged warning

2025-05-01 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19230: --- Summary: Fail build for FunctionalInterfaceMethodChanged warning Key: KAFKA-19230 URL: https://issues.apache.org/jira/browse/KAFKA-19230 Project: Kafka

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
mjsax merged PR #19616: URL: https://github.com/apache/kafka/pull/19616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: improve AdjustStreamThreadCountTest [kafka]

2025-05-01 Thread via GitHub
lucasbru commented on code in PR #19617: URL: https://github.com/apache/kafka/pull/19617#discussion_r2071176921 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java: ## @@ -239,10 +241,30 @@ public void shouldAddAndRemo

Re: [PR] KAFKA-19212: Correct the unclean leader election metric calculation [kafka]

2025-05-01 Thread via GitHub
cmccabe commented on code in PR #19590: URL: https://github.com/apache/kafka/pull/19590#discussion_r2070908955 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -334,11 +334,11 @@ private void tryElection(PartitionChangeRecord record) {

[PR] KAFKA-19097: Fix assertEquals arguement order in InternalStreamsBuilderTest [kafka]

2025-05-01 Thread via GitHub
shelbysash opened a new pull request, #19615: URL: https://github.com/apache/kafka/pull/19615 In reference to JIRA issue: https://issues.apache.org/jira/browse/KAFKA-19097 This should fix the arguement order in assertEquals statements in InternalStreamsBuilderTest.java Expected val

[jira] [Created] (KAFKA-19228) Formatting with `--no-initial-controllers` flag should not write kraft version control record

2025-05-01 Thread Kevin Wu (Jira)
Kevin Wu created KAFKA-19228: Summary: Formatting with `--no-initial-controllers` flag should not write kraft version control record Key: KAFKA-19228 URL: https://issues.apache.org/jira/browse/KAFKA-19228

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
ableegoldman commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071072286 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMeta

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
ableegoldman commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071070585 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMeta

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
ableegoldman commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071071559 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMeta

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
mjsax commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071073135 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMetadata me

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
mjsax commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071073135 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMetadata me

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
ableegoldman commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071077018 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMeta

Re: [PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
mjsax commented on code in PR #19616: URL: https://github.com/apache/kafka/pull/19616#discussion_r2071079834 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/ProducerInterceptorsTest.java: ## @@ -126,7 +126,7 @@ public void onAcknowledgement(RecordMetadata me

Re: [PR] KAFKA-19215: Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock [kafka]

2025-05-01 Thread via GitHub
adixitconfluent commented on code in PR #19598: URL: https://github.com/apache/kafka/pull/19598#discussion_r2071132002 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1338,26 +1344,33 @@ public boolean maybeAcquireFetchLock() { long currentTime

Re: [PR] KAFKA-19215: Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock [kafka]

2025-05-01 Thread via GitHub
adixitconfluent commented on code in PR #19598: URL: https://github.com/apache/kafka/pull/19598#discussion_r2071126386 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1338,26 +1344,33 @@ public boolean maybeAcquireFetchLock() { long currentTime

[PR] MINOR: remove @FunctionalInterface annotation [kafka]

2025-05-01 Thread via GitHub
mjsax opened a new pull request, #19618: URL: https://github.com/apache/kafka/pull/19618 BatchingStateRestoreCallback's default implemeantion of restore() lead to wraning `FunctionalInterfaceMethodChanged`. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-17942) Fix testAcknowledgementCommitCallbackInvalidRecordStateException

2025-05-01 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948810#comment-17948810 ] Shivsundar R commented on KAFKA-17942: -- Hi [~apoorvmittal10], I noticed we do not h

Re: [PR] MINOR: Remove unnecessary Optional from offsetsToSnapshot [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on code in PR #19613: URL: https://github.com/apache/kafka/pull/19613#discussion_r2071044004 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -2416,15 +2416,15 @@ public static void rebuildProducerState(ProducerStateManag

Re: [PR] [KAFKA-15579] Create GetReplicaLogInfo* handlers [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #18670: URL: https://github.com/apache/kafka/pull/18670#issuecomment-2846229914 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19091: Fix race condition in DelayedFutureTest [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #19553: URL: https://github.com/apache/kafka/pull/19553#issuecomment-2846229661 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] WIP: Test against Java 24 [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #19514: URL: https://github.com/apache/kafka/pull/19514#issuecomment-2846229695 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Move AdminCommandFailedException and AdminOperationException to tools module [kafka]

2025-05-01 Thread via GitHub
chia7712 commented on PR #19614: URL: https://github.com/apache/kafka/pull/19614#issuecomment-2846230164 the failed tests are traced by https://issues.apache.org/jira/browse/KAFKA-19229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] MINOR: Move AdminCommandFailedException and AdminOperationException to tools module [kafka]

2025-05-01 Thread via GitHub
chia7712 merged PR #19614: URL: https://github.com/apache/kafka/pull/19614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19229) fix flaky testShareGroupDescribeWithGroupDescribeAndTopicDescribeAcl and testShareGroupDescribeWithoutGroupDescribeAcl

2025-05-01 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19229: -- Summary: fix flaky testShareGroupDescribeWithGroupDescribeAndTopicDescribeAcl and testShareGroupDescribeWithoutGroupDescribeAcl Key: KAFKA-19229 URL: https://issues.apache.or

[PR] MINOR: use `isEmpty()` to avoid compiler warning [kafka]

2025-05-01 Thread via GitHub
mjsax opened a new pull request, #19616: URL: https://github.com/apache/kafka/pull/19616 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Initial support for OpenJDK CRaC snapshotting [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #13619: URL: https://github.com/apache/kafka/pull/13619#issuecomment-2846245351 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Initial support for OpenJDK CRaC snapshotting [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] closed pull request #13619: Initial support for OpenJDK CRaC snapshotting URL: https://github.com/apache/kafka/pull/13619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-13756: Connect validate endpoint should return proper validatio… [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #13813: URL: https://github.com/apache/kafka/pull/13813#issuecomment-2846245382 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Removed erroneous quotes from CLASSPATH variable, fixes running on Windows with spaces in path (KAFKA-9710). [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #13057: URL: https://github.com/apache/kafka/pull/13057#issuecomment-2846245314 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16951 Notify TransactionManager of disconnects to proactively rediscover Coordinator [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #16390: URL: https://github.com/apache/kafka/pull/16390#issuecomment-2846245452 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2846245505 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] Removed erroneous quotes from CLASSPATH variable, fixes running on Windows with spaces in path (KAFKA-9710). [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] closed pull request #13057: Removed erroneous quotes from CLASSPATH variable, fixes running on Windows with spaces in path (KAFKA-9710). URL: https://github.com/apache/kafka/pull/13057 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-13756: Connect validate endpoint should return proper validatio… [kafka]

2025-05-01 Thread via GitHub
github-actions[bot] closed pull request #13813: KAFKA-13756: Connect validate endpoint should return proper validatio… URL: https://github.com/apache/kafka/pull/13813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] MINOR: improve AdjustStreamThreadCountTest [kafka]

2025-05-01 Thread via GitHub
mjsax opened a new pull request, #19617: URL: https://github.com/apache/kafka/pull/19617 The test is failing once in a while but there is not enough information in the logs to determine the root cause. Adding more information, and fixing thread resource leak. -- This is an automated mess