AndrewJSchofield commented on code in PR #19609:
URL: https://github.com/apache/kafka/pull/19609#discussion_r2070226537
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -178,7 +177,7 @@ public void testMaximumTimeToWait() {
// Initial value before runOnce has been called
assertEquals(ConsumerNetworkThread.MAX_POLL_TIMEOUT_MS,
consumerNetworkThread.maximumTimeToWait());
-
when(requestManagers.entries()).thenReturn(Collections.singletonList(Optional.of(heartbeatRequestManager)));
+
when(requestManagers.entries()).thenReturn(Collections.singletonList(heartbeatRequestManager));
Review Comment:
List.of
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##########
@@ -382,7 +382,7 @@ public void testFetcherCloseClosesFetchSessionsInBroker() {
// NOTE: by design the FetchRequestManager doesn't perform network I/O
internally. That means that calling
// the close() method with a Timer will NOT send out the close session
requests on close. The network
// I/O logic is handled inside ConsumerNetworkThread.runAtClose, so we
need to run that logic here.
- ConsumerNetworkThread.runAtClose(singletonList(Optional.of(fetcher)),
networkClientDelegate, time.milliseconds());
+ ConsumerNetworkThread.runAtClose(singletonList(fetcher),
networkClientDelegate, time.milliseconds());
Review Comment:
List.of here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
