lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2070595633
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG =
CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than
zero will cause the client to resend any record whose send fails with a
potentially transient error."
- + " Note that this retry is no different than if the client resent
the record upon receiving the error."
- + " Produce requests will be failed before the number of retries
has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first
before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" +
DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a
request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to
resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed,
fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG
</code> expires."
+ + " Note that this automatic retry is no different than if the
client resent the record upon receiving the error."
Review Comment:
Same page on the meaning (I also take it as "the client resent the request"
== "application code calls send(...)").
And totally agree with you that this is wrong from the idempotence point of
view, my point was only that I read it as making a valid point about the
automatic retries not doing any magic, just resend. I changed the sentence, let
me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
