mjsax commented on code in PR #19580:
URL: https://github.com/apache/kafka/pull/19580#discussion_r2062743713
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamGlobalKTableJoinTest.java:
##
@@ -248,10 +263,54 @@ public void shouldNotJoinOnNullKeyMapperVal
[
https://issues.apache.org/jira/browse/KAFKA-19208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-19208:
---
Assignee: Matthias J. Sax
> KStream-GlobalKTable join should not drop left-null-key
Matthias J. Sax created KAFKA-19208:
---
Summary: KStream-GlobalKTable join should not drop left-null-key
record
Key: KAFKA-19208
URL: https://issues.apache.org/jira/browse/KAFKA-19208
Project: Kafka
mjsax opened a new pull request, #19580:
URL: https://github.com/apache/kafka/pull/19580
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
frankvicky commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2062833316
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1640,33 +1599,6 @@ public synchronized boolean close(final CloseOptions
options) throws
frankvicky commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2062833316
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1640,33 +1599,6 @@ public synchronized boolean close(final CloseOptions
options) throws
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2833884934
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
m1a2st commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2062839985
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##
@@ -47,13 +47,10 @@ public ListOffsetsEvent(Map
timestampToSearch,
github-actions[bot] commented on PR #18332:
URL: https://github.com/apache/kafka/pull/18332#issuecomment-2833907283
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
xijiu commented on PR #19578:
URL: https://github.com/apache/kafka/pull/19578#issuecomment-2833933264
> Thanks for this PR, left little comments
Thanks for CR, and I have fixed them, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Yunyung commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062697323
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
I've opened the MINOR for this, thanks.
https:
ijuma commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2062700142
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ListOffsetsIntegrationTest.java:
##
@@ -243,8 +241,7 @@ private void verifyListOffsets(S
ijuma commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2062700142
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ListOffsetsIntegrationTest.java:
##
@@ -243,8 +241,7 @@ private void verifyListOffsets(S
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947651#comment-17947651
]
Omnia Ibrahim edited comment on KAFKA-19125 at 4/27/25 7:26 PM:
--
chirag-wadhwa5 commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2062982757
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -54,7 +55,7 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterIns
chia7712 commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2062996742
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##
@@ -47,13 +46,10 @@ public ListOffsetsEvent(Map
timestampToSearc
showuon commented on PR #19565:
URL: https://github.com/apache/kafka/pull/19565#issuecomment-2834156939
@tinaselenge , could you take a look at the error:
```
* What went wrong:
Execution failed for task ':core:compileTestScala'.
> Could not resolve all files for configuration ':c
UladzislauBlok commented on PR #19553:
URL: https://github.com/apache/kafka/pull/19553#issuecomment-2833447360
@FrankYang0529 Hello, you've created Jira ticked
[19091](https://issues.apache.org/jira/browse/KAFKA-19091). This PR is fix for
that. Could you please review this?
--
This is an
chia7712 merged PR #19535:
URL: https://github.com/apache/kafka/pull/19535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062663644
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
If so, I think we should avoid having these insid
ijuma commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062663223
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
Oh, is it because of the collection converters?
chia7712 commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062664349
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
yes, see
https://github.com/apache/kafka/blob
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-19125:
-
Assignee: Omnia Ibrahim
> Implement Large message reference-based Serializer
>
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947608#comment-17947608
]
Omnia Ibrahim commented on KAFKA-19125:
---
Hi [~kulagaivan] yea I am working on this
[
https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19183.
Fix Version/s: 4.1.0
Resolution: Fixed
> Replace Pool with ConcurrentHashMap
>
ijuma commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062675061
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
Sounds good.
--
This is an automated message
dajac commented on PR #19572:
URL: https://github.com/apache/kafka/pull/19572#issuecomment-2833547775
I am going to merge it so I can work on the next ones. @lianetm @frankvicky
If you have further comments, I can address them separately.
--
This is an automated message from the Apache Gi
dajac merged PR #19572:
URL: https://github.com/apache/kafka/pull/19572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062663094
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
Why is this needed?
--
This is an automated m
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947634#comment-17947634
]
Ivan Kulaga commented on KAFKA-19125:
-
[~omnia_h_ibrahim] it wasn't a question :)
Si
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947634#comment-17947634
]
Ivan Kulaga edited comment on KAFKA-19125 at 4/27/25 5:05 PM:
showuon commented on PR #19565:
URL: https://github.com/apache/kafka/pull/19565#issuecomment-2833727729
Re-running CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
showuon merged PR #19564:
URL: https://github.com/apache/kafka/pull/19564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Yunyung commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062697323
##
checkstyle/import-control-clients-integration-tests.xml:
##
@@ -21,6 +21,7 @@
+
Review Comment:
I've opened the MINOR for this, thanks.
--
[
https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947651#comment-17947651
]
Omnia Ibrahim commented on KAFKA-19125:
---
Hi [~kulagaivan] usually Jiras that need
chia7712 commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2062814664
##
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##
@@ -66,8 +68,16 @@ public abstract class AbstractKafkaConfig extends
AbstractConfi
chia7712 commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2062806639
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java:
##
@@ -154,7 +155,7 @@ public static List
remoteStorageManagers(Seq br
37 matches
Mail list logo
