chia7712 commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2062806639
##########
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java:
##########
@@ -154,7 +155,7 @@ public static List<LocalTieredStorage>
remoteStorageManagers(Seq<KafkaBroker> br
public static List<BrokerLocalStorage> localStorages(Seq<KafkaBroker>
brokers) {
return CollectionConverters.asJava(brokers).stream()
- .map(b -> new BrokerLocalStorage(b.config().brokerId(),
CollectionConverters.asJava(b.config().logDirs().toSet()),
+ .map(b -> new BrokerLocalStorage(b.config().brokerId(), new
HashSet<>(b.config().logDirs()),
Review Comment:
`Set.copyOf`
##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsWithTieredStoreTest.java:
##########
@@ -75,7 +76,7 @@ public Properties topicConfig() {
public void
maybeWaitForAtLeastOneSegmentUpload(scala.collection.Seq<TopicPartition>
topicPartitions) {
CollectionConverters.asJava(topicPartitions).forEach(topicPartition ->
{
List<BrokerLocalStorage> localStorages =
CollectionConverters.asJava(brokers()).stream()
- .map(b -> new BrokerLocalStorage(b.config().brokerId(),
CollectionConverters.asJava(b.config().logDirs().toSet()),
STORAGE_WAIT_TIMEOUT_SEC))
+ .map(b -> new BrokerLocalStorage(b.config().brokerId(),
new HashSet<>(b.config().logDirs()), STORAGE_WAIT_TIMEOUT_SEC))
Review Comment:
`Set.copyOf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
