AndrewJSchofield commented on code in PR #19293:
URL: https://github.com/apache/kafka/pull/19293#discussion_r2039016521
##
server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
smjn opened a new pull request, #19443:
URL: https://github.com/apache/kafka/pull/19443
* There could be scenarios where share partition records in
`__share_group_state` internal topic have not been updated for a while implying
these partitions are basically cold.
* In this situation, th
mimaison commented on code in PR #19424:
URL: https://github.com/apache/kafka/pull/19424#discussion_r2039048773
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1173,14 +1173,15 @@ class KafkaConfigTest {
assertEquals(123L, config.logFlushIntervalMs)
aliehsaeedii commented on PR #19423:
URL: https://github.com/apache/kafka/pull/19423#issuecomment-2796239979
Thanks, @lucasbru. Essential support that was unintentionally overlooked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
apoorvmittal10 merged PR #19435:
URL: https://github.com/apache/kafka/pull/19435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
chirag-wadhwa5 commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2039100729
##
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java:
##
@@ -169,21 +176,69 @@ public synchronized boolean tryEvict(long now) {
lucasbru merged PR #19423:
URL: https://github.com/apache/kafka/pull/19423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #19438:
URL: https://github.com/apache/kafka/pull/19438#discussion_r2039158740
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopicsTest.java:
##
@@ -149,14 +149,14 @@ public void shouldContainNonSou
lucasbru merged PR #19438:
URL: https://github.com/apache/kafka/pull/19438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gongxuanzhang commented on PR #19356:
URL: https://github.com/apache/kafka/pull/19356#issuecomment-2796352614
@chia7712 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
priyankaku opened a new pull request, #19444:
URL: https://github.com/apache/kafka/pull/19444
When using a connector that requires a schema, such as JDBC connectors, with
JSON messages, the current JSONConverter necessitates including the schema
within every message. To address this, we are
AndrewJSchofield commented on code in PR #19417:
URL: https://github.com/apache/kafka/pull/19417#discussion_r2039155579
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -381,18 +381,17 @@ public class ConsumerConfig extends AbstractConfig {
m1a2st commented on PR #19371:
URL: https://github.com/apache/kafka/pull/19371#issuecomment-2796373720
Thanks for @junrao, @chia7712 comments, This PR is already for review, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/KAFKA-16913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943498#comment-17943498
]
Priyanka K U commented on KAFKA-16913:
--
Raised a New PR for this KIP
[https://cwi
chia7712 merged PR #19441:
URL: https://github.com/apache/kafka/pull/19441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorcan reassigned KAFKA-16869:
--
Assignee: Lorcan
> Rewrite HighAvailabilityTaskAssignor to implement the new TaskAssignor
> interfac
wernerdv opened a new pull request, #19446:
URL: https://github.com/apache/kafka/pull/19446
- Fixed typos
- Fixed IDEA code inspection warnings
- Removed unused fields and methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wernerdv commented on PR #19446:
URL: https://github.com/apache/kafka/pull/19446#issuecomment-2796479700
@mjsax @cadonna Hello, please take a look at this when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
smjn commented on PR #19443:
URL: https://github.com/apache/kafka/pull/19443#issuecomment-2796503058
### Sample run
```
{"key":{"type":0,"data":{"groupId":"gs1","topicId":"usMKwc_eQ5214UuoShlXIg","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":0,"stateEpoch":1,"leaderE
ShivsundarR opened a new pull request, #19447:
URL: https://github.com/apache/kafka/pull/19447
*What*
- There was a bug in `ConsoleShareConsumer` where the delivery count
received in the `ShareFetchResponse` was not sent to the formatter to be shown
to the user. PR fixes the bug by p
showuon commented on PR #19448:
URL: https://github.com/apache/kafka/pull/19448#issuecomment-2796545810
@frankvicky , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon opened a new pull request, #19448:
URL: https://github.com/apache/kafka/pull/19448
Fix failed
`kafka.server.KRaftClusterTest."testDescribeKRaftVersion(boolean)` test. It is
failing in [3.9
branch](https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.9/186/#showFailuresLink).
lucasbru merged PR #19436:
URL: https://github.com/apache/kafka/pull/19436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on PR #19293:
URL: https://github.com/apache/kafka/pull/19293#issuecomment-2796604695
There is a final piece to this change. When
`MetadataVersion.LATEST_PRODUCTION` is moved to `IBP_4_1_IV1` or later (as it
will before AK 4.1 releases), we must change `ShareVersi
AndrewJSchofield merged PR #19293:
URL: https://github.com/apache/kafka/pull/19293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
FrankYang0529 commented on code in PR #19433:
URL: https://github.com/apache/kafka/pull/19433#discussion_r2039384250
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -154,6 +166,173 @@ private void printGroupInfo(List groups) {
}
priyankaku commented on PR #19444:
URL: https://github.com/apache/kafka/pull/19444#issuecomment-2796713800
Will be raising a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
priyankaku closed pull request #19444: KAFKA-16913 - Support external schemas
in JSONConverter
URL: https://github.com/apache/kafka/pull/19444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/KAFKA-16913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943498#comment-17943498
]
Priyanka K U edited comment on KAFKA-16913 at 4/11/25 12:23 PM:
--
priyankaku opened a new pull request, #19449:
URL: https://github.com/apache/kafka/pull/19449
When using a connector that requires a schema, such as JDBC connectors, with
JSON messages, the current JSONConverter necessitates including the schema
within every message. To address this, we are
[
https://issues.apache.org/jira/browse/KAFKA-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alieh Saeedi updated KAFKA-19128:
-
Description:
Kafka Streams calls `prepareCommit()` in `Taskmanager#closeTaskDirty()`. The
initi
[
https://issues.apache.org/jira/browse/KAFKA-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alieh Saeedi updated KAFKA-19128:
-
Description:
Kafka Streams calls `prepareCommit()` in `Taskmanager#closeTaskDirty()`. The
initi
Alieh Saeedi created KAFKA-19128:
Summary: Kafka Streams should not get offsets when close dirty
Key: KAFKA-19128
URL: https://issues.apache.org/jira/browse/KAFKA-19128
Project: Kafka
Issue T
aliehsaeedii opened a new pull request, #19450:
URL: https://github.com/apache/kafka/pull/19450
Kafka Streams calls `prepareCommit()` in `Taskmanager#closeTaskDirty()`.
However, the dirty task must not get committed and therefore, prepare-commit
tasks such as getting offsets should not be n
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2039566989
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1011,6 +1011,8 @@ private Optional
releaseAcquiredRecordsForPerOffsetBatch(String membe
frankvicky commented on code in PR #19448:
URL: https://github.com/apache/kafka/pull/19448#discussion_r2039583366
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##
@@ -149,6 +149,32 @@ public BootstrapMetadata copyWithOnlyVersion() {
frankvicky commented on code in PR #19448:
URL: https://github.com/apache/kafka/pull/19448#discussion_r2039603484
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##
@@ -149,6 +149,32 @@ public BootstrapMetadata copyWithOnlyVersion() {
AndrewJSchofield commented on code in PR #19431:
URL: https://github.com/apache/kafka/pull/19431#discussion_r2039571274
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1580,83 +1574,51 @@ public
CompletableFuture delete
mimaison commented on code in PR #19426:
URL: https://github.com/apache/kafka/pull/19426#discussion_r2039648616
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -252,7 +252,7 @@ class BrokerServer(
forwardingManager = new
ForwardingManagerImpl(clientToContro
cadonna commented on code in PR #19433:
URL: https://github.com/apache/kafka/pull/19433#discussion_r2037630380
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -154,6 +166,173 @@ private void printGroupInfo(List groups) {
}
AndrewJSchofield merged PR #19447:
URL: https://github.com/apache/kafka/pull/19447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
cadonna commented on code in PR #19275:
URL: https://github.com/apache/kafka/pull/19275#discussion_r2039703906
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -99,8 +99,8 @@ SmokeTestDriver.VerificationRe
chia7712 commented on code in PR #19448:
URL: https://github.com/apache/kafka/pull/19448#discussion_r2039707245
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##
@@ -149,6 +149,32 @@ public BootstrapMetadata copyWithOnlyVersion() {
frankvicky commented on code in PR #19448:
URL: https://github.com/apache/kafka/pull/19448#discussion_r2039735443
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##
@@ -149,6 +149,32 @@ public BootstrapMetadata copyWithOnlyVersion() {
TengYao Chi created KAFKA-19129:
---
Summary: Add a comment to BootstrapMetadata#copyWithFeatureRecord
Key: KAFKA-19129
URL: https://issues.apache.org/jira/browse/KAFKA-19129
Project: Kafka
Issue
omkreddy merged PR #19362:
URL: https://github.com/apache/kafka/pull/19362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cadonna opened a new pull request, #19453:
URL: https://github.com/apache/kafka/pull/19453
Improves a variable name and handling of an Optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cadonna commented on code in PR #19275:
URL: https://github.com/apache/kafka/pull/19275#discussion_r2039706952
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -432,19 +428,8 @@ private List getTaskI
FrankYang0529 commented on code in PR #19424:
URL: https://github.com/apache/kafka/pull/19424#discussion_r2039838645
##
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##
@@ -166,11 +164,6 @@ public KafkaApisBuilder setTime(Time time) {
return this;
m1a2st commented on code in PR #19380:
URL: https://github.com/apache/kafka/pull/19380#discussion_r2039815019
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -564,14 +563,14 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationT
cadonna commented on PR #19275:
URL: https://github.com/apache/kafka/pull/19275#issuecomment-2797218102
FYI: I will not be online for the next 1.5 weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mimaison commented on code in PR #19424:
URL: https://github.com/apache/kafka/pull/19424#discussion_r2039850332
##
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##
@@ -166,11 +164,6 @@ public KafkaApisBuilder setTime(Time time) {
return this;
}
mimaison commented on PR #19050:
URL: https://github.com/apache/kafka/pull/19050#issuecomment-2797321585
> Overall LGTM. Will you be addressing [#19068
(comment)](https://github.com/apache/kafka/pull/19068#discussion_r2033623742)
in this PR?
I pushed a commit to address it.
--
Th
FrankYang0529 commented on code in PR #19424:
URL: https://github.com/apache/kafka/pull/19424#discussion_r2039838966
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1173,14 +1173,15 @@ class KafkaConfigTest {
assertEquals(123L, config.logFlushInterval
[
https://issues.apache.org/jira/browse/KAFKA-19123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19123:
---
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> the buffer of forwarded request should be released after receiving t
FrankYang0529 commented on code in PR #19426:
URL: https://github.com/apache/kafka/pull/19426#discussion_r2039487932
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -252,7 +252,7 @@ class BrokerServer(
forwardingManager = new
ForwardingManagerImpl(clientToC
junrao merged PR #19387:
URL: https://github.com/apache/kafka/pull/19387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
aliehsaeedii commented on PR #19433:
URL: https://github.com/apache/kafka/pull/19433#issuecomment-2796990486
> Leave comments about format. Will we have integration test for
`kafka-streams-groups.sh` like `DescribeConsumerGroupTest`?
Yes. In the follow-up PRs.
--
This is an automat
[
https://issues.apache.org/jira/browse/KAFKA-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-19128:
Component/s: streams
> Kafka Streams should not get offsets when close dirty
> ---
wernerdv commented on PR #19387:
URL: https://github.com/apache/kafka/pull/19387#issuecomment-2797455575
@mimaison @junrao Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
sjhajharia commented on code in PR #19380:
URL: https://github.com/apache/kafka/pull/19380#discussion_r2039918241
##
core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala:
##
@@ -60,8 +60,8 @@ class ProducerSendWhileDeletionTest extends
IntegrationTestHa
sjhajharia commented on PR #19380:
URL: https://github.com/apache/kafka/pull/19380#issuecomment-2797462875
Thanks @m1a2st for your comments.
I have updated the PR accordingly. Requesting a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-19103:
--
Assignee: Yunchi Pang (was: Bolin Lin)
> Remove OffsetConfig
> ---
>
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2039924782
##
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java:
##
@@ -886,7 +888,6 @@ public void testProduceResponseVersions() throws Exception {
t
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2039952003
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Oth
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943638#comment-17943638
]
Vladimir Bukhtoyarov commented on KAFKA-16640:
--
[~frankvicky] *Using* does
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2039963445
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1361,10 +1366,10 @@ class ReplicaManager(val config: KafkaConfig,
*/
private def appendToLocalLog
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943638#comment-17943638
]
Vladimir Bukhtoyarov edited comment on KAFKA-16640 at 4/11/25 5:18 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943638#comment-17943638
]
Vladimir Bukhtoyarov edited comment on KAFKA-16640 at 4/11/25 5:19 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943643#comment-17943643
]
Vladimir Bukhtoyarov commented on KAFKA-16640:
--
I see that fix has been al
[
https://issues.apache.org/jira/browse/KAFKA-17078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17078:
Fix Version/s: 3.9.1
> Add SecurityManager reflective shim
> -
mjsax commented on PR #18930:
URL: https://github.com/apache/kafka/pull/18930#issuecomment-2798074476
Thanks @mimaison -- that's fair. I am totally ok to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax commented on code in PR #18816:
URL: https://github.com/apache/kafka/pull/18816#discussion_r2040343759
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##
@@ -62,18 +63,23 @@
import static org.hamcrest.CoreMatcher
mjsax commented on code in PR #18816:
URL: https://github.com/apache/kafka/pull/18816#discussion_r2040344194
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##
@@ -89,8 +95,81 @@ public class ChangeLoggingKeyValueBytesS
mjsax commented on PR #18837:
URL: https://github.com/apache/kafka/pull/18837#issuecomment-2798089312
@cushon -- Do you still have interest to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mjsax commented on PR #18673:
URL: https://github.com/apache/kafka/pull/18673#issuecomment-2798090506
@ukpagrace -- What the status on this PR? Would be great to complete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbejeck commented on code in PR #19450:
URL: https://github.com/apache/kafka/pull/19450#discussion_r2040351769
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1479,7 +1479,7 @@ private void closeTaskDirty(final Task task, final
boo
cushon commented on code in PR #18837:
URL: https://github.com/apache/kafka/pull/18837#discussion_r2040354567
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java:
##
@@ -192,7 +192,7 @@ private stati
cushon commented on PR #18837:
URL: https://github.com/apache/kafka/pull/18837#issuecomment-2798094752
> @cushon -- Do you still have interest to complete this PR?
Sure thanks, I addressed the review comment, please take another look
--
This is an automated message from the Apache G
Colin McCabe created KAFKA-19130:
Summary: Do not add fenced brokers to BrokerRegistrationTracker on
startup
Key: KAFKA-19130
URL: https://issues.apache.org/jira/browse/KAFKA-19130
Project: Kafka
cmccabe opened a new pull request, #19454:
URL: https://github.com/apache/kafka/pull/19454
When the controller starts up (or becomes active after being inactive), we
add all of the registered brokers to BrokerRegistrationTracker so that they
will not be accidentally fenced the next time we
[
https://issues.apache.org/jira/browse/KAFKA-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-19130:
-
Description:
When the controller starts up (or becomes active after being inactive), we add
all
cmccabe commented on PR #19428:
URL: https://github.com/apache/kafka/pull/19428#issuecomment-2798145256
I think this PR should be a better fix
https://github.com/apache/kafka/pull/19454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
cmccabe commented on PR #19296:
URL: https://github.com/apache/kafka/pull/19296#issuecomment-2798145663
Thank you for spotting the flaw here, @splett2 .
@ahuang98 @splett2 @jsancio I think this PR should be a better fix
https://github.com/apache/kafka/pull/19454
--
This is an autom
ahuang98 commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040390910
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosecon
ahuang98 commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040393861
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosecon
ahuang98 commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040393861
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosecon
ahuang98 commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040390910
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosecon
cmccabe commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040427593
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosecond
wozhuzaisi commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2040410979
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanosec
kirktrue commented on PR #19440:
URL: https://github.com/apache/kafka/pull/19440#issuecomment-2798230694
Thanks @m1a2st!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
showuon merged PR #19448:
URL: https://github.com/apache/kafka/pull/19448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
zt52875287 opened a new pull request, #19442:
URL: https://github.com/apache/kafka/pull/19442
This patch simplifies the implementation of PartitionStates#update by
removing the unnecessary grouping of TopicPartitions by topic. The original
logic constructed an intermediate map by topic name
[
https://issues.apache.org/jira/browse/KAFKA-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19112:
---
Assignee: 黃竣陽
> cleanup.policy shouldn't be empty
> -
>
> K
ukpagrace commented on PR #18673:
URL: https://github.com/apache/kafka/pull/18673#issuecomment-2798439485
Done @mjsax and @bbejeck. Sorry it took this long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
FrankYang0529 commented on code in PR #19424:
URL: https://github.com/apache/kafka/pull/19424#discussion_r2040518849
##
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##
@@ -166,11 +164,6 @@ public KafkaApisBuilder setTime(Time time) {
return this;
FrankYang0529 commented on code in PR #19345:
URL: https://github.com/apache/kafka/pull/19345#discussion_r2040587319
##
core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala:
##
@@ -441,7 +441,36 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943724#comment-17943724
]
Chia-Ping Tsai commented on KAFKA-16640:
[~vladimir.bukhtoyarov] thanks for rep
chia7712 commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2040508190
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -21,7 +21,7 @@ import kafka.coordinator.group.{CoordinatorLoaderImpl,
CoordinatorPartitionWrite
import
FrankYang0529 commented on code in PR #19442:
URL: https://github.com/apache/kafka/pull/19442#discussion_r2040530970
##
clients/src/main/java/org/apache/kafka/common/internals/PartitionStates.java:
##
@@ -138,17 +138,7 @@ private void updateSize() {
}
private void up
1 - 100 of 105 matches
Mail list logo
