bbejeck commented on code in PR #19450:
URL: https://github.com/apache/kafka/pull/19450#discussion_r2040351769
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1479,7 +1479,7 @@ private void closeTaskDirty(final Task task, final
boolean removeFromTasksRegist
try {
// we call this function only to flush the case if necessary
// before suspending and closing the topology
- task.prepareCommit();
+ task.flush();
Review Comment:
The `SteamTask.prepareCommit()` set a boolean flag `hasPending TxCommit` if
using EOS and the `commitNeeded` flag is `true` - is it OK to bypass that? I'm
thinking so but I'd like to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
