Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-04-09 Thread via GitHub
leaf-soba commented on code in PR #18816: URL: https://github.com/apache/kafka/pull/18816#discussion_r2036372806 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -62,18 +63,23 @@ import static org.hamcrest.CoreMat

Re: [PR] MINOR: fix the README and 3.7 jsa_launch command [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #18300: URL: https://github.com/apache/kafka/pull/18300#issuecomment-2791469655 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18167 - Disable TLS session ticket extension [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] closed pull request #18070: KAFKA-18167 - Disable TLS session ticket extension URL: https://github.com/apache/kafka/pull/18070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16373: KIP-1028: Addressing Docker Official Images PR Comments for JVM, Native and Docker Official Images [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #16664: URL: https://github.com/apache/kafka/pull/16664#issuecomment-2791469517 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] closed pull request #15312: KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? URL: https://github.com/apache/kafka/pull/15312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-04-09 Thread via GitHub
DL1231 opened a new pull request, #19430: URL: https://github.com/apache/kafka/pull/19430 For records which are automatically released as a result of closing a share session normally, the delivery count should not be incremented. These records were fetched but they were not actually deliver

[jira] [Updated] (KAFKA-19103) Remove OffsetConfig

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19103: --- Priority: Trivial (was: Major) > Remove OffsetConfig > --- > >

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-09 Thread via GitHub
mimaison commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2031926411 ## build.gradle: ## @@ -3737,6 +3737,7 @@ project(':connect:mirror') { testImplementation project(':core') testImplementation project(':test-common:test-comm

Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-04-09 Thread via GitHub
leaf-soba commented on code in PR #18816: URL: https://github.com/apache/kafka/pull/18816#discussion_r2036378149 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -89,8 +95,81 @@ public class ChangeLoggingKeyValueBy

Re: [PR] KAFKA-19047: Allow quickly re-registering brokers that are in controlled shutdown [kafka]

2025-04-09 Thread via GitHub
splett2 commented on code in PR #19296: URL: https://github.com/apache/kafka/pull/19296#discussion_r2036067232 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -353,10 +353,10 @@ public ControllerResult registerBroker( if (existin

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
ableegoldman commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2790896198 @showuon I think this PR is pretty much ready. I'll give it another quick pass right now and then merge to unblock 3.9.1 -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
ableegoldman merged PR #19188: URL: https://github.com/apache/kafka/pull/19188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Updated] (KAFKA-18962) StateRestoreListener onBatchRestored method is called with the totalRestored on GlobalStateStore reprocess

2025-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18962: Fix Version/s: 4.1.0 3.9.1 4.0.1 > StateRestoreListe

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-09 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2031745262 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -6671,15 +6693,441 @@ private String assertionFailedMessage(SharePartition sharePartiti

[PR] KAFKA-19047: Allow quickly re-registering brokers that were shutdown [kafka]

2025-04-09 Thread via GitHub
ahuang98 opened a new pull request, #19428: URL: https://github.com/apache/kafka/pull/19428 https://github.com/confluentinc/ce-kafka/pull/20044 fails to account that brokers finishing controlled shutdown eventually become fenced and clear their inControlledShutdown bool. -- This is an au

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2036147271 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2475,6 +2496,192 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-09 Thread via GitHub
Rancho-7 commented on PR #19384: URL: https://github.com/apache/kafka/pull/19384#issuecomment-2787964810 > @Rancho-7 could you please following code too? > > https://github.com/apache/kafka/blob/2f086d188fe42db290d7037e83f552075e8bfcaa/core/src/main/scala/kafka/server/KafkaRequestHand

[jira] [Comment Edited] (KAFKA-19103) Remove OffsetConfig

2025-04-09 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941677#comment-17941677 ] Bolin Lin edited comment on KAFKA-19103 at 4/7/25 5:44 PM: --- Hi

[jira] [Resolved] (KAFKA-19114) Backport KAFKA-18991 to 4.0 and 3.9

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-19114. Resolution: Fixed > Backport KAFKA-18991 to 4.0 and 3.9 >

[jira] [Commented] (KAFKA-19114) Backport KAFKA-18991 to 4.0 and 3.9

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942319#comment-17942319 ] José Armando García Sancio commented on KAFKA-19114: [~chia7712] I a

[jira] [Commented] (KAFKA-18991) AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942320#comment-17942320 ] José Armando García Sancio commented on KAFKA-18991: I cherry picked

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
showuon commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2791265676 Thank you @ableegoldman ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Created] (KAFKA-19122) updateClusterMetadata receives duplicate PartitionInfo

2025-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19122: -- Summary: updateClusterMetadata receives duplicate PartitionInfo Key: KAFKA-19122 URL: https://issues.apache.org/jira/browse/KAFKA-19122 Project: Kafka Is

[jira] [Updated] (KAFKA-19122) updateClusterMetadata receives multiples PartitionInfo

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19122: --- Affects Version/s: 4.0.0 > updateClusterMetadata receives multiples PartitionInfo >

[jira] [Commented] (KAFKA-19114) Backport KAFKA-18991 to 4.0, 3.9 and 3.8

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942241#comment-17942241 ] José Armando García Sancio commented on KAFKA-19114: [~chia7712] , I

[jira] [Updated] (KAFKA-19122) updateClusterMetadata receives multiples PartitionInfo

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19122: --- Summary: updateClusterMetadata receives multiples PartitionInfo (was: updateClusterMetadata

[jira] [Updated] (KAFKA-19122) updateClusterMetadata receives multiples PartitionInfo

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19122: --- Fix Version/s: 4.1.0 4.0.1 > updateClusterMetadata receives multiples Par

[jira] [Updated] (KAFKA-19122) updateClusterMetadata receives multiples PartitionInfo

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19122: --- Priority: Critical (was: Major) > updateClusterMetadata receives multiples PartitionInfo >

[jira] [Updated] (KAFKA-19114) Backport KAFKA-18991 to 4.0 and 3.9

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19114: --- Summary: Backport KAFKA-18991 to 4.0 and 3.9 (was: Backport KAFKA-18

[jira] [Updated] (KAFKA-18991) AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18991: --- Fix Version/s: 4.0.1 > AbstractFetcherThread should verify the curre

[jira] [Resolved] (KAFKA-19037) Integrate consumer-side code with Streams

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-19037. --- Resolution: Fixed > Integrate consumer-side code with Streams > ---

[jira] [Resolved] (KAFKA-19090) Move DelayedFuture and DelayedFuturePurgatory to server module

2025-04-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-19090. Fix Version/s: 4.1.0 Resolution: Fixed > Move DelayedFuture and DelayedFuturePurgat

Re: [PR] KAFKA-18287: Add support for kafka-streams-groups.sh --list [kafka]

2025-04-09 Thread via GitHub
cadonna commented on code in PR #19422: URL: https://github.com/apache/kafka/pull/19422#discussion_r2035229373 ## tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandUnitTest.java: ## Review Comment: As far as I can see in the code base we tend to name int

Re: [PR] [WIP]KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-09 Thread via GitHub
chia7712 commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2790393621 Maybe we can add a internal config to allow tests to define small size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
ableegoldman commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2790900582 @showuon merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
ableegoldman commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2790946266 cherrypicked to 4.0 and 3.9 cc @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-09 Thread via GitHub
johnny94 commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2034509289 ## trogdor/README.md: ## @@ -6,9 +6,9 @@ Trogdor can run benchmarks and other workloads. Trogdor can also inject faults i Quickstart =

[PR] KAFKA-19119: Move ApiVersionManager/SimpleApiVersionManager to server [kafka]

2025-04-09 Thread via GitHub
mimaison opened a new pull request, #19426: URL: https://github.com/apache/kafka/pull/19426 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Commented] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942234#comment-17942234 ] Bruno Cadonna commented on KAFKA-19110: --- That would be great! > Add missing unit

Re: [PR] KAFKA-15370: ACL changes to support 2PC (KIP-939) [kafka]

2025-04-09 Thread via GitHub
rreddy-22 commented on code in PR #19364: URL: https://github.com/apache/kafka/pull/19364#discussion_r2036224264 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1520,6 +1520,10 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendErrorRes

[jira] [Updated] (KAFKA-18991) AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18991: --- Fix Version/s: 3.9.1 > AbstractFetcherThread should verify the curre

[jira] [Assigned] (KAFKA-19114) Backport KAFKA-18991 to 4.0 and 3.9

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-19114: -- Assignee: José Armando García Sancio (was: Chia-Ping Tsai) >

Re: [PR] KAFKA-19047: Allow quickly re-registering brokers that were shutdown [kafka]

2025-04-09 Thread via GitHub
cmccabe commented on PR #19428: URL: https://github.com/apache/kafka/pull/19428#issuecomment-2791166073 I don’t see why a broker being fenced or not should have an effect on this. Removing the session seems reasonable actually. It’s a bit messy, changing that part of the code is

Re: [PR] KAFKA-19047: Allow quickly re-registering brokers that were shutdown [kafka]

2025-04-09 Thread via GitHub
ahuang98 commented on PR #19428: URL: https://github.com/apache/kafka/pull/19428#issuecomment-2791164065 It doesn't seem worth to try removing sessions preemptively, e.g. in ReplicationControlManager#processBrokerHeartbeat skipping broker session touch if `states.current().equals(CONTROLLED

[PR] KAFKA-19082: [1/3] Add client config for enable2PC and overloaded initProducerId (KIP-939) [kafka]

2025-04-09 Thread via GitHub
rreddy-22 opened a new pull request, #19429: URL: https://github.com/apache/kafka/pull/19429 This is part of the client side changes required to enable 2PC for KIP-939 **Producer Config:** transaction.two.phase.commit.enable The default would be ‘false’. If set to ‘true’, the brok

Re: [PR] KAFKA-19047: Allow quickly re-registering brokers that are in controlled shutdown [kafka]

2025-04-09 Thread via GitHub
ahuang98 commented on code in PR #19296: URL: https://github.com/apache/kafka/pull/19296#discussion_r2036240858 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -353,10 +353,10 @@ public ControllerResult registerBroker( if (existi

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-09 Thread via GitHub
mjsax commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2791211401 Thanks all! Great to see this getting merged and making the 3.9.1 cut! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Updated] (KAFKA-19118) Enable KIP-1071 in existing streams integration tests

2025-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19118: Component/s: streams unit tests > Enable KIP-1071 in existing streams int

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-09 Thread via GitHub
lucasbru commented on PR #19425: URL: https://github.com/apache/kafka/pull/19425#issuecomment-2789605788 PTAL @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-04-09 Thread via GitHub
JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2790154133 @AndrewJSchofield Thanks for your feedback! I'll start by referencing the implementation in [#19328](https://github.com/apache/kafka/pull/19328) to implement a first version. I'll

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-09 Thread via GitHub
Yunyung commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2034520490 ## README.md: ## @@ -263,10 +267,28 @@ default. See https://www.lightbend.com/blog/scala-inliner-optimizer for more det See [tests/README.md](tests/README.md). +#

[PR] WIP: Use one event queue [kafka]

2025-04-09 Thread via GitHub
cadonna opened a new pull request, #19421: URL: https://github.com/apache/kafka/pull/19421 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-09 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2035323732 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,762 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Assigned] (KAFKA-19118) Enable KIP-1071 in existing streams integration tests

2025-04-09 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19118: -- Assignee: Lucas Brutschy > Enable KIP-1071 in existing streams integration tests > --

[jira] [Comment Edited] (KAFKA-19116) Deletion of share group offsets does not reset the position as expected

2025-04-09 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942211#comment-17942211 ] Sushant Mahajan edited comment on KAFKA-19116 at 4/9/25 2:36 PM: -

Re: [PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-09 Thread via GitHub
smjn commented on PR #19363: URL: https://github.com/apache/kafka/pull/19363#issuecomment-2790191018 Thanks for the review, @AndrewJSchofield Incorporated all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-18287: Add support for kafka-streams-groups.sh --list [kafka]

2025-04-09 Thread via GitHub
cadonna merged PR #19422: URL: https://github.com/apache/kafka/pull/19422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-18287. --- Resolution: Fixed > Add support for kafka-streams-groups.sh --list > ---

[jira] [Reopened] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-18287: --- > Add support for kafka-streams-groups.sh --list > -

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-09 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2035180146 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -85,4 +85,83 @@ class ProducerSendWhileDeletionTest extends IntegrationTestHarn

[PR] MINOR: fix docker_release example [kafka]

2025-04-09 Thread via GitHub
yx9o opened a new pull request, #19427: URL: https://github.com/apache/kafka/pull/19427 Fix docker_release example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-09 Thread via GitHub
AndrewJSchofield commented on code in PR #19363: URL: https://github.com/apache/kafka/pull/19363#discussion_r2035285341 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java: ## @@ -814,6 +814,19 @@ public static CoordinatorReco

[jira] [Updated] (KAFKA-18723) KRaft must handle corrupted records in the fetch response

2025-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18723: --- Fix Version/s: (was: 3.8.2) (was: 3.7.3)

[jira] [Commented] (KAFKA-19114) Backport KAFKA-18991 to 4.0, 3.9 and 3.8

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942242#comment-17942242 ] Chia-Ping Tsai commented on KAFKA-19114: [~jsancio] thanks for response. Please

[jira] [Created] (KAFKA-19121) Move AddPartitionsToTxnConfig, TransactionStateManagerConfig, and QuorumConfig out of KafkaConfig

2025-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19121: -- Summary: Move AddPartitionsToTxnConfig, TransactionStateManagerConfig, and QuorumConfig out of KafkaConfig Key: KAFKA-19121 URL: https://issues.apache.org/jira/browse/KAFKA-19

Re: [PR] KAFKA-15371: MetadataShell is stuck when bootstrapping [kafka]

2025-04-09 Thread via GitHub
Yunyung commented on code in PR #19419: URL: https://github.com/apache/kafka/pull/19419#discussion_r2036424966 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -96,12 +96,16 @@ private void handleNextBatch() { return;

Re: [PR] [WIP] KAFKA-19068: Eliminate the duplicate type check in creating ControlRecord [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #19346: URL: https://github.com/apache/kafka/pull/19346#issuecomment-2791447082 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-2791469443 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18167 - Disable TLS session ticket extension [kafka]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #18070: URL: https://github.com/apache/kafka/pull/18070#issuecomment-2791469591 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Commented] (KAFKA-19123) the buffer of forwarded request should be released after receiving the reponse from controller

2025-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942372#comment-17942372 ] Chia-Ping Tsai commented on KAFKA-19123: Maybe we should release the buffer by `

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-09 Thread via GitHub
lucasbru commented on code in PR #19425: URL: https://github.com/apache/kafka/pull/19425#discussion_r2036636589 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java: ## @@ -140,6 +140,13 @@ public EmbeddedKafkaCluster(fi

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-09 Thread via GitHub
lucasbru commented on PR #19425: URL: https://github.com/apache/kafka/pull/19425#issuecomment-2791744850 @bbejeck Thanks for the review. Comment addressed, ready for rereview. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Created] (KAFKA-19123) the buffer of forwarded request should be released after receiving the reponse from controller

2025-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19123: -- Summary: the buffer of forwarded request should be released after receiving the reponse from controller Key: KAFKA-19123 URL: https://issues.apache.org/jira/browse/KAFKA-19123

Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-04-09 Thread via GitHub
leaf-soba commented on code in PR #18816: URL: https://github.com/apache/kafka/pull/18816#discussion_r2036375532 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -111,29 +190,38 @@ public void after() { }

Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-04-09 Thread via GitHub
leaf-soba commented on code in PR #18816: URL: https://github.com/apache/kafka/pull/18816#discussion_r2036379689 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -89,8 +95,81 @@ public class ChangeLoggingKeyValueBy

[PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-09 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19431: URL: https://github.com/apache/kafka/pull/19431 Currently, in the deleteShareGroupOffsets method in GroupCoordinatorService, the user request was simply forwarded to the persister without checking if the requested share partitions were initi

[jira] [Updated] (KAFKA-19117) Client Throttling Log messages should be of log level - WARN (Java client)

2025-04-09 Thread Ravi Kalasapur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Kalasapur updated KAFKA-19117: --- Summary: Client Throttling Log messages should be of log level - WARN (Java client) (was: C

[jira] [Created] (KAFKA-19120) Consider whether we could subscribe using topic ids instead of names

2025-04-09 Thread David Jacot (Jira)
David Jacot created KAFKA-19120: --- Summary: Consider whether we could subscribe using topic ids instead of names Key: KAFKA-19120 URL: https://issues.apache.org/jira/browse/KAFKA-19120 Project: Kafka

[jira] [Created] (KAFKA-19119) Move ApiVersionManager/SimpleApiVersionManager

2025-04-09 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19119: -- Summary: Move ApiVersionManager/SimpleApiVersionManager Key: KAFKA-19119 URL: https://issues.apache.org/jira/browse/KAFKA-19119 Project: Kafka Issue Type

[jira] [Assigned] (KAFKA-19103) Remove OffsetConfig

2025-04-09 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bolin Lin reassigned KAFKA-19103: - Assignee: Bolin Lin (was: Chia-Ping Tsai) > Remove OffsetConfig > --- > >

Re: [PR] KAFKA-18287: Add support for kafka-streams-groups.sh --list [kafka]

2025-04-09 Thread via GitHub
cadonna commented on code in PR #19422: URL: https://github.com/apache/kafka/pull/19422#discussion_r2035283403 ## tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandUnitTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-09 Thread via GitHub
bbejeck commented on code in PR #19425: URL: https://github.com/apache/kafka/pull/19425#discussion_r2035488915 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java: ## @@ -140,6 +140,13 @@ public EmbeddedKafkaCluster(fin

[jira] [Commented] (KAFKA-19116) Deletion of share group offsets does not reset the position as expected

2025-04-09 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942211#comment-17942211 ] Sushant Mahajan commented on KAFKA-19116: - The issue occurs due to SharePartitio

Re: [PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-09 Thread via GitHub
AndrewJSchofield commented on PR #19363: URL: https://github.com/apache/kafka/pull/19363#issuecomment-2789224695 This operation is also susceptible to https://issues.apache.org/jira/browse/KAFKA-19116. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] KAFKA-19113: Migrate DelegationTokenManager to server module [kafka]

2025-04-09 Thread via GitHub
FrankYang0529 opened a new pull request, #19424: URL: https://github.com/apache/kafka/pull/19424 1. Migrate DelegationTokenManager to server module. 2. Rewrite DelegationTokenManager in Java. 3. Move DelegationTokenManagerConfigs out of KafkaConfig. Jira: KAFKA-19113, KAFKA-15853

Re: [PR] KAFKA-18287: Add support for kafka-streams-groups.sh --list [kafka]

2025-04-09 Thread via GitHub
aliehsaeedii commented on code in PR #19422: URL: https://github.com/apache/kafka/pull/19422#discussion_r2035258165 ## tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandUnitTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-18287: Add support for kafka-streams-groups.sh --list [kafka]

2025-04-09 Thread via GitHub
aliehsaeedii commented on code in PR #19422: URL: https://github.com/apache/kafka/pull/19422#discussion_r2035257657 ## tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandUnitTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-09 Thread via GitHub
gongxuanzhang commented on PR #19319: URL: https://github.com/apache/kafka/pull/19319#issuecomment-2788850360 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-09 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2035179030 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -112,6 +115,27 @@ public void testBuildWithCurrentMessageFormat() { as

[jira] [Updated] (KAFKA-19115) Utilize initialized topics info to verify delete share group offsets

2025-04-09 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan updated KAFKA-19115: Summary: Utilize initialized topics info to verify delete share group offsets (was: Utili

[PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-09 Thread via GitHub
lucasbru opened a new pull request, #19425: URL: https://github.com/apache/kafka/pull/19425 KIP-1071 creates internal topics broker-side, so this test checks whether, when KIP-1071 is enabled, basically the same topics are created. It also adds a little helper method in `EmbeddedKafka

[jira] [Deleted] (KAFKA-14777) Add support of topic id for OffsetCommitRequests in CommitRequestManager

2025-04-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot deleted KAFKA-14777: > Add support of topic id for OffsetCommitRequests in CommitRequestManager >

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-09 Thread via GitHub
Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2035827481 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new S

Re: [PR] KAFKA-19119: Move ApiVersionManager/SimpleApiVersionManager to server [kafka]

2025-04-09 Thread via GitHub
mimaison commented on PR #19426: URL: https://github.com/apache/kafka/pull/19426#issuecomment-2789840026 The `ApiVersionManager` implementation used by brokers, `DefaultApiVersionManager`, can't be moved yet as it still depends on `kafka.server.ForwardingManager`. -- This is an automated

[jira] [Commented] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-04-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942106#comment-17942106 ] Luke Chen commented on KAFKA-14056: --- Changing the target version to 3.9.2. We can alwa

[jira] [Updated] (KAFKA-17996) kafka-metadata-quorum.sh add-controller cause the new added controller to crash with java.lang.IllegalArgumentException

2025-04-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-17996: -- Fix Version/s: (was: 3.9.1) > kafka-metadata-quorum.sh add-controller cause the new added controll

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-09 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2034641102 ## storage/src/main/java/org/apache/kafka/storage/internals/log/CleanedTransactionMetadata.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Updated] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-04-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14056: -- Fix Version/s: 3.9.2 (was: 3.9.1) > Test reading of old messages formats in ZK-

[jira] [Commented] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942112#comment-17942112 ] Bruno Cadonna commented on KAFKA-19110: --- [~yangpoan] Thanks for your interest! For

[jira] [Assigned] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-19110: - Assignee: Bruno Cadonna > Add missing unit test for Streams-consumer integration > ---

  1   2   >