aliehsaeedii commented on code in PR #19422: URL: https://github.com/apache/kafka/pull/19422#discussion_r2035257657
########## tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandUnitTest.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.streams; + +import org.apache.kafka.clients.admin.Admin; +import org.apache.kafka.clients.admin.GroupListing; +import org.apache.kafka.clients.admin.KafkaAdminClient; +import org.apache.kafka.clients.admin.ListGroupsOptions; +import org.apache.kafka.clients.admin.ListGroupsResult; +import org.apache.kafka.clients.admin.MockAdminClient; +import org.apache.kafka.common.GroupState; +import org.apache.kafka.common.GroupType; +import org.apache.kafka.common.KafkaFuture; +import org.apache.kafka.test.TestUtils; + +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +import joptsimple.OptionException; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class StreamsGroupCommandUnitTest { + + @Test + public void testListStreamsGroups() throws Exception { + String firstGroup = "first-group"; + String secondGroup = "second-group"; + String bootstrapServer = "localhost:9092"; + + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServer, "--list"}; + Admin adminClient = mock(KafkaAdminClient.class); + ListGroupsResult result = mock(ListGroupsResult.class); + when(result.all()).thenReturn(KafkaFuture.completedFuture(Arrays.asList( + new GroupListing(firstGroup, Optional.of(GroupType.STREAMS), "streams", Optional.of(GroupState.STABLE)), + new GroupListing(secondGroup, Optional.of(GroupType.STREAMS), "streams", Optional.of(GroupState.EMPTY)) + ))); + when(adminClient.listGroups(any(ListGroupsOptions.class))).thenReturn(result); + StreamsGroupCommand.StreamsGroupService service = getStreamsGroupService(cgcArgs, adminClient); + Set<String> expectedGroups = new HashSet<>(Arrays.asList(firstGroup, secondGroup)); + + final Set[] foundGroups = new Set[]{Collections.emptySet()}; Review Comment: The same thing was done here: https://github.com/apache/kafka/blob/2a370ed7213c7de74acef8b66955c4b91ba791e2/tools/src/test/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandTest.java#L121 in order to maintain thread safety maybe. The final Variable enables us to effectively mutate the content of this array within the lambda, despite the fact that the array reference itself remains constant/final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
