leaf-soba commented on code in PR #18816:
URL: https://github.com/apache/kafka/pull/18816#discussion_r2036375532
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##########
@@ -111,29 +190,38 @@ public void after() {
}
@Test
- public void shouldDelegateInit() {
- final InternalMockProcessorContext context = mockContext();
- final KeyValueStore<Bytes, byte[]> innerMock =
mock(InMemoryKeyValueStore.class);
+ void shouldDelegateInit() {
Review Comment:
In JUnit 5, test classes and methods can have default (package-private)
visibility—they don’t need to be public to be recognized and executed. However,
I noticed that most of the existing Kafka unit tests still use public, so I’ll
follow the current convention and revert the change for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
