Re: [PR] KAFKA-18845: Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled [kafka]

2025-04-05 Thread via GitHub
mumrah commented on code in PR #19240: URL: https://github.com/apache/kafka/pull/19240#discussion_r2004033069 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -376,10 +375,12 @@ public void testElrEnabledByDefault() throws Throwable {

[jira] [Commented] (KAFKA-15580) KIP-966: Unclean Recovery

2025-04-05 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940127#comment-17940127 ] Jonah Hooper commented on KAFKA-15580: -- This is being actively worked on; the actua

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-05 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025864206 ## streams/src/main/java/org/apache/kafka/streams/kstream/EmitStrategy.java: ## @@ -29,6 +29,7 @@ /** * This interface controls the strategy that can be used to cont

[jira] [Commented] (KAFKA-12715) ACL authentication, Host field support IP network segment

2025-04-05 Thread Jaideep Cuttamanchi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939866#comment-17939866 ] Jaideep Cuttamanchi commented on KAFKA-12715: - Hi I can contribute to this f

[jira] [Updated] (KAFKA-19061) Add ACL changes to enable role based 2PC

2025-04-05 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19061: - Description: *transaction.max.timeout.ms* guarantees that an ongoing transaction is aborted wit

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19251: URL: https://github.com/apache/kafka/pull/19251#discussion_r2006087036 ## core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala: ## @@ -36,17 +36,7 @@ class HeartbeatRequestTest(cluster: ClusterInstance) extends GroupCoordinat

[jira] [Resolved] (KAFKA-19055) Cleanup the 0.10.x information from clients module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19055. Fix Version/s: 4.1.0 Resolution: Fixed > Cleanup the 0.10.x information from client

[jira] [Created] (KAFKA-19056) Move EndToEndClusterIdTest to server module

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19056: -- Summary: Move EndToEndClusterIdTest to server module Key: KAFKA-19056 URL: https://issues.apache.org/jira/browse/KAFKA-19056 Project: Kafka Issue Type: I

[jira] [Updated] (KAFKA-19003) Add force-terminate command to kafka-transactions CLI

2025-04-05 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19003: - Description: The {{kafka-transactions.sh}} tool is going to support a new command forceTerminate

Re: [PR] KAFKA-18329; [1/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac merged PR #19243: URL: https://github.com/apache/kafka/pull/19243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2025-04-05 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937171#comment-17937171 ] Jun Rao commented on KAFKA-15931: - Merged [https://github.com/apache/kafka/pull/19197] t

[jira] [Commented] (KAFKA-19051) Fix implicit acknowledgement cannot be overridden when RecordDeserializationException occurs

2025-04-05 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939719#comment-17939719 ] Andrew Schofield commented on KAFKA-19051: -- Hmm. This is a pretty small corner

Re: [PR] KAFKA-19032: Remove TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19270: URL: https://github.com/apache/kafka/pull/19270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19070) Adding task number to the user provided client id (via consumer.override.client.id) to ensure each consumer has a unique client ID to avoid metric registration conflict

2025-04-05 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-19070: -- Assignee: Lorcan > Adding task number to the user provided client id (via > consumer.override.client

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026273027 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029819976 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java: ## @@ -316,6 +367,21 @@ public void inner

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029817657 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java: ## @@ -143,28 +143,25 @@ private void leftJoi

[jira] [Resolved] (KAFKA-19074) Remove the cached responseData from ShareFetchResponse

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19074. Fix Version/s: 4.1.0 Resolution: Fixed > Remove the cached responseData from ShareF

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r2029852092 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -795,6 +796,12 @@ protected static

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-04-05 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2780684838 @dajac can we please review this and also let me know if this requires any KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19042: [2/N] Move TransactionsExpirationTest to client-integration-tests module [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19288: URL: https://github.com/apache/kafka/pull/19288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-05 Thread via GitHub
Rancho-7 commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2029898652 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity o

[PR] MINOR: Various Java cleanups in core [kafka]

2025-04-05 Thread via GitHub
mimaison opened a new pull request, #19385: URL: https://github.com/apache/kafka/pull/19385 A bunch of Java 17 cleanups -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941260#comment-17941260 ] Mickael Maison commented on KAFKA-14485: Taking a quick look, it seems you could

Re: [PR] MINOR: Various Java cleanups in core [kafka]

2025-04-05 Thread via GitHub
m1a2st commented on PR #19385: URL: https://github.com/apache/kafka/pull/19385#issuecomment-2780886679 Thanks for this patch, I think this is dulpicate with https://github.com/apache/kafka/pull/19372 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-05 Thread via GitHub
fhussonnois commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2780914918 Hey @mjsax, sorry for the delay. I've rewritten the `MockConsumer#poll` method into something straightforward. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
mjsax commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029913190 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java: ## @@ -143,28 +143,25 @@ private void leftJoinI

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
ijuma commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2780917690 I don't understand what we are trying to achieve here. It would be good to agree on the goal first. Generally speaking, it's not a strict requirement to remove a method if it's only used by

Re: [PR] KAFKA-19013 Reformat PR body to 72 characters [kafka]

2025-04-05 Thread via GitHub
mumrah merged PR #19242: URL: https://github.com/apache/kafka/pull/19242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-05 Thread via GitHub
TaiJuWu commented on code in PR #19383: URL: https://github.com/apache/kafka/pull/19383#discussion_r2029911586 ## server-common/src/main/java/org/apache/kafka/config/BrokerReconfigurable.java: ## @@ -27,13 +29,10 @@ * The reconfiguration process follows three steps: * *

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
mjsax commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029914078 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java: ## @@ -316,6 +367,21 @@ public void innerJo

[jira] [Created] (KAFKA-19079) KIP-890 Cleanups

2025-04-05 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-19079: -- Summary: KIP-890 Cleanups Key: KAFKA-19079 URL: https://issues.apache.org/jira/browse/KAFKA-19079 Project: Kafka Issue Type: Improvement Repo

Re: [PR] KAFKA-18953: [1/N] Add broker side handling for 2 PC (KIP-939) [kafka]

2025-04-05 Thread via GitHub
jolshan commented on code in PR #19193: URL: https://github.com/apache/kafka/pull/19193#discussion_r1999826233 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -967,12 +1023,16 @@ class TransactionCoordinatorTest { validateR

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2772173039 @DL1231 Thanks for the PR. Please can you resolve the conflicts. Also, I tried the branch out on my local environment and was successfully able to create more than `group.s

[jira] [Created] (KAFKA-19025) Reuse buffers for LZ4 compression

2025-04-05 Thread Sean Quah (Jira)
Sean Quah created KAFKA-19025: - Summary: Reuse buffers for LZ4 compression Key: KAFKA-19025 URL: https://issues.apache.org/jira/browse/KAFKA-19025 Project: Kafka Issue Type: Improvement

[PR] MINOR: rename streams group configs for consistency with other configuration settings. [kafka]

2025-04-05 Thread via GitHub
aliehsaeedii opened a new pull request, #19360: URL: https://github.com/apache/kafka/pull/19360 This is a minor fix for this PR: https://github.com/apache/kafka/pull/19176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Created] (KAFKA-19076) UnifiedLog#maybeHandleIOException should replace `String` by `Supplier`

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19076: -- Summary: UnifiedLog#maybeHandleIOException should replace `String` by `Supplier` Key: KAFKA-19076 URL: https://issues.apache.org/jira/browse/KAFKA-19076 Project:

[PR] MINOR: Improve error logging for task commit failures [kafka]

2025-04-05 Thread via GitHub
bbejeck opened a new pull request, #19326: URL: https://github.com/apache/kafka/pull/19326 Enhances the error messages logged during task commit failures by including the specific cause from the `TimeoutException`. This provides clearer context to debug issues related to timeout errors.

Re: [PR] KAFKA-14768_KIP913: add new method to provide possibility for warming up first record's sending and reducing the max.block.ms safely. [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #13320: URL: https://github.com/apache/kafka/pull/13320#issuecomment-2771264351 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r2029857497 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -795,6 +796,12 @@ protected static

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029880923 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java: ## @@ -211,6 +214,29 @@ public ConsumerMembershipManager m

[jira] [Updated] (KAFKA-19094) Add a mechanism to GroupMetadataManager for handling static members leaving groups

2025-04-05 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-19094: Labels: need-kip (was: ) > Add a mechanism to GroupMetadataManager for handling static members le

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029885686 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -469,8 +493,17 @@ public int joinGroupEpoch() { */

[jira] [Created] (KAFKA-19094) Add a mechanism to GroupMetadataManager for handling static members leaving groups

2025-04-05 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-19094: --- Summary: Add a mechanism to GroupMetadataManager for handling static members leaving groups Key: KAFKA-19094 URL: https://issues.apache.org/jira/browse/KAFKA-19094 Proj

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941248#comment-17941248 ] Chia-Ping Tsai commented on KAFKA-14485: [~javakillah] there is already a minor

Re: [PR] KAFKA-19064: Handle exceptions from deferred events in coordinator [kafka]

2025-04-05 Thread via GitHub
dajac commented on code in PR #19333: URL: https://github.com/apache/kafka/pull/19333#discussion_r2023181017 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java: ## @@ -649,42 +649,37 @@ public void testScheduleUnloadingWi

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-05 Thread via GitHub
FrankYang0529 commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2028317810 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Ap

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield commented on PR #19295: URL: https://github.com/apache/kafka/pull/19295#issuecomment-2769293324 Build failure due to excessively flaky test. Test disabled by https://github.com/apache/kafka/pull/19340. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-05 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2020722085 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -15294,221 +15314,2860 @@ public void testShareGroupStates()

[jira] [Assigned] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2025-04-05 Thread Kevin Apolinario (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Apolinario reassigned KAFKA-10357: Assignee: Kevin Apolinario (was: Bruno Cadonna) > Handle accidental deletion of

[jira] [Updated] (KAFKA-14895) Move AddPartitionsToTxnManager files to java

2025-04-05 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14895: --- Parent Issue: KAFKA-19079 (was: KAFKA-14402) > Move AddPartitionsToTxnManager files to java

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2021428929 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java: ## @@ -290,6 +309,10 @@ public static ShareGroupAutoOffsetResetStrategy

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-05 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2027393106 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java: ## @@ -69,10 +70,37 @@ public void testCustomQuotaCallba

Re: [PR] KAFKA-15599: Move MetadataLogConfig to raft module [kafka]

2025-04-05 Thread via GitHub
mimaison commented on code in PR #19246: URL: https://github.com/apache/kafka/pull/19246#discussion_r2006447637 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-04-05 Thread via GitHub
lorcanj commented on code in PR #19199: URL: https://github.com/apache/kafka/pull/19199#discussion_r2004905258 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -422,21 +423,17 @@ public synchronized Set updatePartitionLeadership(Map

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
apalan60 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2780865513 Hi @junrao , @ijuma , @FrankYang0529 Sorry for the late update. I’ve now updated the PR with the following adjustments: In the original version, FetchResponse had two ```#of``

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
apalan60 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2029901777 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -220,14 +220,6 @@ public static int recordsSize(FetchResponseData.PartitionData pa

Re: [PR] KAFKA-1194: changes needed to run on Windows [kafka]

2025-04-05 Thread via GitHub
MeloHenrique commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-2780869437 Does anyone know if the problem still persists with v4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix an incorrect assignment in StreamsUncaughtExceptionHandlerIntegrationTest [kafka]

2025-04-05 Thread via GitHub
mjsax commented on code in PR #18837: URL: https://github.com/apache/kafka/pull/18837#discussion_r2025469495 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java: ## @@ -192,7 +192,7 @@ private static

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941224#comment-17941224 ] Chia-Ping Tsai commented on KAFKA-14485:   {code:java} diff --git a/core/src/ma

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029835345 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -469,8 +493,17 @@ public int joinGroupEpoch() { */

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029835345 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -469,8 +493,17 @@ public int joinGroupEpoch() { */

[PR] KAFKA-19070: add taskId to consumer override clientId [kafka]

2025-04-05 Thread via GitHub
lorcanj opened a new pull request, #19382: URL: https://github.com/apache/kafka/pull/19382 Addresses: [KAFKA-19070](https://issues.apache.org/jira/browse/KAFKA-19070) The default clientId for the connector consumer is 'connector-consumer-' plus the task id value. When a user overrides

Re: [PR] KAFKA-19070: add taskId to consumer override clientId [kafka]

2025-04-05 Thread via GitHub
lorcanj commented on PR #19382: URL: https://github.com/apache/kafka/pull/19382#issuecomment-2780662680 I think this may require a KIP as this would potentially break some client code if people try to do matching on the overridden client id which would no longer match as the string would be

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029841125 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -469,8 +493,17 @@ public int joinGroupEpoch() { */

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-05 Thread via GitHub
Rancho-7 commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2029898652 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity o

Re: [PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19357: URL: https://github.com/apache/kafka/pull/19357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19374: URL: https://github.com/apache/kafka/pull/19374#issuecomment-2780689476 > could we also remove DataPlaneAcceptor#ThreadPrefix and DataPlaneAcceptor#MetricPrefix, because the only implementation of Acceptor is DataPlaneAcceptor? `DataPlaneAcceptor#Metr

[PR] MINOR: Add doc for configuration parameters to keep the format consistent [kafka]

2025-04-05 Thread via GitHub
yx9o opened a new pull request, #19244: URL: https://github.com/apache/kafka/pull/19244 Add doc for configuration parameters to keep the format consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r2029852092 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -795,6 +796,12 @@ protected static

[PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-05 Thread via GitHub
frankvicky opened a new pull request, #19383: URL: https://github.com/apache/kafka/pull/19383 This patch moves `BrokerReconfigurable` to the `server-common module` and decouples the `TransactionLogConfig` and `KafkaConfig` to unblock KAFKA-14485. -- This is an automated message from the A

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2029852866 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new Simpl

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029817657 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java: ## @@ -143,28 +143,25 @@ private void leftJoi

[jira] [Assigned] (KAFKA-19095) enhance the docs of incrementalAlterConfigs to remind that controller only apply the cluster-level dynamic configurations

2025-04-05 Thread Cheng Yi Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Yi Chang reassigned KAFKA-19095: -- Assignee: Cheng Yi Chang (was: Chia-Ping Tsai) > enhance the docs of incrementalAlte

Re: [PR] MINOR: Revert "migrate LogFetchInfo, Assignment and RequestAndCompletionHandler to java record" [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19177: URL: https://github.com/apache/kafka/pull/19177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-05 Thread via GitHub
m1a2st commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2029892934 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity of

Re: [PR] MINOR: rename metric variable name in Processor#accept [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19361: URL: https://github.com/apache/kafka/pull/19361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-05 Thread via GitHub
Rancho-7 opened a new pull request, #19384: URL: https://github.com/apache/kafka/pull/19384 jira: https://issues.apache.org/jira/browse/KAFKA-19093 > INFO [data-plane Kafka Request Handler on Broker 3000], Resizing request handler thread pool size from 8 to 10 (kafka.server.KafkaReque

[jira] [Created] (KAFKA-19095) enhance the docs of incrementalAlterConfigs to remind that controller only apply the cluster-level dynamic configurations

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19095: -- Summary: enhance the docs of incrementalAlterConfigs to remind that controller only apply the cluster-level dynamic configurations Key: KAFKA-19095 URL: https://issues.apache.

[jira] [Commented] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-04-05 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941253#comment-17941253 ] Jhen-Yung Hsu commented on KAFKA-19042: --- Nit: client-integration-tests -> clients-

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-05 Thread via GitHub
gongxuanzhang commented on PR #19319: URL: https://github.com/apache/kafka/pull/19319#issuecomment-2780814259 @FrankYang0529 Thanks for your nice review, I updated this PR. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2029894525 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -220,14 +220,6 @@ public static int recordsSize(FetchResponseData.PartitionData pa

[PR] MINOR: FindCoordinator API does not lookup partition for share partition key correctly [kafka]

2025-04-05 Thread via GitHub
dajac opened a new pull request, #19273: URL: https://github.com/apache/kafka/pull/19273 This patch fixes another bug in the FindCoordinator API handling for share partition key. `shareCoordinator.foreach` returns `Unit` so `shareCoordinator.foreach(coordinator => coordinator.partitionFor(

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2020587635 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1282,8 +1281,31 @@ class ReplicaManager(val config: KafkaConfig, } if (delayedDeleteRecord

Re: [PR] MINOR: Remove unused `ApiKeys.minRequiredInterBrokerMagic` [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19325: URL: https://github.com/apache/kafka/pull/19325#discussion_r2021372461 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -67,11 +66,11 @@ public enum ApiKeys { DELETE_RECORDS(ApiMessageType.DELETE_RECORDS)

Re: [PR] MINOR: Cleanup test-common-runtime module [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19305: URL: https://github.com/apache/kafka/pull/19305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-05 Thread via GitHub
ijuma commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2009192580 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -286,4 +291,12 @@ private static FetchResponseData toMessage(Errors error,

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-05 Thread via GitHub
TaiJuWu commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2028375807 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -103,6 +105,9 @@ public void onMetadataUpdate(MetadataDelta delta, MetadataImage

[jira] [Created] (KAFKA-19074) Remove the cached responseData from ShareFetchResponse

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19074: -- Summary: Remove the cached responseData from ShareFetchResponse Key: KAFKA-19074 URL: https://issues.apache.org/jira/browse/KAFKA-19074 Project: Kafka Is

[jira] [Assigned] (KAFKA-19004) Move DelayedDeleteRecords to server-common module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19004: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Move DelayedDeleteRecords to server

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026267169 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1246,7 +1259,9 @@ private boolean archiveAvailableRecords(long startOffset, long endOffset

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac merged PR #19251: URL: https://github.com/apache/kafka/pull/19251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] [WIP] JWT bearer grant type support [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #18912: URL: https://github.com/apache/kafka/pull/18912#issuecomment-2764362509 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17218: kafka-consumer-groups should handle describe groups with deleted topics [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #19029: URL: https://github.com/apache/kafka/pull/19029#issuecomment-2764362494 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752082932 > The fixed version for [KAFKA-18723](https://issues.apache.org/jira/browse/KAFKA-18723) already includes 3.9.1 and 4.0.1? I grep the git history , and KAFKA-18723 is not in 4.0/3

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-04-05 Thread via GitHub
kirktrue commented on PR #19199: URL: https://github.com/apache/kafka/pull/19199#issuecomment-2767702063 @lorcanj—Looking at the [test history of `CooperativeConsumerCoordinatorTest.testOutdatedCoordinatorAssignment()`](https://develocity.apache.org/scans/tests?search.relativeStartTime=P28D&

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-04-05 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2765563652 > > but we're facing an issue—PlainSaslServer can only pass the authorizationID to the authorizer, meaning the client info is lost. > > Have you considered implementing a custom

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2772915350 @DL1231 Of course, the reason is that the limit is being applied per group coordinator shard. Hmmm. This is not so straightforward. -- This is an automated message from the Apa

Re: [PR] MINOR: Optimize the 'waitForVerifyAssignment' method log output [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #17753: URL: https://github.com/apache/kafka/pull/17753#issuecomment-2739046191 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Created] (KAFKA-19021) Broker should not be allowed to be promoted to controller

2025-04-05 Thread Jira
José Armando García Sancio created KAFKA-19021: -- Summary: Broker should not be allowed to be promoted to controller Key: KAFKA-19021 URL: https://issues.apache.org/jira/browse/KAFKA-19021

<    1   2   3   >