Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

ableegoldman commented on PR #17614: URL: https://github.com/apache/kafka/pull/17614#issuecomment-2781223772 Merged to trunk (🥳 ) -- do you want to start working on the followup PR now to utilize this new API for `KafkaStreams#close`? This will also let us clean up the `internal.leave.group

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

frankvicky commented on PR #17614: URL: https://github.com/apache/kafka/pull/17614#issuecomment-2781237676 Hi @ableegoldman A huge thanks for your patience and review! 🙇🏼 > do you want to start working on the followup PR now to utilize this new API for KafkaStreams#close? Yes, I

Re: [PR] MINOR:modify scala $var to java string [kafka]

showuon commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2030056754 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybeH

[PR] MINOR: Cleanup 0.10.x legacy references in ClusterResourceListener and TopicConfig (clients module) [kafka]

LoganZhuZzz opened a new pull request, #19388: URL: https://github.com/apache/kafka/pull/19388 This PR is a minor follow-up to [PR #19320](https://github.com/apache/kafka/pull/19320), which cleaned up 0.10.x legacy information from the clients module. It addresses remaining reviewer

Re: [PR] [MINOR] Cleanup Core Module- Scala Modules [kafka]

sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2781209728 OffloadAndTxnConsumeFromLeaderTest -> Seems to be a flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

mjsax commented on PR #19303: URL: https://github.com/apache/kafka/pull/19303#issuecomment-2781214593 Thanks for the patch! Merged to `trunk`, and cherry-picked to `4.0` and `3.9` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

ableegoldman merged PR #17614: URL: https://github.com/apache/kafka/pull/17614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-19018,KAFKA-19063: Implement maxRecords and acquisition lock timeout in share fetch request and response resp. [kafka]

apoorvmittal10 commented on code in PR #19334: URL: https://github.com/apache/kafka/pull/19334#discussion_r2022389354 ## clients/src/main/resources/common/message/ShareFetchResponse.json: ## @@ -39,6 +39,8 @@ "about": "The top-level response error code." }, { "name":

[jira] [Resolved] (KAFKA-18667) Add ducktape tests for simultaneous broker + controller failure

[ https://issues.apache.org/jira/browse/KAFKA-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu resolved KAFKA-18667. -- Resolution: Fixed > Add ducktape tests for simultaneous broker + controller failure >

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2022174511 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -1234,26 +1087,20 @@ public void testRetryAcknowledg

Re: [PR] KAFKA-18736: Add pollOnClose() and maximumTimeToWait() [kafka]

cadonna merged PR #19233: URL: https://github.com/apache/kafka/pull/19233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-15655) Consider making transactional apis more compatible with topic IDs

[ https://issues.apache.org/jira/browse/KAFKA-15655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-15655: --- Parent Issue: KAFKA-19079 (was: KAFKA-14402) > Consider making transactional apis more comp

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

cadonna commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2024268591 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -616,7 +598,7 @@ public void flushCache() { public void clo

[jira] [Commented] (KAFKA-19007) Issues running the apache/kafka docker container on M4 Macs with OS >= 15.2

[ https://issues.apache.org/jira/browse/KAFKA-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936504#comment-17936504 ] Christofer Dutz commented on KAFKA-19007: - Some additional Links to the issue: [

[PR] KAFKA-17806: remove this-escape suppress warnings in AclCommand [kafka]

FrankYang0529 opened a new pull request, #19256: URL: https://github.com/apache/kafka/pull/19256 Change AclCommandOptions to final class, so we can remove `@SuppressWarnings("this-escape")` on it. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Created] (KAFKA-19068) Eliminate the duplicate type check in creating ControlRecord

Chia-Ping Tsai created KAFKA-19068: -- Summary: Eliminate the duplicate type check in creating ControlRecord Key: KAFKA-19068 URL: https://issues.apache.org/jira/browse/KAFKA-19068 Project: Kafka

Re: [PR] MINOR: Mark streams RPCs as unstable [kafka]

lucasbru commented on PR #19292: URL: https://github.com/apache/kafka/pull/19292#issuecomment-2754724705 @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

janchilling commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2021686307 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -801,13 +786,13 @@ void maybeGetClientInstanceIds() {

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006278691 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

[PR] [DO NOT MERGE] Find Producer test thread leak [kafka]

m1a2st opened a new pull request, #19381: URL: https://github.com/apache/kafka/pull/19381 FYI: https://github.com/apache/kafka/actions/runs/14277595321/job/40023202087?pr=18930 https://github.com/apache/kafka/actions/runs/14145654402/job/39632853567?pr=18930 -- This is an automa

[jira] [Assigned] (KAFKA-18563) move RaftClientTestContext xyzRpcVersion methods into RaftProtocol

[ https://issues.apache.org/jira/browse/KAFKA-18563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18563: - Assignee: PoAn Yang > move RaftClientTestContext xyzRpcVersion methods into RaftProtocol > ---

[jira] [Updated] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19026: -- Attachment: (was: KAFKA19026Test-1.java) > AlterConfigPolicy incompatibility between ZK mo

[jira] [Created] (KAFKA-19058) Running the streams/streams-scala module tests produces a streams-scala.log

黃竣陽 created KAFKA-19058: --- Summary: Running the streams/streams-scala module tests produces a streams-scala.log Key: KAFKA-19058 URL: https://issues.apache.org/jira/browse/KAFKA-19058 Project: Kafka Is

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

chia7712 commented on PR #19259: URL: https://github.com/apache/kafka/pull/19259#issuecomment-2742476082 This is a kind of big fix, so please add a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19042: [2/N] Move TransactionsExpirationTest to client-integration-tests module [kafka]

chia7712 commented on code in PR #19288: URL: https://github.com/apache/kafka/pull/19288#discussion_r2021404113 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/TransactionsExpirationTest.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Softwa

[jira] [Updated] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranganath Samudrala updated KAFKA-19022: Description: While migrating Kafka from zookeeper to kraft, we see errors in logs

[jira] [Commented] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936260#comment-17936260 ] Dmitry Werner commented on KAFKA-19002: --- [~chia7712] Can I take it on? > Rewrite

Re: [PR] KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… [kafka]

janchilling closed pull request #19208: KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… URL: https://github.com/apache/kafka/pull/19208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-14542) Deprecate OffsetFetch/Commit version 0 and remove them in 4.0

[ https://issues.apache.org/jira/browse/KAFKA-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14542. - Resolution: Duplicate Addressed by https://issues.apache.org/jira/browse/KAFKA-14560. > Depreca

Re: [PR] KAFKA-18981: Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr [kafka]

FrankYang0529 commented on PR #19262: URL: https://github.com/apache/kafka/pull/19262#issuecomment-2743335132 @mumrah The QuorumControllerTest#testMinIsrUpdateWithElr is flaky but doesn't have `@Flaky` tag. For this case, do we want to add the tag to it? Thanks. -- This is an automated m

[PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton [kafka]

gongxuanzhang opened a new pull request, #19356: URL: https://github.com/apache/kafka/pull/19356 class `VoidEvent` provides singleton object , but nobody use it. I think we should private `VoidEvent` constructor and only use singleton -- This is an automated message from the Apache Git

Re: [PR] KAFKA-12744: dependency upgrade: `argparse4j` 0.7.0 -->> 0.9.0 [kafka]

mimaison commented on PR #19265: URL: https://github.com/apache/kafka/pull/19265#issuecomment-2761152756 Both options are valid, but ideally we'd want to refactor the current logic to not use the deprecated APIs. At a glance this does not seem too complicated. As mentioned in https:/

[jira] [Created] (KAFKA-19082) Client side changes to enable 2PC

Ritika Reddy created KAFKA-19082: Summary: Client side changes to enable 2PC Key: KAFKA-19082 URL: https://issues.apache.org/jira/browse/KAFKA-19082 Project: Kafka Issue Type: Sub-task

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011385275 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton and use more proper function interface [kafka]

gongxuanzhang commented on PR #19356: URL: https://github.com/apache/kafka/pull/19356#issuecomment-2775186778 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Mar 18 test 2 [kafka-merge-queue-sandbox]

mumrah opened a new pull request, #64: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/64 Another test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2740992633 I fixed the tests, ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-18923: resource leak in RSM fetchIndex inputStream [kafka]

FrankYang0529 commented on PR #19111: URL: https://github.com/apache/kafka/pull/19111#issuecomment-2769816571 Hi @showuon, thanks for the suggestion. Following are all references about `fetchLogSegment` and `fetchIndex`. * InputStream fetchLogSegment(RemoteLogSegmentMetadata remoteLo

[jira] [Assigned] (KAFKA-19019) Verify Share Fetch with Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-19019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-19019: - Assignee: Abhinav Dixit (was: Apoorv Mittal) > Verify Share Fetch with Tiered Storage

[jira] [Assigned] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-19022: -- Assignee: (was: Lorcan) > Display cluster IDs being compared when encountering INCONSISTENT_CLUST

Re: [PR] MINOR:modify scala $var to java string [kafka]

chia7712 commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2029925512 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybe

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940334#comment-17940334 ] Kevin Apolinario commented on KAFKA-10357: -- Picking this one up to finish whats

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

mjsax commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r2026210742 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -644,16 +645,16 @@ public void shou

[jira] [Created] (KAFKA-19078) Implement automatic controller addition to cluster metadata partition

José Armando García Sancio created KAFKA-19078: -- Summary: Implement automatic controller addition to cluster metadata partition Key: KAFKA-19078 URL: https://issues.apache.org/jira/browse/KAFKA-19078

Re: [PR] KAFKA-16260: Deprecate window.size.ms and window.inner.class.serde in StreamsConfig [kafka]

lucasbru commented on code in PR #18297: URL: https://github.com/apache/kafka/pull/18297#discussion_r2010879588 ## streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindowedDeserializer.java: ## @@ -23,10 +23,20 @@ import org.apache.kafka.streams.StreamsConfig; imp

[PR] MINOR: remove unused function BrokerRegistration#isMigratingZkBroker [kafka]

FrankYang0529 opened a new pull request, #19330: URL: https://github.com/apache/kafka/pull/19330 The `BrokerRegistration#isMigratingZkBroker` is not used by any production function. Remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

bbejeck commented on PR #18953: URL: https://github.com/apache/kafka/pull/18953#issuecomment-2772541530 Merged #18953 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (KAFKA-18874) KRaft controller does not retry registration if the first attempt times out

[ https://issues.apache.org/jira/browse/KAFKA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Fonai updated KAFKA-18874: - Attachment: controller-3.log controller-4.log controller-5.log >

Re: [PR] KAFKA-17554: Flaky testFutureCompletionOutsidePoll in ConsumerNetworkClientTest [kafka]

github-actions[bot] commented on PR #18298: URL: https://github.com/apache/kafka/pull/18298#issuecomment-2746781466 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Updated] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19026: -- Attachment: (was: KAFKA19026Test.java) > AlterConfigPolicy incompatibility between ZK mode

[PR] MINOR: Deduplicate topics of a topology for authorization check [kafka]

cadonna opened a new pull request, #19352: URL: https://github.com/apache/kafka/pull/19352 With the new Streams rebalance protocol, the Streams client sends the topology with the used topics to the broker for initialization. For the initialization the broker needs to describe the topics in

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

lorcanj commented on code in PR #19199: URL: https://github.com/apache/kafka/pull/19199#discussion_r2004919701 ## clients/src/main/java/org/apache/kafka/clients/MetadataSnapshot.java: ## @@ -173,12 +173,15 @@ MetadataSnapshot mergeWith(String newClusterId, Map newMeta

[jira] [Assigned] (KAFKA-14579) Move DumpLogSegments to tools

[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-14579: --- Assignee: TaiJuWu (was: Alexandre Dupriez) > Move DumpLogSegments to tools > -

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

mjsax commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025461183 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordBatchingStateRestoreCallback.java: ## @@ -22,6 +22,7 @@ import java.util.Collection; +@Fu

[PR] KAFKA-19018,KAFKA-19063: Implement maxRecords and acquisition lock timeout in share fetch request and response resp. [kafka]

apoorvmittal10 opened a new pull request, #19334: URL: https://github.com/apache/kafka/pull/19334 PR add `MaxRecords` to share fetch request and also adds `AcquisitionLockTimeout` to share fetch response. PR also removes internal broker config of `max.fetch.records`. -- This is an automa

[jira] [Updated] (KAFKA-19017) Change consumer-config to command-config in verifiable_share_consumer.py

[ https://issues.apache.org/jira/browse/KAFKA-19017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-19017: - Fix Version/s: 4.1.0 > Change consumer-config to command-config in verifiable_share_cons

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

mjsax commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2774410196 @nilmadhab -- I think we can close this PR in favor of the new PR you opened? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

TaiJuWu commented on code in PR #19357: URL: https://github.com/apache/kafka/pull/19357#discussion_r2028466184 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java: ## @@ -66,6 +79,19 @@ public void testErrorInAllPartitions() { assertTrue(shar

[jira] [Commented] (KAFKA-19076) UnifiedLog#maybeHandleIOException should replace `String` by `Supplier`

[ https://issues.apache.org/jira/browse/KAFKA-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940362#comment-17940362 ] Nick Guo commented on KAFKA-19076: -- Hi [~chia7712] ,I’d like to try this out.Thanks! >

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

AndrewJSchofield commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2027266957 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsSpec.java: ## @@ -47,9 +46,10 @@ public ListShareGroupOffsetsSpec topicPartitions

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025675202 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordBatchingStateRestoreCallback.java: ## @@ -22,6 +22,7 @@ import java.util.Collection; +@

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2742924375 @junrao @frankvicky Thanks for the comments, I've addresed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-19068) Eliminate the duplicate type check in creating ControlRecord

[ https://issues.apache.org/jira/browse/KAFKA-19068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940093#comment-17940093 ] Nick Guo commented on KAFKA-19068: -- Hi [~chia7712] ,I would like to handle this.Thanks!

[jira] [Resolved] (KAFKA-18827) Initialize share group state impl

[ https://issues.apache.org/jira/browse/KAFKA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan resolved KAFKA-18827. - Resolution: Fixed > Initialize share group state impl >

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024607201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1365,6 +1368,67 @@ public CompletableFuture describeShareGroup

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

chia7712 commented on code in PR #18795: URL: https://github.com/apache/kafka/pull/18795#discussion_r2004284732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -432,7 +439,14 @@ protected Map prepareFetchRequests()

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

chia7712 commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2742992871 @sjhajharia could you please rebase code? there is a build error if I apply this PR on the trunk. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Trying again [kafka-merge-queue-sandbox]

mumrah merged PR #68: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Resolved] (KAFKA-17431) KRaft servers require valid static socketserver configuration to start

[ https://issues.apache.org/jira/browse/KAFKA-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu resolved KAFKA-17431. -- Fix Version/s: 4.1.0 Resolution: Fixed > KRaft servers require valid static socketserver config

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

showuon commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2026363709 ## docs/ops.html: ## @@ -4009,7 +4009,7 @@ In order to migrate from ZooKeeper to KRaft you need to use a bridge release. The last bridge release is Kafka 3.9. See

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

mimaison commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2013965436 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

m1a2st commented on code in PR #19259: URL: https://github.com/apache/kafka/pull/19259#discussion_r2007871072 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -114,6 +114,15 @@ public void testOriginalsWithPrefix() { assertEquals(ex

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

nilmadhab commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2774464449 Yes, sure Regards, N. Mondal +31687153557 Amsterdam, Netherlands On Thu, 3 Apr 2025 at 05:49, Matthias J. Sax ***@***.***> wrote: > @nilmadhab

Re: [PR] Minor: Add functionalinterface to the producer callback [kafka]

Tombert commented on code in PR #19366: URL: https://github.com/apache/kafka/pull/19366#discussion_r2027542000 ## clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java: ## @@ -34,6 +34,7 @@ * The callback may be executed in any thread calli

Re: [PR] Another change but this time with a long title. What happens if the title is over 72 characters? I guess we'll find out. [kafka-merge-queue-sandbox]

mumrah merged PR #66: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Updated] (KAFKA-19012) Messages ending up on the wrong topic

[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19012: -- Component/s: clients producer > Messages ending up on the wrong topic >

[PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

jeqo opened a new pull request, #19331: URL: https://github.com/apache/kafka/pull/19331 Backports f24945b519005c0bc7a28db2db7aae6cec158927 to 4.0 Instead of reopening the transaction index, it cancels the RemoteFetchTask without interrupting it--avoiding to close the TransactionIndex

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

smjn commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2028490277 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -971,9 +971,11 @@ private void handlePartitionError(ShareAckno

[jira] [Comment Edited] (KAFKA-17354) StreamThread::setState race condition causes java.lang.RuntimeException: State mismatch PENDING_SHUTDOWN different from STARTING

[ https://issues.apache.org/jira/browse/KAFKA-17354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939350#comment-17939350 ] Ao Li edited comment on KAFKA-17354 at 3/28/25 11:41 PM: - We rec

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2007200264 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r200354 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

[jira] [Resolved] (KAFKA-19003) Add force-terminate feature to kafka-transactions CLI and Admin Client

[ https://issues.apache.org/jira/browse/KAFKA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy resolved KAFKA-19003. -- Resolution: Fixed > Add force-terminate feature to kafka-transactions CLI and Admin Client >

Re: [PR] MINOR VerifableProducer ducktape can set idempotency and retries [kafka]

josefk31 commented on PR #19362: URL: https://github.com/apache/kafka/pull/19362#issuecomment-2776483452 Testing: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (KAFKA-19030) Remove metricNamePrefix from RequestChannel

Chia-Ping Tsai created KAFKA-19030: -- Summary: Remove metricNamePrefix from RequestChannel Key: KAFKA-19030 URL: https://issues.apache.org/jira/browse/KAFKA-19030 Project: Kafka Issue Type: I

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2765640456 Hi @AndrewJSchofield, Sorry for the delay. I've been occupied with other tasks recently, but I will start to work on this issue as soon as possible. Much thanks for your help. --

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

fvaleri commented on code in PR #19198: URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309 ## docs/upgrade.html: ## @@ -72,10 +72,8 @@ Upgrading Servers to 4.0.0 from brokers will be running the latest version and you can verify that the cluster's

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

chia7712 commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2027507368 ## clients/src/main/java/org/apache/kafka/clients/consumer/OffsetCommitCallback.java: ## @@ -26,6 +26,7 @@ * A callback interface that the user can implement to trig

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024645145 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3533,19 +3539,74 @@ class KafkaApis(val requestChannel: RequestChannel, } } - private def describeSh

Re: [PR] KAFKA-18946: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module [kafka]

frankvicky commented on code in PR #19174: URL: https://github.com/apache/kafka/pull/19174#discussion_r2005054523 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -605,6 +616,9 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Loggin

[jira] [Commented] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937379#comment-17937379 ] Edoardo Comar commented on KAFKA-19026: --- Running the attached ClusterTest when in

Re: [PR] KAFKA-18959: increase the num_workers from 9 to 12 [kafka]

chia7712 merged PR #19274: URL: https://github.com/apache/kafka/pull/19274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

janchilling commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2021686307 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -801,13 +786,13 @@ void maybeGetClientInstanceIds() {

Re: [PR] MINOR:modify scala $var to java string [kafka]

ijuma commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2029928276 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybeHan

[PR] MINOR: Use readable interface to parse response [kafka]

soondenana opened a new pull request, #19353: URL: https://github.com/apache/kafka/pull/19353 This is the Response side of Request refactoring PR in commit: 56d1dc1b6e12a8a325c91749485aa03bce17c7f1 The generated ReequestData classes take Readable as input to parse the Response. Howe

[PR] Another small update [kafka-merge-queue-sandbox]

mumrah opened a new pull request, #65: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/65 Here is a PR with a long description. The following is one long line Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore ma

[jira] [Updated] (KAFKA-19003) Add force-terminate command to kafka-transactions CLI

[ https://issues.apache.org/jira/browse/KAFKA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19003: - Description: The {{kafka-transactions.sh}} tool is going to support a new command  {{{}--forceTe

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

github-actions[bot] commented on PR #18930: URL: https://github.com/apache/kafka/pull/18930#issuecomment-2739024832 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012357466 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1452,6 +1533,49 @@ private void throwIfShareGroupHeartbeatReque

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2007965891 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

[jira] [Assigned] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19080: -- Assignee: 黃竣陽 > The constraint on segment.ms is not enforced at topic level > ---

  1   2   3   >