janchilling commented on code in PR #19275:
URL: https://github.com/apache/kafka/pull/19275#discussion_r2021686307
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -801,13 +786,13 @@ void maybeGetClientInstanceIds() {
}
} else {
mainConsumerInstanceIdFuture.completeExceptionally(
- new TimeoutException("Could not retrieve main consumer
client instance id.")
+ new TimeoutException("Could not retrieve main
consumer client instance id.")
);
}
}
- if (!stateUpdaterEnabled &&
!restoreConsumerInstanceIdFuture.isDone()) {
+ if (!restoreConsumerInstanceIdFuture.isDone()) {
Review Comment:
Ah yeah makes sense, removed the entire condition and is updated in the
latest commit. There was another condition where part of it checked for the
same `!stateUpdaterEnabled && !restoreConsumerInstanceIdFuture.isDone()`
condition in the latter part of the same method. Remove that part of the check
since it will always be false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
