Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-20 Thread via GitHub
junrao commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2006193900 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] MINOR: add log4j2.yaml to clients-integration-tests module [kafka]

2025-03-20 Thread via GitHub
frankvicky commented on code in PR #19252: URL: https://github.com/apache/kafka/pull/19252#discussion_r2006833010 ## clients/clients-integration-tests/src/test/resources/log4j2.yaml: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

[PR] Trying again [kafka-merge-queue-sandbox]

2025-03-20 Thread via GitHub
mumrah opened a new pull request, #68: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/68 Another test with two trailers. Reviewers: David Arthur Signed-off-by: David Arthur -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Update readme [kafka-merge-queue-sandbox]

2025-03-20 Thread via GitHub
mumrah merged PR #67: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-20 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006103261 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3637,6 +3637,11 @@ QuorumState quorum() { return quorum; } +// Visible o

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-03-20 Thread via GitHub
lorcanj commented on code in PR #19199: URL: https://github.com/apache/kafka/pull/19199#discussion_r2006364925 ## clients/src/main/java/org/apache/kafka/clients/MetadataSnapshot.java: ## @@ -173,12 +173,15 @@ MetadataSnapshot mergeWith(String newClusterId, Map newMeta

Re: [PR] KAFKA-15599: Move MetadataLogConfig to raft module [kafka]

2025-03-20 Thread via GitHub
chia7712 commented on code in PR #19246: URL: https://github.com/apache/kafka/pull/19246#discussion_r2006213068 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-20 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006461608 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

[PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-20 Thread via GitHub
squah-confluent opened a new pull request, #19258: URL: https://github.com/apache/kafka/pull/19258 Some of these classes are generally useful for testing. MockCoordinatorShard is already shared by SnapshottableCoordinatorTest. -- This is an automated message from the Apache Git Serv

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-20 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006049419 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -645,39 +837,56 @@ private static class Cluster { final AtomicInteger correl

[jira] [Resolved] (KAFKA-10161) Update Documentation

2025-03-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10161. - Resolution: Won't Fix > Update Documentation > > > Key: KAF

[jira] [Commented] (KAFKA-18981) Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr

2025-03-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937174#comment-17937174 ] David Arthur commented on KAFKA-18981: -- Duplicate of KAFKA-18846 > Fix flaky Quoru

[jira] [Comment Edited] (KAFKA-18981) Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr

2025-03-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937174#comment-17937174 ] David Arthur edited comment on KAFKA-18981 at 3/20/25 5:26 PM: ---

[jira] [Commented] (KAFKA-18846) Flaky test QuorumControllerTest#testMinIsrUpdateWithElr

2025-03-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937175#comment-17937175 ] David Arthur commented on KAFKA-18846: -- See also KAFKA-18981 > Flaky test QuorumCo

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-03-20 Thread via GitHub
jeffkbkim commented on code in PR #19251: URL: https://github.com/apache/kafka/pull/19251#discussion_r2006041245 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -41,22 +41,12 @@ class OffsetCommitRequestTest(cluster: ClusterInstance) extends GroupC

Re: [PR] KAFKA-18845: Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled [kafka]

2025-03-20 Thread via GitHub
mumrah merged PR #19240: URL: https://github.com/apache/kafka/pull/19240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Comment Edited] (KAFKA-19012) Messages ending up on the wrong topic

2025-03-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937179#comment-17937179 ] David Arthur edited comment on KAFKA-19012 at 3/20/25 5:43 PM: ---

Re: [PR] MINOR; Improve error message for the storage format command [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19210: URL: https://github.com/apache/kafka/pull/19210#discussion_r2006162921 ## metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java: ## @@ -348,15 +348,22 @@ private short effectiveKRaftFeatureLevel(Optional configuredKRaftV

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-20 Thread via GitHub
chia7712 commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2006062890 ## server-common/src/main/java/org/apache/kafka/server/common/DeleteRecordsPartitionStatus.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-03-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937179#comment-17937179 ] David Arthur commented on KAFKA-19012: -- [~dnadolny] I know it's a long shot, but co

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-20 Thread via GitHub
Parkerhiphop commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r2006169550 ## tools/src/test/java/org/apache/kafka/tools/ClientMetricsCommandTest.java: ## @@ -156,6 +166,27 @@ public void testAlterGenerateName() { assertTrue(capt

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-20 Thread via GitHub
chia7712 commented on code in PR #19223: URL: https://github.com/apache/kafka/pull/19223#discussion_r2006206448 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -333,11 +333,14 @@ abstract class AbstractFetcherThread(name: String, responseData.fore

Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]

2025-03-20 Thread via GitHub
chia7712 commented on code in PR #19196: URL: https://github.com/apache/kafka/pull/19196#discussion_r2006272348 ## .github/workflows/merge-check.yml: ## @@ -0,0 +1,264 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. Se

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-20 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006278691 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

[PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-03-20 Thread via GitHub
TaiJuWu opened a new pull request, #19259: URL: https://github.com/apache/kafka/pull/19259 In past, we have `AbstractConfig#preProcessParsedConfig` but did not use its return value This PR fix such issue. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-03-20 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r2006937154 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -110,7 +110,7 @@ public class AbstractConfig { @SuppressWarnings({"this-escape"}

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-03-20 Thread via GitHub
jeqo commented on code in PR #19197: URL: https://github.com/apache/kafka/pull/19197#discussion_r2005443165 ## core/src/main/scala/kafka/server/DelayedRemoteFetch.scala: ## @@ -88,8 +90,9 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void], override def onExpiration()

Re: [PR] MINOR: Add 4.0.0 to core system tests [kafka]

2025-03-20 Thread via GitHub
dajac commented on PR #19238: URL: https://github.com/apache/kafka/pull/19238#issuecomment-2740375128 > Similar, should we include streams_broker_compatibility_test.py and streams_application_upgrade_test.py? They are handled separately: https://github.com/apache/kafka/pull/19239 --

Re: [PR] MINOR: Add 4.0.0 to core system tests [kafka]

2025-03-20 Thread via GitHub
lianetm commented on PR #19238: URL: https://github.com/apache/kafka/pull/19238#issuecomment-2740372841 Similar, should we include streams_broker_compatibility_test.py and streams_application_upgrade_test.py? -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-20 Thread Ranganath Samudrala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranganath Samudrala updated KAFKA-19022: Description: While migrating Kafka from zookeeper to kraft, we see errors in logs

[jira] [Updated] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16538: --- Priority: Blocker (was: Major) > Support UpdateFeatures for kraft.v

[jira] [Updated] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16538: --- Component/s: controller > Support UpdateFeatures for kraft.version s

[jira] [Updated] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16538: --- Fix Version/s: 4.1.0 > Support UpdateFeatures for kraft.version so w

[jira] [Commented] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937143#comment-17937143 ] José Armando García Sancio commented on KAFKA-16538: [~mimaison], ye

[jira] [Commented] (KAFKA-18797) Flaky testLargeAssignmentAndGroupWithUniformSubscription

2025-03-20 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937142#comment-17937142 ] PoAn Yang commented on KAFKA-18797: --- I found that testLargeAssignmentAndGroupWithUnifo

[jira] [Updated] (KAFKA-18797) Flaky testLargeAssignmentAndGroupWithUniformSubscription

2025-03-20 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18797: -- Attachment: Each object memory usage.png Java Heap Memory.png > Flaky testLargeAssignm

[jira] [Updated] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-20 Thread Ranganath Samudrala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranganath Samudrala updated KAFKA-19022: Component/s: kraft > Display cluster IDs being compared when encountering INCONSIS

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r2005945059 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -292,17 +292,43 @@ public int writeTo(TransferableChannel destChannel, int offset, int le

Re: [PR] MINOR: Add 4.0.0 to core system tests [kafka]

2025-03-20 Thread via GitHub
dajac merged PR #19238: URL: https://github.com/apache/kafka/pull/19238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r2005945059 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -292,17 +292,43 @@ public int writeTo(TransferableChannel destChannel, int offset, int le

[PR] [MINOR] UnifiedLog topic-partition as attribute as it is stable [kafka]

2025-03-20 Thread via GitHub
jeqo opened a new pull request, #19253: URL: https://github.com/apache/kafka/pull/19253 TopicPartition; different from e.g. LogConfig which can change and it's managed by LocalLog; is stable and can be its own attribute instead of accessing LocalLog#topicPartition -- This is an automated

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-20 Thread via GitHub
wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2740154032 I have found failed tests related to the PR changes. I will try to fix them as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Created] (KAFKA-19020) Handle strict max fetch records in share fetch

2025-03-20 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19020: - Summary: Handle strict max fetch records in share fetch Key: KAFKA-19020 URL: https://issues.apache.org/jira/browse/KAFKA-19020 Project: Kafka Issue Type:

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2005653399 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

[jira] [Created] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-20 Thread Ranganath Samudrala (Jira)
Ranganath Samudrala created KAFKA-19022: --- Summary: Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error Key: KAFKA-19022 URL: https://issues.apache.org/jira/browse/KAFKA-19022

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006621799 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006623313 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: add log4j2.yaml to clients-integration-tests module [kafka]

2025-03-20 Thread via GitHub
m1a2st commented on code in PR #19252: URL: https://github.com/apache/kafka/pull/19252#discussion_r2006659977 ## clients/clients-integration-tests/src/test/resources/log4j2.yaml: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

Re: [PR] Fix IllegalStateException for Transaction Producer [kafka]

2025-03-20 Thread via GitHub
github-actions[bot] commented on PR #19204: URL: https://github.com/apache/kafka/pull/19204#issuecomment-2742145000 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17871: avoid blocking the herder thread when producer flushing hangs [kafka]

2025-03-20 Thread via GitHub
github-actions[bot] commented on PR #18142: URL: https://github.com/apache/kafka/pull/18142#issuecomment-2742145207 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-20 Thread via GitHub
AndrewJSchofield commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2006786717 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -2266,9 +2376,8 @@ void testLeadershipChangeAft

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-20 Thread via GitHub
frankvicky commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2006838229 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006572583 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -636,8 +632,6 @@ private TransactionManager configureTransactionState(ProducerConf

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
junrao commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006572003 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tra

Re: [PR] Kafka-18914 Migrate ConsumerRebootstrapTest to use new test infra [kafka]

2025-03-20 Thread via GitHub
clarkwtc commented on code in PR #19154: URL: https://github.com/apache/kafka/pull/19154#discussion_r2006735714 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientRebootstrapTest.java: ## @@ -94,4 +101,129 @@ public void testAdminRebootstrapDisable

Re: [PR] Kafka-18914 Migrate ConsumerRebootstrapTest to use new test infra [kafka]

2025-03-20 Thread via GitHub
clarkwtc commented on code in PR #19154: URL: https://github.com/apache/kafka/pull/19154#discussion_r2006735714 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientRebootstrapTest.java: ## @@ -94,4 +101,129 @@ public void testAdminRebootstrapDisable

Re: [PR] Kafka-18914 Migrate ConsumerRebootstrapTest to use new test infra [kafka]

2025-03-20 Thread via GitHub
clarkwtc commented on code in PR #19154: URL: https://github.com/apache/kafka/pull/19154#discussion_r2006735714 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientRebootstrapTest.java: ## @@ -94,4 +101,129 @@ public void testAdminRebootstrapDisable

Re: [PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-20 Thread via GitHub
frankvicky commented on code in PR #19258: URL: https://github.com/apache/kafka/pull/19258#discussion_r2006942117 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/ManualEventProcessor.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-20 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2006278691 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006668652 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

[jira] [Updated] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-20 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanskar Jhajharia updated KAFKA-19024: -- Summary: Enhance the client behaviour when it tries to exceed the `group.share.max.gro

Re: [PR] KAFKA-15599: Move MetadataLogConfig to raft module [kafka]

2025-03-20 Thread via GitHub
chia7712 merged PR #19246: URL: https://github.com/apache/kafka/pull/19246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19017) Change consumer-config to command-config in verifiable_share_consumer.py

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19017. -- Resolution: Fixed > Change consumer-config to command-config in verifiable_share_consu

Re: [PR] MINOR: Move FileRecord JavaDoc to comment [kafka]

2025-03-20 Thread via GitHub
chia7712 merged PR #19257: URL: https://github.com/apache/kafka/pull/19257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-20 Thread via GitHub
chia7712 commented on code in PR #19258: URL: https://github.com/apache/kafka/pull/19258#discussion_r2006892258 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/MockCoordinatorShard.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-03-20 Thread via GitHub
TaiJuWu commented on code in PR #19064: URL: https://github.com/apache/kafka/pull/19064#discussion_r2005040735 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1723,7 +1723,7 @@ class ReplicaManager(val config: KafkaConfig, metadata => findPreferredRea

Re: [PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-03-20 Thread via GitHub
TaiJuWu commented on code in PR #19064: URL: https://github.com/apache/kafka/pull/19064#discussion_r2005040735 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1723,7 +1723,7 @@ class ReplicaManager(val config: KafkaConfig, metadata => findPreferredRea

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes (#18012) [kafka]

2025-03-20 Thread via GitHub
FrankYang0529 commented on PR #18842: URL: https://github.com/apache/kafka/pull/18842#issuecomment-2739478628 Flaky tests: * AbstractCoordinatorTest.testWakeupAfterSyncGroupSentExternalCompletion: This is addressed by https://github.com/apache/kafka/commit/19d8a414ef6d86596d5f8d33828

[jira] [Commented] (KAFKA-18792) Enforce uniform PR structure for merge queue

2025-03-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937042#comment-17937042 ] Mickael Maison commented on KAFKA-18792: I like the idea. It's probably somethin

Re: [PR] KAFKA-17900:Consider async resolution for client-side regex in new consumer [kafka]

2025-03-20 Thread via GitHub
github-actions[bot] commented on PR #17769: URL: https://github.com/apache/kafka/pull/17769#issuecomment-2739046237 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-15599: Move MetadataLogConfig to raft module [kafka]

2025-03-20 Thread via GitHub
mimaison commented on code in PR #19246: URL: https://github.com/apache/kafka/pull/19246#discussion_r2005256168 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Created] (KAFKA-19017) Change consumer-config to command-config in verifiable_share_consumer.py

2025-03-20 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19017: - Summary: Change consumer-config to command-config in verifiable_share_consumer.py Key: KAFKA-19017 URL: https://issues.apache.org/jira/browse/KAFKA-19017 Project: K

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-20 Thread via GitHub
wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2739702175 @frankvicky Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-15599: Move MetadataLogConfig to raft module [kafka]

2025-03-20 Thread via GitHub
frankvicky commented on code in PR #19246: URL: https://github.com/apache/kafka/pull/19246#discussion_r2005100816 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Resolved] (KAFKA-18989) Optimize FileRecord#searchForOffsetWithSize

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18989. Fix Version/s: 4.1.0 Resolution: Fixed > Optimize FileRecord#searchForOffsetWithSiz

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-20 Thread via GitHub
chia7712 merged PR #19214: URL: https://github.com/apache/kafka/pull/19214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-806) Index may not always observe log.index.interval.bytes

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-806: - Fix Version/s: 4.0.1 > Index may not always observe log.index.interval.bytes > ---

[jira] [Resolved] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18768. Resolution: Duplicate > Backport KAFKA-806 to 4.0 > - > >

[jira] [Updated] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18768: --- Fix Version/s: (was: 4.0.1) > Backport KAFKA-806 to 4.0 > - > >

[jira] [Reopened] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-18768: > Backport KAFKA-806 to 4.0 > - > > Key: KAFKA-18768 >

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2025-03-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937052#comment-17937052 ] Mickael Maison commented on KAFKA-14579: In all the other tasks we moved the too

[jira] [Created] (KAFKA-19016) Validate retention behaviour of share groups

2025-03-20 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19016: Summary: Validate retention behaviour of share groups Key: KAFKA-19016 URL: https://issues.apache.org/jira/browse/KAFKA-19016 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937061#comment-17937061 ] Mickael Maison commented on KAFKA-16538: [~jsancio] Are you planning to have thi

[jira] [Commented] (KAFKA-18747) Persister request de-duplication

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937060#comment-17937060 ] Andrew Schofield commented on KAFKA-18747: -- This refers to the possibility of d

[jira] [Assigned] (KAFKA-18747) Persister request de-duplication

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18747: Assignee: Sushant Mahajan (was: Andrew Schofield) > Persister request de-duplica

Re: [PR] KAFKA-18329; [1/3] Delete old group coordinator (KIP-848) [kafka]

2025-03-20 Thread via GitHub
dajac commented on PR #19243: URL: https://github.com/apache/kafka/pull/19243#issuecomment-2739398028 I got a run of all the system tests with this change: https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-03-19--001.439f7ae9-8e82-42

[jira] [Resolved] (KAFKA-17045) Move MetadataLogConfig from kafka to kafka.raft

2025-03-20 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-17045. --- Resolution: Duplicate This will be covered by https://issues.apache.org/jira/browse/KAFKA-15599 with

[jira] [Assigned] (KAFKA-17045) Move MetadataLogConfig from kafka to kafka.raft

2025-03-20 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17045: - Assignee: (was: PoAn Yang) > Move MetadataLogConfig from kafka to kafka.raft >

Re: [PR] MINOR: Add 4.0.0 to streams system tests [kafka]

2025-03-20 Thread via GitHub
dajac commented on PR #19239: URL: https://github.com/apache/kafka/pull/19239#issuecomment-2739411731 @mjsax Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2025-03-20 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937024#comment-17937024 ] TaiJuWu commented on KAFKA-14579: - Hi [~mimaison] , thanks for your feedback but I am co

Re: [PR] KAFKA-18946: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module [kafka]

2025-03-20 Thread via GitHub
FrankYang0529 commented on code in PR #19174: URL: https://github.com/apache/kafka/pull/19174#discussion_r2004985073 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -605,6 +616,9 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Log

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-03-20 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937036#comment-17937036 ] PoAn Yang commented on KAFKA-14485: --- Hi [~javakillah], if you're not working on this i

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-03-20 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937041#comment-17937041 ] Dmitry Werner commented on KAFKA-14485: --- Hello [~yangpoan]  The moving of LogClean

[jira] [Updated] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-18902: - Summary: Implement ShareConsumer option to throw on poll if there are unacked records (

[jira] [Updated] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-18902: - Description: Currently, an application using explicit acknowledgement which neglects to

Re: [PR] KAFKA-19013 Reformat PR body to 72 characters [kafka]

2025-03-20 Thread via GitHub
ijuma commented on PR #19242: URL: https://github.com/apache/kafka/pull/19242#issuecomment-2740272180 Did we check that GitHub doesn't do this automatically? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Assigned] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-03-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18902: Assignee: Shivsundar R (was: Andrew Schofield) > Implement ShareConsumer option

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
lianetm commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2005638869 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing f

Re: [PR] KAFKA-18946: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module [kafka]

2025-03-20 Thread via GitHub
chia7712 merged PR #19174: URL: https://github.com/apache/kafka/pull/19174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18946) Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module

2025-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18946. Fix Version/s: 4.1.0 Resolution: Fixed > Move BrokerReconfigurable and DynamicProdu

  1   2   >