Parkerhiphop commented on code in PR #19213:
URL: https://github.com/apache/kafka/pull/19213#discussion_r2006169550
##########
tools/src/test/java/org/apache/kafka/tools/ClientMetricsCommandTest.java:
##########
@@ -156,6 +166,27 @@ public void testAlterGenerateName() {
assertTrue(capturedOutput.contains("Altered client metrics config"));
}
+ @Test
+ public void testAlterResetConfigs() {
+ Admin adminClient = mock(Admin.class);
+ ClientMetricsCommand.ClientMetricsService service = new
ClientMetricsCommand.ClientMetricsService(adminClient);
+
+ AlterConfigsResult result =
AdminClientTestUtils.alterConfigsResult(new
ConfigResource(ConfigResource.Type.CLIENT_METRICS, clientMetricsName));
+ when(adminClient.incrementalAlterConfigs(any(),
any())).thenReturn(result);
Review Comment:
@chia7712 I've add an ArgumentCaptor to capture the input arguments to
ensure all of them are delete ops.
Thanks for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
