TaiJuWu commented on code in PR #19064:
URL: https://github.com/apache/kafka/pull/19064#discussion_r2005040735
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1723,7 +1723,7 @@ class ReplicaManager(val config: KafkaConfig,
metadata => findPreferredReadReplica(partition, metadata,
params.replicaId, fetchInfo.fetchOffset, fetchTimeMs))
if (preferredReadReplica.isDefined) {
- replicaSelectorOpt.foreach { selector =>
+ replicaSelectorPlugin.foreach { selector =>
debug(s"Replica selector ${selector.getClass.getSimpleName}
returned preferred replica " +
Review Comment:
Oh, you are correct. Thanks for catching it.
https://github.com/apache/kafka/pull/19064/commits/f1d62cb1cc5205c99734eb2c92e149a3002666f9
is the fix.
All comments are addressed. Thanks for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
