[jira] [Commented] (KAFKA-18986) Properly handle configured topology soft-state using KIP-1101

2025-03-15 Thread Abhinav Agrawal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935709#comment-17935709 ] Abhinav Agrawal commented on KAFKA-18986: - Hey [~lucasbru] I’m interested in ta

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-15 Thread via GitHub
sjhajharia commented on code in PR #19069: URL: https://github.com/apache/kafka/pull/19069#discussion_r1996581284 ## metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java: ## @@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) {

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
snehashisp commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996159121 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractStatus.java: ## @@ -34,18 +34,29 @@ public enum State { private final State state;

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-15 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1988847629 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1994,287 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18637: Fix max connections per ip and override reconfigurations [kafka]

2025-03-15 Thread via GitHub
clolov merged PR #19099: URL: https://github.com/apache/kafka/pull/19099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[PR] MINOR Fixup develocity report [kafka]

2025-03-15 Thread via GitHub
mumrah opened a new pull request, #19179: URL: https://github.com/apache/kafka/pull/19179 After our recent build task changes, this report no longer works. This patch fixes the script to use the new test task and tags. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-18979; Report correct kraft.version in ApiVersions [kafka]

2025-03-15 Thread via GitHub
showuon commented on PR #19205: URL: https://github.com/apache/kafka/pull/19205#issuecomment-2723405331 Thanks for the PR. The change makes sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19169: URL: https://github.com/apache/kafka/pull/19169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-03-15 Thread via GitHub
AndrewJSchofield commented on code in PR #19026: URL: https://github.com/apache/kafka/pull/19026#discussion_r1995955869 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicMetadataTest.java: ## @@ -79,4 +80,30 @@ public void testEquals() {

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-03-15 Thread via GitHub
edoardocomar commented on code in PR #19206: URL: https://github.com/apache/kafka/pull/19206#discussion_r1995385172 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTestThreadLeakIgnore.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to th

Re: [PR] KAFKA-18811: Added command configs to admin client as well in VerifiableShareConsumer [kafka]

2025-03-15 Thread via GitHub
AndrewJSchofield merged PR #19130: URL: https://github.com/apache/kafka/pull/19130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18929: Log a warning when time based segment delete is blocked by a future timestamp [kafka]

2025-03-15 Thread via GitHub
urbandan commented on code in PR #19137: URL: https://github.com/apache/kafka/pull/19137#discussion_r1983275116 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1522,6 +1522,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, val startMs = time.milliseconds

Re: [PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-03-15 Thread via GitHub
m1a2st commented on PR #19062: URL: https://github.com/apache/kafka/pull/19062#issuecomment-2702466343 Hello @mingyen066, Please merge the latest trunk. There was a revert on trunk that should fix the CI issues. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-03-15 Thread via GitHub
edoardocomar commented on code in PR #19206: URL: https://github.com/apache/kafka/pull/19206#discussion_r1995387744 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTestThreadLeakIgnore.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to th

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-15 Thread via GitHub
mumrah commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1987340954 ## build.gradle: ## @@ -1531,15 +1531,15 @@ project(':test-common:test-common-runtime') { } dependencies { -implementation project(':test-common:test-common-

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-15 Thread via GitHub
FrankYang0529 commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1983535958 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -153,7 +153,7 @@ class ControllerServer( val apiVersionManager = new SimpleApiVersionMana

[jira] [Assigned] (KAFKA-18983) Ensure all README.md(s) are mentioned by the root README.md

2025-03-15 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szu-Yung Wang reassigned KAFKA-18983: - Assignee: Szu-Yung Wang (was: Chia-Ping Tsai) > Ensure all README.md(s) are mentioned

[PR] KAFKA-18739 Add group level Sstreams configuration [kafka]

2025-03-15 Thread via GitHub
aliehsaeedii opened a new pull request, #19176: URL: https://github.com/apache/kafka/pull/19176 This PR implements the configs proposed in [KIP-1071](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627992#KIP1071:StreamsRebalanceProtocol-BrokerConfigurations) -- Th

Re: [PR] KAFKA-18941: Do not test 3.3 in upgrade_tests.py [kafka]

2025-03-15 Thread via GitHub
cmccabe commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2711808210 @josefk31 thanks for the explanation. let's disable this for now, given how old 3.3 is. If someone wants to put some time into getting 3.3 working, that is welcome as well... but at least

Re: [PR] KAFKA-18953: [1/N] Add broker side handling for 2 PC (KIP-939) [kafka]

2025-03-15 Thread via GitHub
artemlivshits commented on code in PR #19193: URL: https://github.com/apache/kafka/pull/19193#discussion_r1996307814 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -124,10 +127,18 @@ class TransactionCoordinator(txnConfig: TransactionCon

[jira] [Updated] (KAFKA-18969) Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18969: --- Description: Using BeforeEach can ensure the `setup` is executed for each test case. Also, S

[jira] [Created] (KAFKA-18991) AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state

2025-03-15 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18991: --- Summary: AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state Key: KAFKA-18991 URL: https://issues.apache.org/jira/b

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-15 Thread via GitHub
sjhajharia commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2727223086 Hey @chia7712 Thanks for helping merge the msteadata cleanup PR. Here is the next PR in line. Pls review when possible. TIA -- This is an automated message from the Apache Git

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19214: URL: https://github.com/apache/kafka/pull/19214#issuecomment-2727211778 @m1a2st Could you please test the approach which I left on the jira? Also, please add unit test to ensure the new approach does NOT call last offset for each batches! -- This is an au

[jira] [Commented] (KAFKA-18877) an mechanism to find cases where we accessed variables from the wrong thread

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935801#comment-17935801 ] Chia-Ping Tsai commented on KAFKA-18877: I do love [~davidarthur] suggestion. Ma

[jira] [Created] (KAFKA-18996) Expose addReadOnlyStateStore (

2025-03-15 Thread Hartmut Armbruster (Jira)
Hartmut Armbruster created KAFKA-18996: -- Summary: Expose addReadOnlyStateStore ( Key: KAFKA-18996 URL: https://issues.apache.org/jira/browse/KAFKA-18996 Project: Kafka Issue Type: Improv

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932941#comment-17932941 ] Luke Chen commented on KAFKA-18871: --- [~davidarthur] , thanks for the comment. > Even

Re: [PR] KAFKA-18993: Remove confusing notable change section from upgrade.html [kafka]

2025-03-15 Thread via GitHub
frankvicky commented on PR #19212: URL: https://github.com/apache/kafka/pull/19212#issuecomment-2726363834 Hi @showuon Please take a look when you have a free moment. Many thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] MINOR Increase JUnit max forks and memory for CI [kafka]

2025-03-15 Thread via GitHub
mumrah merged PR #18560: URL: https://github.com/apache/kafka/pull/18560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Commented] (KAFKA-7079) ValueTransformerWithKeySupplier is not mentioned in the documentation

2025-03-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933674#comment-17933674 ] Matthias J. Sax commented on KAFKA-7079: With the new type-safe PAPI (v2), ValueT

[jira] [Updated] (KAFKA-18994) Wrong configuration in docker-compose.yml example

2025-03-15 Thread Robert Zilke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Zilke updated KAFKA-18994: - Description: h3. Incorrect `docker-compose.yml` Configuration in Apache Kafka Docker Image The

[jira] [Updated] (KAFKA-18994) Wrong configuration in docker-compose.yml example

2025-03-15 Thread Robert Zilke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Zilke updated KAFKA-18994: - Description: h3. Incorrect `docker-compose.yml` Configuration in Apache Kafka Docker Image The

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-03-15 Thread via GitHub
smjn commented on code in PR #19026: URL: https://github.com/apache/kafka/pull/19026#discussion_r1996037893 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -443,7 +454,19 @@ public CompletableFuture shareGroupHeartbeat(

[jira] [Updated] (KAFKA-18994) Wrong configuration in docker-compose.yml example

2025-03-15 Thread Robert Zilke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Zilke updated KAFKA-18994: - Description: h3. Incorrect `docker-compose.yml` Configuration in Apache Kafka Docker Image The

Re: [PR] MINOR: Remove unused ConfigCommandOptions#forceOpt [kafka]

2025-03-15 Thread via GitHub
frankvicky commented on PR #19170: URL: https://github.com/apache/kafka/pull/19170#issuecomment-2709318352 Hi @chia7712 I think this field has been unused since this commit: https://github.com/apache/kafka/commit/d04b0998c043a6a430921585ffd4c42572a3bf5a#diff-750cea92bdee85f7dffaf4020f

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-03-15 Thread via GitHub
bbejeck commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2711200622 @ukpagrace gentle ping for updates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Fix the CLIENT_QUOTA_CALLBACK_CLASS_CONFIG document [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #18713: URL: https://github.com/apache/kafka/pull/18713#issuecomment-2726939513 @m1a2st could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18859: honor the error message of UnregisterBrokerResponse [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19027: URL: https://github.com/apache/kafka/pull/19027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19069: URL: https://github.com/apache/kafka/pull/19069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on code in PR #18463: URL: https://github.com/apache/kafka/pull/18463#discussion_r1997240130 ## core/src/test/java/kafka/admin/StaticBrokerConfigTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #18937: URL: https://github.com/apache/kafka/pull/18937#issuecomment-2726942869 @wernerdv could you please fix the conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17836: Move RackAwareTest to server module [kafka]

2025-03-15 Thread via GitHub
chia7712 closed pull request #17998: KAFKA-17836: Move RackAwareTest to server module URL: https://github.com/apache/kafka/pull/17998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Commented] (KAFKA-18989) Optimize FileRecord#searchForOffsetWithSize

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935771#comment-17935771 ] Chia-Ping Tsai commented on KAFKA-18989: {code:java} diff --git a/clients/src/

[jira] [Resolved] (KAFKA-18859) honor the error message of UnregisterBrokerResponse

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18859. Fix Version/s: 4.1.0 Resolution: Fixed > honor the error message of UnregisterBroke

[jira] [Commented] (KAFKA-18696) Migrate suitable classes to records

2025-03-15 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933746#comment-17933746 ] Ming-Yen Chung commented on KAFKA-18696: Also, ensure that we do not migrate the

[jira] [Created] (KAFKA-18952) Fix flaky MonitorableSinkIntegrationTest#testMonitorableSinkConnectorAndTask

2025-03-15 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18952: -- Summary: Fix flaky MonitorableSinkIntegrationTest#testMonitorableSinkConnectorAndTask Key: KAFKA-18952 URL: https://issues.apache.org/jira/browse/KAFKA-18952 Proj

Re: [PR] MINOR: reduce per-batch logging to TRACE level [kafka]

2025-03-15 Thread via GitHub
mjsax commented on PR #19101: URL: https://github.com/apache/kafka/pull/19101#issuecomment-2705131559 Cherry-picked to `4.0`, `3.9`, and `3.8` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-7699) Improve wall-clock time punctuations

2025-03-15 Thread Herman Kolstad Jakobsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herman Kolstad Jakobsen reassigned KAFKA-7699: -- Assignee: Herman Kolstad Jakobsen > Improve wall-clock time punctuatio

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-03-15 Thread via GitHub
junrao commented on code in PR #19197: URL: https://github.com/apache/kafka/pull/19197#discussion_r1995965819 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1544,12 +1544,14 @@ class ReplicaManager(val config: KafkaConfig, fetc

[PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-15 Thread via GitHub
Parkerhiphop opened a new pull request, #19213: URL: https://github.com/apache/kafka/pull/19213 Currently, providing an empty value (`--interval=`) resulted in an error: `ERROR joptsimple.OptionArgumentConversionException: Cannot parse argument '' of option interval` This patch upd

[jira] [Created] (KAFKA-18995) MirrorMaker2 does not replicate from secondary to primary DC

2025-03-15 Thread Prashanth (Jira)
Prashanth created KAFKA-18995: - Summary: MirrorMaker2 does not replicate from secondary to primary DC Key: KAFKA-18995 URL: https://issues.apache.org/jira/browse/KAFKA-18995 Project: Kafka Issue

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
snehashisp commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996153071 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TaskPluginsMetadata.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] KAFKA-18993: Remove confusing notable change section from upgrade.html [kafka]

2025-03-15 Thread via GitHub
dajac commented on PR #19212: URL: https://github.com/apache/kafka/pull/19212#issuecomment-272317 I am fine with removing it. Let’s open a PR against kafka-site to remove it there too. We should also cherry-pick it to 4.0. -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2709316749 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-03-15 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r1982874485 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupOffsetsResult.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-15 Thread via GitHub
ijuma commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982857330 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.u

[jira] [Created] (KAFKA-18950) Allow to "shift" window-start anchor for Tumbling/Hopping windows

2025-03-15 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18950: --- Summary: Allow to "shift" window-start anchor for Tumbling/Hopping windows Key: KAFKA-18950 URL: https://issues.apache.org/jira/browse/KAFKA-18950 Project: Kafk

Re: [PR] KAFKA-18929: Log a warning when time based segment delete is blocked by a future timestamp [kafka]

2025-03-15 Thread via GitHub
viktorsomogyi commented on code in PR #19137: URL: https://github.com/apache/kafka/pull/19137#discussion_r1983354737 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1522,6 +1522,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, val startMs = time.milliseco

Re: [PR] Small fit and finish changes to Producer config doc strings [kafka]

2025-03-15 Thread via GitHub
cherylws commented on code in PR #19125: URL: https://github.com/apache/kafka/pull/19125#discussion_r1984029165 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -94,7 +94,7 @@ public class ProducerConfig extends AbstractConfig {

[jira] [Created] (KAFKA-18990) Optimize BaseQuotaTest#produceUntilThrottled to avoid redundant MetricName creation

2025-03-15 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18990: -- Summary: Optimize BaseQuotaTest#produceUntilThrottled to avoid redundant MetricName creation Key: KAFKA-18990 URL: https://issues.apache.org/jira/browse/KAFKA-18990

Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19109: URL: https://github.com/apache/kafka/pull/19109#issuecomment-2704555256 > Can we add a test for this? The fact that we added a pretty serious bug and no test failed is important to address. Sure. @dengziming do you have free cycle to address it? If not

Re: [PR] MINOR: Improve the example of kafka-metadata-shell.sh [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19107: URL: https://github.com/apache/kafka/pull/19107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-9148) Consider forking RocksDB for Streams

2025-03-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9148. Resolution: Won't Fix Don't think it's a good idea to folk RocksDB to begin with... Also th

[jira] [Updated] (KAFKA-18972) Custom Processor supplied on addReadOnlyStateStore is not used when restoring state from topic

2025-03-15 Thread Hartmut Armbruster (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hartmut Armbruster updated KAFKA-18972: --- Description: As a Streams Developer, I have added a custom read-only state store ([

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-03-15 Thread via GitHub
m1a2st commented on PR #18861: URL: https://github.com/apache/kafka/pull/18861#issuecomment-2721018031 Thanks for @junrao review, addressed all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-15 Thread via GitHub
clarkwtc commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1996809477 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientRebootstrapTest.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
gharris1727 commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996154736 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConnectorStateInfo.java: ## @@ -87,14 +90,26 @@ public String workerId() {

[PR] MINOR: remove incorrect deprecated annotations from internal Streams classes [kafka]

2025-03-15 Thread via GitHub
aliehsaeedii opened a new pull request, #19195: URL: https://github.com/apache/kafka/pull/19195 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-15 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935391#comment-17935391 ] A. Sophie Blee-Goldman commented on KAFKA-16277: I agree it could be bet

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19187: URL: https://github.com/apache/kafka/pull/19187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18969: Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on code in PR #19202: URL: https://github.com/apache/kafka/pull/19202#discussion_r1997212608 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2473,4 +2414,57 @@ private void shutdownExecutorSer

Re: [PR] KAFKA-18703: Remove unused class PayloadKeyType [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19129: URL: https://github.com/apache/kafka/pull/19129#issuecomment-2726929696 the usage of `PayloadKeyType` was removed by https://github.com/apache/kafka/commit/a70e4f95d713dd34757b3807171a2e520dd9c04d -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-18703: Remove unused class PayloadKeyType [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19129: URL: https://github.com/apache/kafka/pull/19129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18993: Remove confusing notable change section from upgrade.html [kafka]

2025-03-15 Thread via GitHub
chia7712 merged PR #19212: URL: https://github.com/apache/kafka/pull/19212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18703) Remove unused class PayloadKeyType

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18703. Fix Version/s: 4.1.0 Resolution: Fixed > Remove unused class PayloadKeyType > -

Re: [PR] KAFKA-18993: Remove confusing notable change section from upgrade.html [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19212: URL: https://github.com/apache/kafka/pull/19212#issuecomment-2726936184 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18993: Remove confusing notable change section from upgrade.html [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19212: URL: https://github.com/apache/kafka/pull/19212#issuecomment-2726936256 @frankvicky please file a patch to kafka-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-18993) 2 "Notable changes in 4.0.0" section for v4.0

2025-03-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18993. Fix Version/s: 4.0.0 Resolution: Fixed trunk: https://github.com/apache/kafka/comm

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on code in PR #19071: URL: https://github.com/apache/kafka/pull/19071#discussion_r1997227330 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java: ## @@ -391,24 +386,20 @@ public void testStateStore() { public void shou

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-15 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991054160 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-15 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1983105698 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

Re: [PR] MINOR: Update log4j2 to 2.24.3 [kafka]

2025-03-15 Thread via GitHub
ijuma commented on PR #19135: URL: https://github.com/apache/kafka/pull/19135#issuecomment-2704564680 Cherry-picked to 4.0 as well since the fixed bugs look pretty serious. @dajac had added the `blocker` label, so I think he agrees. -- This is an automated message from the Apache Git Serv

[jira] [Resolved] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2025-03-15 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15900. Fix Version/s: 4.1.0 Resolution: Fixed > Flaky test: testOutdatedCoordinatorAssignm

Re: [PR] KAFKA-18607: Update jfreechart dependency [kafka]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #19074: URL: https://github.com/apache/kafka/pull/19074#issuecomment-2709316554 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18955: Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-15 Thread via GitHub
josefk31 commented on code in PR #19165: URL: https://github.com/apache/kafka/pull/19165#discussion_r1987726881 ## generator/src/main/java/org/apache/kafka/message/checker/CheckerUtils.java: ## @@ -121,18 +121,34 @@ static MessageSpec readMessageSpecFromString(String contents)

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-15 Thread via GitHub
Yunyung commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991771351 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.c

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
snehashisp commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996162968 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ## @@ -391,6 +391,11 @@ public void execute() { finalOffset

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
snehashisp commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996134289 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConnectorStateInfo.java: ## @@ -87,14 +90,26 @@ public String workerId() { p

Re: [PR] KAFKA-10863: Convert ControRecordType schema to use auto-generated protocol [kafka]

2025-03-15 Thread via GitHub
chia7712 commented on PR #19110: URL: https://github.com/apache/kafka/pull/19110#issuecomment-2725794433 > Just as someone say, the two most difficult things in computational science are naming and cache invalidation, I changed the name to ControlRecordType but we should use its full quali

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-15 Thread via GitHub
snehashisp commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1996169025 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TaskPluginsMetadata.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Created] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-15 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18992: - Summary: kafka-features.sh wronly output `upgraded kraft.version to 1` Key: KAFKA-18992 URL: https://issues.apache.org/jira/browse/KAFKA-18992 Project: Kafka Issu

[jira] [Updated] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-18992: -- Description: When using static quorum and upgraded to v4.0, the upgrade command showed `kraft.version

[jira] [Commented] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935714#comment-17935714 ] Matthias J. Sax commented on KAFKA-18943: - Due to RC4, we could actually include

[jira] [Updated] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-18992: -- Description: When using static quorum and upgraded to v4.0, the upgrade command showed `kraft.version

[jira] [Created] (KAFKA-18993) 2 "Notable changes in 4.0.0" section for v4.0

2025-03-15 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18993: - Summary: 2 "Notable changes in 4.0.0" section for v4.0 Key: KAFKA-18993 URL: https://issues.apache.org/jira/browse/KAFKA-18993 Project: Kafka Issue Type: Improveme

Re: [PR] [WIP] KAFKA-18989: Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-15 Thread via GitHub
mingdaoy closed pull request #19211: [WIP] KAFKA-18989: Optimize FileRecord#searchForOffsetWithSize URL: https://github.com/apache/kafka/pull/19211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Assigned] (KAFKA-18993) 2 "Notable changes in 4.0.0" section for v4.0

2025-03-15 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18993: --- Assignee: TengYao Chi > 2 "Notable changes in 4.0.0" section for v4.0 > ---

[jira] [Assigned] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-15 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18992: --- Assignee: TengYao Chi > kafka-features.sh wronly output `upgraded kraft.version to 1` > ---

[jira] [Created] (KAFKA-18994) Wrong configuration in docker-compose.yml example

2025-03-15 Thread Robert Zilke (Jira)
Robert Zilke created KAFKA-18994: Summary: Wrong configuration in docker-compose.yml example Key: KAFKA-18994 URL: https://issues.apache.org/jira/browse/KAFKA-18994 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-15 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935718#comment-17935718 ] TengYao Chi commented on KAFKA-18992: - [https://github.com/apache/kafka/blob/93499df

  1   2   >