smjn commented on code in PR #19026:
URL: https://github.com/apache/kafka/pull/19026#discussion_r1996037893
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -443,7 +454,19 @@ public CompletableFuture<ShareGroupHeartbeatResponseData>
shareGroupHeartbeat(
topicPartitionFor(request.groupId()),
Duration.ofMillis(config.offsetCommitTimeoutMs()),
coordinator -> coordinator.shareGroupHeartbeat(context, request)
- ).exceptionally(exception -> handleOperationException(
+ ).thenCompose(result -> {
+ // This ensures that the previous group write has completed
successfully
+ // before we start the persister initialize phase.
+ if (result.getValue().isPresent()) {
Review Comment:
Then the below exceptionally block will execute and the client will be
notified of the error. In the next heartbeat, this will get retried.
If thenCompose is executing, result will be present by nature of coordinator
runtime write operations. They are completed only when the records have been
replicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
