chirag-wadhwa5 commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r1982874485
########## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupOffsetsResult.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.admin; + +import org.apache.kafka.common.KafkaFuture; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.annotation.InterfaceStability; +import org.apache.kafka.common.internals.KafkaFutureImpl; +import org.apache.kafka.common.protocol.Errors; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * The result of the {@link Admin#deleteShareGroupOffsets(String, Set, DeleteShareGroupOffsetsOptions)} call. + * <p> + * The API of this class is evolving, see {@link Admin} for details. + */ +@InterfaceStability.Evolving +public class DeleteShareGroupOffsetsResult { + + private final KafkaFuture<Map<TopicPartition, Errors>> future; + + DeleteShareGroupOffsetsResult(KafkaFuture<Map<TopicPartition, Errors>> future) { + this.future = future; + } + + /** + * Return a future which succeeds only if all the deletions succeed. + */ + public KafkaFuture<Void> all() { + return this.future.thenApply(topicPartitionErrorsMap -> { + List<TopicPartition> partitionsFailed = topicPartitionErrorsMap.entrySet() + .stream() + .filter(e -> e.getValue() != Errors.NONE) + .map(Map.Entry::getKey) + .collect(Collectors.toList()); + for (Errors error : topicPartitionErrorsMap.values()) { + if (error != Errors.NONE) { + throw error.exception( + "Failed deleting share group offsets for the following partitions: " + partitionsFailed); + } + } + return null; + }); + } + + /** + * Return a future which can be used to check the result for a given partition. + */ + public KafkaFuture<Void> partitionResult(final TopicPartition partition) { + final KafkaFutureImpl<Void> result = new KafkaFutureImpl<>(); Review Comment: Thanks for the review. I believe that is done in `DeleteConsumerGroupOffsetsResult`, but that was because we are passing set of topicPartitions to the `DeleteConsumerGroupOffsetsResult` constructor itself. There it was possible to check whether the given partition in `partitionResult` method was a part of the set of partitions and throw the error without even waiting for `future` to complete. But since there's no such need yet to pass the set of topic partitions, we need to wait for the `future` to complete before we can make sure that the given partition is contained in the result or not. Once inside whenComplete, I believe throwing an error will only make a difference in the completion state of `future`, not `result`. Since `result` is what is being returned from the method, directly throwing an exception would be missed. I believe the correct way would be to complete the future exceptionally, or maybe have the set of topic partitions in the class itself, so that we don't need t o wait for the completion of `future`. Let me know what sounds good to you, will make the changes appropriately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
