[PR] create separate merge_group workflow [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah opened a new pull request, #62: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/62 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-03-12 Thread via GitHub
junrao commented on code in PR #18861: URL: https://github.com/apache/kafka/pull/18861#discussion_r1992116002 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/BaseDeleteSegmentsTest.java: ## @@ -55,7 +56,7 @@ protected void writeTestSpecifications(TieredStor

[jira] [Assigned] (KAFKA-18955) MetadataSchemaCheckerTool bug fixes

2025-03-12 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-18955: Assignee: Alyssa Huang > MetadataSchemaCheckerTool bug fixes > --

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-12 Thread via GitHub
sjhajharia commented on code in PR #19069: URL: https://github.com/apache/kafka/pull/19069#discussion_r1992084076 ## metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java: ## @@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) {

Re: [PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-12 Thread via GitHub
mimaison merged PR #19175: URL: https://github.com/apache/kafka/pull/19175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18970) [kafka-clients] Gradle module metadata publication should be enabled

2025-03-12 Thread Jira
Dejan Stojadinović created KAFKA-18970: -- Summary: [kafka-clients] Gradle module metadata publication should be enabled Key: KAFKA-18970 URL: https://issues.apache.org/jira/browse/KAFKA-18970 Proj

[jira] [Commented] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934595#comment-17934595 ] José Armando García Sancio commented on KAFKA-16538: [~zheguang] Kaf

Re: [PR] see what happens if a pr enqueued event fails [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah merged PR #61: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-18142 Switch to `com.gradleup.shadow` [kafka]

2025-03-12 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2718833869 @mumrah related JIRA ticket is created here: https://issues.apache.org/jira/browse/KAFKA-18970 **_[kafka-clients] Gradle module metadata publication should be enabled_** -- This i

Re: [PR] create separate merge_group workflow [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah merged PR #62: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Resolved] (KAFKA-18142) Switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade version)

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović resolved KAFKA-18142. Resolution: Resolved Github PR [https://github.com/apache/kafka/pull/18018] is mer

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-12 Thread via GitHub
mjsax commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2718868615 http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-test-results/?prefix=trunk/2025-03-12--001.75a62180-48c6

[jira] [Assigned] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-18971: Assignee: Alieh Saeedi > Update AK system tests for AK 4.0 >

[jira] [Created] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
Alieh Saeedi created KAFKA-18971: Summary: Update AK system tests for AK 4.0 Key: KAFKA-18971 URL: https://issues.apache.org/jira/browse/KAFKA-18971 Project: Kafka Issue Type: Task

[jira] [Updated] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi updated KAFKA-18971: - Description: Update AK system tests and add new “upgrade_from” version to {{StreamsConfig}} > U

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2716296530 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on PR #19046: URL: https://github.com/apache/kafka/pull/19046#issuecomment-2718481150 @chia7712 @ijuma I already moved this test to clients-integration-tests. I have also added `` on `import-control-clients-integration-tests.xml` -- This is an automated message f

[jira] [Assigned] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18964: --- Assignee: TengYao Chi > Allow to set weights for controller nodes for leader election > ---

[jira] [Resolved] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-12 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rameshkanna N resolved KAFKA-18938. --- Resolution: Not A Problem > Kraft version and metadata version wrongly showing > ---

Re: [PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-12 Thread via GitHub
mimaison commented on code in PR #19175: URL: https://github.com/apache/kafka/pull/19175#discussion_r1991877823 ## core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala: ## @@ -62,7 +63,7 @@ object KafkaMetricsReporter { val metricsConfig = new KafkaMetricsConfig

Re: [PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-12 Thread via GitHub
mimaison commented on code in PR #19175: URL: https://github.com/apache/kafka/pull/19175#discussion_r1991879972 ## core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala: ## @@ -62,7 +63,7 @@ object KafkaMetricsReporter { val metricsConfig = new KafkaMetricsConfig

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-03-12 Thread via GitHub
wernerdv commented on PR #18937: URL: https://github.com/apache/kafka/pull/18937#issuecomment-2718631246 @chia7712 Hello, could you please take a look when you have some free time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on code in PR #19175: URL: https://github.com/apache/kafka/pull/19175#discussion_r1991796860 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -218,30 +207,11 @@ object CoreUtils { endPoints } - def generateUuidAsBase64(): String = { -va

[jira] [Created] (KAFKA-18972) Custom Processor supplied on addReadOnlyStateStore is not used when restoring state from topic

2025-03-12 Thread Hartmut Armbruster (Jira)
Hartmut Armbruster created KAFKA-18972: -- Summary: Custom Processor supplied on addReadOnlyStateStore is not used when restoring state from topic Key: KAFKA-18972 URL: https://issues.apache.org/jira/browse/KAF

[jira] [Updated] (KAFKA-18970) [kafka-clients] Gradle module metadata publication should be enabled

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-18970: --- Labels: Gradle gradle help-wanted (was: ) > [kafka-clients] Gradle module metadata

[jira] [Commented] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934503#comment-17934503 ] Luke Chen commented on KAFKA-18964: --- Yes, this needs a KIP, and need some discussion a

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-12 Thread via GitHub
frankvicky commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1990791609 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java: ## @@ -52,13 +53,17 @@ import java.util.concurrent.atomic.AtomicLong; import java.uti

[jira] [Resolved] (KAFKA-18932) Remove partition max bytes usage from share fetch requests

2025-03-12 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-18932. --- Fix Version/s: 4.1.0 Resolution: Fixed > Remove partition max bytes usage from share

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991528511 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -82,29 +97,41 @@ public StreamsGroupHeartbeatReques

[jira] [Commented] (KAFKA-18921) Low CPU utilization during streams integration tests

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934533#comment-17934533 ] David Arthur commented on KAFKA-18921: -- I ran just the streams integration tests se

Re: [PR] Testing: run build serially [kafka]

2025-03-12 Thread via GitHub
mumrah closed pull request #19128: Testing: run build serially URL: https://github.com/apache/kafka/pull/19128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] HOTFIX remove protected_branches from asf.yaml [kafka]

2025-03-12 Thread via GitHub
mumrah closed pull request #19182: HOTFIX remove protected_branches from asf.yaml URL: https://github.com/apache/kafka/pull/19182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] HOTFIX remove protected_branches from asf.yaml [kafka]

2025-03-12 Thread via GitHub
mumrah commented on PR #19182: URL: https://github.com/apache/kafka/pull/19182#issuecomment-2717942904 I don't think we'll need this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Testing: run build serially [kafka]

2025-03-12 Thread via GitHub
mumrah commented on PR #19128: URL: https://github.com/apache/kafka/pull/19128#issuecomment-2717943626 - [ ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991526955 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java: ## @@ -601,18 +560,383 @@ public void testSendingLea

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-12 Thread via GitHub
mumrah merged PR #19168: URL: https://github.com/apache/kafka/pull/19168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
frankvicky commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1990942332 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafk

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
AndrewJSchofield merged PR #19148: URL: https://github.com/apache/kafka/pull/19148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991430908 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

[PR] MINOR Mar 12 Flaky tests [kafka]

2025-03-12 Thread via GitHub
mumrah opened a new pull request, #19190: URL: https://github.com/apache/kafka/pull/19190 Mark the following tests as flaky: * StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription * DeleteSegmentsByRetentionTimeTest * QuorumControllerTest > testUncleanShutdownB

[jira] [Commented] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934549#comment-17934549 ] PoAn Yang commented on KAFKA-18845: --- I will take a look for it. Thanks. > Fail test Q

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-12 Thread via GitHub
mimaison commented on PR #19030: URL: https://github.com/apache/kafka/pull/19030#issuecomment-2718586479 They don't seem related. They are already flaky on trunk: - [OffloadAndTxnConsumeFromLeaderTest > executeTieredStorageTest](https://develocity.apache.org/scans/tests?search.relativeSta

[jira] [Updated] (KAFKA-18967) Additional MetadataSchemaCheckerTool tests

2025-03-12 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang updated KAFKA-18967: - Description: The tests for verify-evolution and verify-evolution-git test the same schemas agai

[jira] [Created] (KAFKA-18967) Additional MetadataSchemaCheckerTool tests

2025-03-12 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18967: Summary: Additional MetadataSchemaCheckerTool tests Key: KAFKA-18967 URL: https://issues.apache.org/jira/browse/KAFKA-18967 Project: Kafka Issue Type: Improv

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991066599 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

[jira] [Comment Edited] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Gangadharan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934604#comment-17934604 ] Gangadharan edited comment on KAFKA-16277 at 3/12/25 5:14 PM:

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990996066 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

[jira] [Updated] (KAFKA-18967) Additional MetadataSchemaCheckerTool tests

2025-03-12 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang updated KAFKA-18967: - Description: The tests for verify-evolution and verify-evolution-git test the same schemas agai

Re: [PR] KAFKA-18310: Flaky AbstractCoordinatorTest [kafka]

2025-03-12 Thread via GitHub
lianetm commented on PR #18665: URL: https://github.com/apache/kafka/pull/18665#issuecomment-2711057382 Closing this one now that https://github.com/apache/kafka/pull/18945 has been merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #19169: URL: https://github.com/apache/kafka/pull/19169#issuecomment-2718652049 ``` chia7712@chia7712-ubuntu:~/project/kafka$ ./bin/kafka-metadata-shell.sh -s ~/kafka-meta/__cluster_metadata-0/9414-01.checkpoint Loading... [2025-03-

Re: [PR] KAFKA-18209 Cleanup `__transaction_state` config logic [kafka]

2025-03-12 Thread via GitHub
wernerdv commented on PR #18201: URL: https://github.com/apache/kafka/pull/18201#issuecomment-2718649671 > When I opened the ticket I was hoping we could do a bit more cleanup, but maybe there isn't much to do. The point of the Jira was to investigate and see what could be done. > >

[jira] [Resolved] (KAFKA-18947) refactor MetadataShell

2025-03-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18947. Fix Version/s: 4.1.0 Resolution: Fixed > refactor MetadataShell > -

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #19187: URL: https://github.com/apache/kafka/pull/19187#issuecomment-2718666729 @clarkwtc please check the build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18843: Fix MirrorMaker2 workerId is not unique, but use the sam… [kafka]

2025-03-12 Thread via GitHub
k0b3rIT commented on code in PR #18994: URL: https://github.com/apache/kafka/pull/18994#discussion_r1991870182 ## checkstyle/import-control.xml: ## @@ -567,6 +567,7 @@ + Review Comment: You are totally right, I have changed the code to not use t

[jira] [Created] (KAFKA-18966) Don't honor controller_num_nodes_override in combined controller test mode

2025-03-12 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-18966: -- Summary: Don't honor controller_num_nodes_override in combined controller test mode Key: KAFKA-18966 URL: https://issues.apache.org/jira/browse/KAFKA-18966 Project: Kafka

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-12 Thread via GitHub
snehashisp commented on PR #17988: URL: https://github.com/apache/kafka/pull/17988#issuecomment-2718464735 Hi @gharris1727. Thanks for the review. Will address them as soon as I get some time. Also yes, there are more PRs which adds tests for the newly added code in #18325, #18326 and #1836

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991928818 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on PR #19187: URL: https://github.com/apache/kafka/pull/19187#issuecomment-2718558946 @chia7712 I already moved this test to clients-integration-tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991935626 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.

Re: [PR] MINOR Mar 12 Flaky tests [kafka]

2025-03-12 Thread via GitHub
mumrah commented on PR #19190: URL: https://github.com/apache/kafka/pull/19190#issuecomment-2718549735 We can see these tests included in the flaky suite here https://develocity.apache.org/s/uyj7zm6j4vjtk/tests/overview -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991936204 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-12 Thread via GitHub
mumrah commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1991943081 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled = f

[jira] [Comment Edited] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Gangadharan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934604#comment-17934604 ] Gangadharan edited comment on KAFKA-16277 at 3/12/25 5:10 PM:

[PR] KAFKA-18953-[1/N]-Add broker side handling for 2 PC (KIP-939) [kafka]

2025-03-12 Thread via GitHub
rreddy-22 opened a new pull request, #19193: URL: https://github.com/apache/kafka/pull/19193 This patch adds logic to enable and handle two phase commit (2PC) transactions following KIP-939. The changes made are as follows: 1) Add a new broker config called **transaction.two.phase.comm

[jira] [Commented] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Gangadharan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934604#comment-17934604 ] Gangadharan commented on KAFKA-16277: - [~credpath-seek] /[~ableegoldman] I came acro

[jira] [Comment Edited] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Gangadharan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934604#comment-17934604 ] Gangadharan edited comment on KAFKA-16277 at 3/12/25 5:12 PM:

Re: [PR] KAFKA-18955: Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-12 Thread via GitHub
ahuang98 commented on PR #19165: URL: https://github.com/apache/kafka/pull/19165#issuecomment-2718573602 Thanks for the reviews everyone, there are a few other test cases I think we could add (e.g. different parent and child schema for verify-evolution, verify-evolution-git command) so I'll

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-03-12 Thread via GitHub
chia7712 merged PR #18662: URL: https://github.com/apache/kafka/pull/18662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18617) Support ClusterInstance in BeforeEach/AfterEach fixtures

2025-03-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18617. Fix Version/s: 4.1.0 Resolution: Fixed > Support ClusterInstance in BeforeEach/Afte

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on code in PR #19069: URL: https://github.com/apache/kafka/pull/19069#discussion_r1992038764 ## metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java: ## @@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) { Ha

[jira] [Created] (KAFKA-18969) Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module

2025-03-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18969: -- Summary: Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module Key: KAFKA-18969 URL: https://issues.apache.org/jira/bro

[jira] [Updated] (KAFKA-18969) Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module

2025-03-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18969: --- Description: Using BeforeEach can ensure the `setup` is executed for each test case. Also, S

[jira] [Assigned] (KAFKA-18969) Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18969: --- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumer

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990795619 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on PR #19119: URL: https://github.com/apache/kafka/pull/19119#issuecomment-2716852040 @mingdaoy Would you have time for updating the PR? I'd like to merge it today as this is the last remaining change blocking the 4.0 release. -- This is an automated message from the Apach

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991078954 ## docs/upgrade.html: ## @@ -52,9 +73,6 @@ Upgrading to 4.0.0 from any vers Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apa

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

[jira] [Resolved] (KAFKA-18837) Validate controller.quorum.fetch.timeout.ms is a positive value

2025-03-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18837. Fix Version/s: 4.1.0 Resolution: Fixed > Validate controller.quorum.fetch.timeout.m

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #19046: URL: https://github.com/apache/kafka/pull/19046#issuecomment-2718360474 @clarkwtc could you please move this test to clients-integration-tests ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-03-12 Thread via GitHub
fhussonnois commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2719151312 Thanks for your review. The fix should be OK now and I added the missing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-12 Thread via GitHub
AndrewJSchofield merged PR #19145: URL: https://github.com/apache/kafka/pull/19145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990997212 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1990559413 ## server/src/main/java/org/apache/kafka/server/share/fetch/PartitionRotateStrategy.java: ## @@ -80,20 +81,8 @@ static LinkedHashMap rotateRoundRobin(

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991041594 ## server/src/main/java/org/apache/kafka/server/share/ErroneousAndValidPartitionData.java: ## @@ -20,47 +20,48 @@ import org.apache.kafka.common.TopicIdPartitio

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991048323 ## server/src/main/java/org/apache/kafka/server/share/fetch/PartitionRotateStrategy.java: ## @@ -80,20 +81,11 @@ static LinkedHashMap rotateRoundRobin(

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on PR #19148: URL: https://github.com/apache/kafka/pull/19148#issuecomment-2717068996 @apoorvmittal10 , I have addressed your comments. Please review when you can. Also, I had to do a force push to fix the branch history because it got corrupted by a merge commit p

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990907805 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

[jira] [Created] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18964: - Summary: Allow to set weights for controller nodes for leader election Key: KAFKA-18964 URL: https://issues.apache.org/jira/browse/KAFKA-18964 Project: Kafka Issu

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991148865 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
ijuma commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991162921 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991184428 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991101107 ## server/src/main/java/org/apache/kafka/server/share/ErroneousAndValidPartitionData.java: ## @@ -20,47 +20,48 @@ import org.apache.kafka.common.TopicIdPartiti

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991166491 ## docs/upgrade.html: ## @@ -52,9 +73,6 @@ Upgrading to 4.0.0 from any vers Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-12 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1991245995 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2298 @@ public class UnifiedLog { public static final String STR

[jira] [Resolved] (KAFKA-18936) Share fetch stuck when records are larger than fetch max bytes

2025-03-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18936. --- Resolution: Fixed > Share fetch stuck when records are larger than fetch max bytes > ---

Re: [PR] MINOR: call the serialize method including headers from the MockProducer [kafka]

2025-03-12 Thread via GitHub
gklijs commented on PR #11144: URL: https://github.com/apache/kafka/pull/11144#issuecomment-2718126895 @divijvaidya not sure if something needs to be done anymore besides merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] KAFKA-18760: Deprecate Optional and return String from public EndPoint#listenerName (wip) [kafka]

2025-03-12 Thread via GitHub
FrankYang0529 opened a new pull request, #19191: URL: https://github.com/apache/kafka/pull/19191 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals,

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991658719 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -82,29 +97,41 @@ public StreamsGroupHeartbeatReques

  1   2   >