frankvicky commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1990791609
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##########
@@ -52,13 +53,17 @@
import java.util.concurrent.atomic.AtomicLong;
import java.util.stream.Stream;
+import static org.apache.kafka.raft.RaftClientTestContext.Builder;
+import static org.apache.kafka.raft.RaftClientTestContext.MockListener;
+import static org.apache.kafka.raft.RaftClientTestContext.RaftProtocol;
Review Comment:
Ok.
Just for memo: `RaftProtocol` will be extracted as a single file. I will
revert `Builder` and `MockListener`
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -516,15 +521,15 @@ public void
testEndQuorumEpochRetriesWhileResigned(boolean withKip853Rpc) throws
}
@ParameterizedTest
- @ValueSource(booleans = { true, false })
- public void testResignWillCompleteFetchPurgatory(boolean withKip853Rpc)
throws Exception {
+ @EnumSource(value = RaftClientTestContext.RaftProtocol.class, names =
{"KIP_595_PROTOCOL", "KIP_853_PROTOCOL"})
Review Comment:
IMHO, I would prefer `RaftProtocol` as a single file.
I will extract it in the next commit.
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -92,25 +97,25 @@ public void testNodeDirectoryId() {
}
@ParameterizedTest
- @ValueSource(booleans = { true, false })
- public void testInitializeSingleMemberQuorum(boolean withKip853Rpc) throws
IOException {
+ @EnumSource(value = RaftProtocol.class, names = {"KIP_595_PROTOCOL",
"KIP_853_PROTOCOL"})
Review Comment:
I think it could be done in a follow-up PR.
If you agree, I will open a ticket to trace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
