adixitconfluent commented on code in PR #19148:
URL: https://github.com/apache/kafka/pull/19148#discussion_r1991101107
##########
server/src/main/java/org/apache/kafka/server/share/ErroneousAndValidPartitionData.java:
##########
@@ -20,47 +20,48 @@
import org.apache.kafka.common.TopicIdPartition;
import org.apache.kafka.common.message.ShareFetchResponseData;
import org.apache.kafka.common.protocol.Errors;
-import org.apache.kafka.common.requests.ShareFetchRequest;
import org.apache.kafka.common.requests.ShareFetchResponse;
+import java.util.ArrayList;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
/**
* Helper class to return the erroneous partitions and valid partition data
*/
public class ErroneousAndValidPartitionData {
private final Map<TopicIdPartition, ShareFetchResponseData.PartitionData>
erroneous;
- private final Map<TopicIdPartition, ShareFetchRequest.SharePartitionData>
validTopicIdPartitions;
+ private final List<TopicIdPartition> validTopicIdPartitions;
public ErroneousAndValidPartitionData(Map<TopicIdPartition,
ShareFetchResponseData.PartitionData> erroneous,
- Map<TopicIdPartition,
ShareFetchRequest.SharePartitionData> validTopicIdPartitions) {
+ List<TopicIdPartition>
validTopicIdPartitions) {
this.erroneous = erroneous;
this.validTopicIdPartitions = validTopicIdPartitions;
}
- public ErroneousAndValidPartitionData(Map<TopicIdPartition,
ShareFetchRequest.SharePartitionData> shareFetchData) {
+ public ErroneousAndValidPartitionData(List<TopicIdPartition>
shareFetchData) {
erroneous = new HashMap<>();
- validTopicIdPartitions = new HashMap<>();
- shareFetchData.forEach((topicIdPartition, sharePartitionData) -> {
+ validTopicIdPartitions = new ArrayList<>();
+ shareFetchData.forEach(topicIdPartition -> {
if (topicIdPartition.topic() == null) {
erroneous.put(topicIdPartition,
ShareFetchResponse.partitionResponse(topicIdPartition,
Errors.UNKNOWN_TOPIC_ID));
Review Comment:
If we are unable to resolve a topic name using its topic id, we give out
this error. IIRC, there is a `MetadataCache` object through which we get
`topicIdsToNames` map. We check it from there if the topic id exists.
You can find similar code in the handling of regular fetch request
[here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L557)
and
[here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L574).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
