[jira] [Created] (KAFKA-18959) increse the num_workers from 9 to 12

2025-03-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18959: -- Summary: increse the num_workers from 9 to 12 Key: KAFKA-18959 URL: https://issues.apache.org/jira/browse/KAFKA-18959 Project: Kafka Issue Type: Improvem

[jira] [Updated] (KAFKA-18673) Provide means to gracefully update Producer transational id mapping state in case of lasting inactivity

2025-03-11 Thread Danil Shkodin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Shkodin updated KAFKA-18673: -- Description: Consider adding some method of preventing a transactional _Producer_ instance fr

[jira] [Assigned] (KAFKA-16616) refactor mergeWith in MetadataSnapshot

2025-03-11 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-16616: -- Assignee: Lorcan > refactor mergeWith in MetadataSnapshot > -- >

[jira] [Commented] (KAFKA-18959) increse the num_workers from 9 to 12

2025-03-11 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934130#comment-17934130 ] HongYi Chen commented on KAFKA-18959: - Hi, [~chia7712]  Thank you for opening this

[jira] [Commented] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934153#comment-17934153 ] Bruno Cadonna commented on KAFKA-18913: --- [~janchilling], since I mainly worked on

Re: [PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
cadonna commented on PR #19185: URL: https://github.com/apache/kafka/pull/19185#issuecomment-2714130497 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
cadonna commented on code in PR #19185: URL: https://github.com/apache/kafka/pull/19185#discussion_r1989218050 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1473,13 +1475,15 @@ private void closeTaskDirty(final Task task, final b

[jira] [Commented] (KAFKA-15035) Consumer offsets can be deleted if kafka does not detect a consumer as empty

2025-03-11 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934211#comment-17934211 ] zhangzhisheng commented on KAFKA-15035: --- We have also encountered this problem in

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-11 Thread via GitHub
mimaison commented on PR #19030: URL: https://github.com/apache/kafka/pull/19030#issuecomment-2714174251 I ran a few benchmarks on my laptop. For both trunk and my branch I ran a single broker in combined mode with all default settings. All topics have a single partition with all default se

Re: [PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
cadonna merged PR #19185: URL: https://github.com/apache/kafka/pull/19185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates [kafka]

2025-03-11 Thread via GitHub
appchemist commented on PR #15647: URL: https://github.com/apache/kafka/pull/15647#issuecomment-2714227916 Hi @kirktrue Are there any areas that need more work? I know it's been deferred to version 4.0 for now. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-11 Thread via GitHub
bbejeck commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1989432206 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -82,29 +97,41 @@ public StreamsGroupHeartbeatReques

Re: [PR] KAFKA-18924 Running the storage module tests produces a storage/storage.log file [kafka]

2025-03-11 Thread via GitHub
m1a2st commented on PR #19147: URL: https://github.com/apache/kafka/pull/19147#issuecomment-2714896794 use `./gradlew clean :storage:test` on my local machine ![image](https://github.com/user-attachments/assets/58ccd48d-541d-4fff-a80f-e9b4b579ac63) -- This is an automated message f

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-11 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1989645469 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-11 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1987597807 ## committer-tools/reviewers.py: ## @@ -35,6 +37,30 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): R

Re: [PR] MINOR:Add documentation to describe default quotas for user and client-id. [kafka]

2025-03-11 Thread via GitHub
chia7712 merged PR #19184: URL: https://github.com/apache/kafka/pull/19184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18956) Enable junit tests to optionally use more than one KRaft controller

2025-03-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934256#comment-17934256 ] Chia-Ping Tsai commented on KAFKA-18956: [~kevinwu2412] excuse me, IIRC, our new

[PR] Add a SelectorProvider that reuses custom provider implementations. [kafka]

2025-03-11 Thread via GitHub
DimitarMilushev opened a new pull request, #19186: URL: https://github.com/apache/kafka/pull/19186 ### Tasks: - [x] Add a custom [SelectorProvider](clients/src/main/java/org/apache/kafka/common/network/SelectorProvider.java). - [x] Update [Selector](clients/src/main/java/org/apache/ka

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-11 Thread via GitHub
brandboat commented on code in PR #19159: URL: https://github.com/apache/kafka/pull/19159#discussion_r1987551464 ## .github/scripts/pr-format.py: ## @@ -105,50 +112,55 @@ def parse_trailers(title, body) -> Dict: body = gh_json["body"] reviews = gh_json["reviews"] -

[PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-11 Thread via GitHub
clarkwtc opened a new pull request, #19187: URL: https://github.com/apache/kafka/pull/19187 Follow-up: https://github.com/apache/kafka/pull/19094 We need to rewrite `AdminClientRebootstrapTest` to cover the current scenario. Added the admin client with rebootstrap disabled, as the

[jira] [Commented] (KAFKA-15079) Offset expirations in topics with less event generation results in messages that take months to be delivered.

2025-03-11 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934217#comment-17934217 ] zhangzhisheng commented on KAFKA-15079: --- We have also encountered this problem in

[jira] [Commented] (KAFKA-15154) Potential bug: We don't acquire lock when reading checkQuotas

2025-03-11 Thread Abhinav Agrawal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934224#comment-17934224 ] Abhinav Agrawal commented on KAFKA-15154: - [~divijvaidya] I would like to take u

Re: [PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
cadonna commented on code in PR #19185: URL: https://github.com/apache/kafka/pull/19185#discussion_r1989312994 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1473,13 +1475,15 @@ private void closeTaskDirty(final Task task, final b

[jira] [Updated] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-18913: -- Description: We did enable the new StateUpdated thread with 3.8 release. We should consider r

[jira] [Created] (KAFKA-18961) Consider time-based refresh for server-side RE2J regex

2025-03-11 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18961: -- Summary: Consider time-based refresh for server-side RE2J regex Key: KAFKA-18961 URL: https://issues.apache.org/jira/browse/KAFKA-18961 Project: Kafka Is

Re: [PR] MINOR Mark Tls13SelectorTest#testCloseOldestConnection as flaky [kafka]

2025-03-11 Thread via GitHub
mumrah commented on code in PR #19178: URL: https://github.com/apache/kafka/pull/19178#discussion_r1989416057 ## clients/src/test/java/org/apache/kafka/common/network/Tls13SelectorTest.java: ## @@ -46,6 +48,20 @@ protected Map createSslClientConfigs(File trustStoreFile) throws

Re: [PR] MINOR Mark Tls13SelectorTest#testCloseOldestConnection as flaky [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on code in PR #19178: URL: https://github.com/apache/kafka/pull/19178#discussion_r1989416844 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -83,7 +83,7 @@ public class SelectorTest { protected static final int BUFFER_SI

Re: [PR] [KAFKA-18941] Removes unneeded tests from upgrade_tests.py [kafka]

2025-03-11 Thread via GitHub
josefk31 commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2711302461 @chia7712 My apologies, I think I linked to the wrong issue, here is the correct one: https://issues.apache.org/jira/browse/KAFKA-18442 Issue is as follows: `3.3.2` expects a

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-11 Thread via GitHub
TaiJuWu commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1988917953 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -102,12 +103,12 @@ public class QuorumConfig { public static final ConfigDef CONFIG_DEF = new

[jira] [Commented] (KAFKA-18788) Improve simple assignor by having a max no. of partitions limit and min no. of partitions threshold assignment to members

2025-03-11 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934195#comment-17934195 ] Abhinav Dixit commented on KAFKA-18788: --- This issue is being tackled as part of is

[jira] [Resolved] (KAFKA-18788) Improve simple assignor by having a max no. of partitions limit and min no. of partitions threshold assignment to members

2025-03-11 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-18788. --- Resolution: Duplicate > Improve simple assignor by having a max no. of partitions limit and

[jira] [Commented] (KAFKA-14777) Add support of topic id for OffsetCommitRequests in CommitRequestManager

2025-03-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934223#comment-17934223 ] Lianet Magrans commented on KAFKA-14777: Hello [~adupriez] , this looks like a d

[jira] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2025-03-11 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074 ] zhangzhisheng deleted comment on KAFKA-15074: --- was (Author: zhangzs): We have also encountered this problem in the production environment, and the specific manifestation is that some group

Re: [PR] KAFKA-18924 Running the storage module tests produces a storage/storage.log file [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on code in PR #19147: URL: https://github.com/apache/kafka/pull/19147#discussion_r1989264220 ## storage/src/test/resources/log4j2.yaml: ## @@ -28,8 +28,8 @@ Configuration: pattern: "${logPattern}" RollingFile: - name: FileAppender -

Re: [PR] KAFKA-18941: Do not test 3.3 in upgrade_tests.py [kafka]

2025-03-11 Thread via GitHub
josefk31 commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2714702941 @TaiJuWu That is very odd; I tested this on confluents infrastructure which is where the failure stems from... Since the same bits of `3.3.2` are being tested, I assumed that the failure

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-11 Thread via GitHub
Parkerhiphop commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2714717862 @chia7712 Thanks for the suggestion! I’ve updated it to print more information.c -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
cadonna opened a new pull request, #19185: URL: https://github.com/apache/kafka/pull/19185 Exceptions that are caught during closing a task dirty are swallowed. The corresponding log messages are on error level which is misleading since the exceptions do not cause any special handling or cr

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-11 Thread via GitHub
showuon merged PR #19172: URL: https://github.com/apache/kafka/pull/19172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Assigned] (KAFKA-18959) increse the num_workers from 9 to 12

2025-03-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18959: -- Assignee: HongYi Chen (was: Chia-Ping Tsai) > increse the num_workers from 9 to 12 >

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-11 Thread via GitHub
TaiJuWu commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1988914837 ## raft/src/test/java/org/apache/kafka/raft/QuorumConfigTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-11 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1988857062 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1994,287 @@ private List fromShareGroupAssi

Re: [PR] MINOR Mark Tls13SelectorTest#testCloseOldestConnection as flaky [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on code in PR #19178: URL: https://github.com/apache/kafka/pull/19178#discussion_r1989050924 ## clients/src/test/java/org/apache/kafka/common/network/Tls13SelectorTest.java: ## @@ -46,6 +48,20 @@ protected Map createSslClientConfigs(File trustStoreFile) throw

[jira] [Commented] (KAFKA-18960) the default type of ssh key used by vagrant is disabled by OpenSSH 8.8

2025-03-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934183#comment-17934183 ] Chia-Ping Tsai commented on KAFKA-18960: we can update the ubuntu version used b

[jira] [Commented] (KAFKA-18960) the default type of ssh key used by vagrant is disabled by OpenSSH 8.8

2025-03-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934184#comment-17934184 ] Chia-Ping Tsai commented on KAFKA-18960: Another workaround is we can enhance th

[jira] [Created] (KAFKA-18960) the default type of ssh key used by vagrant is disabled by OpenSSH 8.8

2025-03-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18960: -- Summary: the default type of ssh key used by vagrant is disabled by OpenSSH 8.8 Key: KAFKA-18960 URL: https://issues.apache.org/jira/browse/KAFKA-18960 Project: K

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-11 Thread via GitHub
m1a2st commented on PR #18091: URL: https://github.com/apache/kafka/pull/18091#issuecomment-2713459933 Hello @mjsax, @dajac, Sorry for the late reply. I've been thinking about the relationship between the "Client/Broker Forward Compatibility" matrix and KIP-1124. Since KIP-1124 has alread

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-11 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1988805188 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,280 @@ private List fromShareGroupAssi

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-11 Thread via GitHub
m1a2st commented on code in PR #19159: URL: https://github.com/apache/kafka/pull/19159#discussion_r1987609521 ## .github/scripts/pr-format.py: ## @@ -105,50 +112,55 @@ def parse_trailers(title, body) -> Dict: body = gh_json["body"] reviews = gh_json["reviews"] -w

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-11 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1988844236 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1994,287 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-11 Thread via GitHub
mingyen066 commented on PR #19169: URL: https://github.com/apache/kafka/pull/19169#issuecomment-2713769825 > @mingyen066 could you please also enhance the docs of "--snapshot"? yeah sure, let me take some time to better understand the tool -- This is an automated message from the Ap

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-11 Thread via GitHub
jeqo commented on code in PR #15241: URL: https://github.com/apache/kafka/pull/15241#discussion_r1988994745 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java: ## @@ -238,35 +207,137 @@ private Iterable iterable(Supplier allocate)

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-11 Thread via GitHub
AndrewJSchofield merged PR #19142: URL: https://github.com/apache/kafka/pull/19142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2713789344 @mjsax thanks for running those e2e. We will check them later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HOTFIX remove protected_branches from asf.yaml [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on PR #19182: URL: https://github.com/apache/kafka/pull/19182#issuecomment-2713782362 > The new parser seems not to support the null "~" thing according to https://github.com/apache/infrastructure-asfyaml, it seems `protected_branches: ~` is valid. ``` To comp

[jira] [Assigned] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-03-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18796: Assignee: Chirag Wadhwa (was: Abhinav Dixit) > Fix flaky test testAcquisitionLoc

[jira] [Assigned] (KAFKA-18960) the default type of ssh key used by vagrant is disabled by OpenSSH 8.8

2025-03-11 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HongYi Chen reassigned KAFKA-18960: --- Assignee: HongYi Chen (was: Chia-Ping Tsai) > the default type of ssh key used by vagrant

[jira] [Updated] (KAFKA-18932) Remove partition max bytes usage from share fetch requests

2025-03-11 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-18932: -- Summary: Remove partition max bytes usage from share fetch requests (was: Remove partition ma

[jira] [Comment Edited] (KAFKA-15035) Consumer offsets can be deleted if kafka does not detect a consumer as empty

2025-03-11 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934211#comment-17934211 ] zhangzhisheng edited comment on KAFKA-15035 at 3/11/25 1:24 PM: --

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-11 Thread via GitHub
mumrah commented on code in PR #19159: URL: https://github.com/apache/kafka/pull/19159#discussion_r1987918800 ## .github/scripts/pr-format.py: ## @@ -105,50 +112,55 @@ def parse_trailers(title, body) -> Dict: body = gh_json["body"] reviews = gh_json["reviews"] -w

[PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-11 Thread via GitHub
showuon opened a new pull request, #19172: URL: https://github.com/apache/kafka/pull/19172 In "Upgrading to 4.0.0 from any version 0.8.x through 3.9.x" section, we directly give instructions about [Upgrading to KRaft-based clusters](https://kafka.apache.org/documentation/#upgrade_390_kraft

Re: [PR] MINOR: fix: add missing @Test lost while rebasing [kafka]

2025-03-11 Thread via GitHub
chia7712 merged PR #19149: URL: https://github.com/apache/kafka/pull/19149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR remove legacy branch protections from asf.yaml [kafka]

2025-03-11 Thread via GitHub
mumrah merged PR #19152: URL: https://github.com/apache/kafka/pull/19152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-11 Thread via GitHub
frankvicky commented on code in PR #19159: URL: https://github.com/apache/kafka/pull/19159#discussion_r1987554212 ## .github/scripts/pr-format.py: ## @@ -105,50 +112,55 @@ def parse_trailers(title, body) -> Dict: body = gh_json["body"] reviews = gh_json["reviews"] -

[jira] [Created] (KAFKA-18955) MetadataSchemaCheckerTool bug fixes

2025-03-11 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18955: Summary: MetadataSchemaCheckerTool bug fixes Key: KAFKA-18955 URL: https://issues.apache.org/jira/browse/KAFKA-18955 Project: Kafka Issue Type: Bug Affec

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-11 Thread via GitHub
showuon commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1986603287 ## docs/upgrade.html: ## @@ -64,7 +70,7 @@ Notable changes in 4 Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, brok

Re: [PR] MINOR: fix: add missing @Test lost while rebasing [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on PR #19149: URL: https://github.com/apache/kafka/pull/19149#issuecomment-2710758984 https://issues.apache.org/jira/browse/KAFKA-15900 https://issues.apache.org/jira/browse/KAFKA-18952 the failed tests are traced by above tickets -- This is an automated messa

[jira] [Updated] (KAFKA-18927) Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0

2025-03-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18927: --- Fix Version/s: 4.1.0 > Remove LATEST_0_11, LATEST_1_0, LATEST_1_1,LATEST_2_0 > -

[jira] [Resolved] (KAFKA-18931) Debug the case where kafka-share-groups.sh --describe --members does not match with the reality when share consumer is closed during broker outage

2025-03-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18931. -- Fix Version/s: 4.1.0 Resolution: Fixed > Debug the case where kafka-share-group

Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-11 Thread via GitHub
mumrah closed pull request #18697: KAFKA-18933 Extract an interface from ClusterInstance URL: https://github.com/apache/kafka/pull/18697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-18953) Add broker side handling for 2PC

2025-03-11 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-18953: Summary: Add broker side handling for 2PC Key: KAFKA-18953 URL: https://issues.apache.org/jira/browse/KAFKA-18953 Project: Kafka Issue Type: Sub-task

[PR] MINOR:correct user reference in quota configuration from 'userA' to 'user1' [kafka]

2025-03-11 Thread via GitHub
Rancho-7 opened a new pull request, #19140: URL: https://github.com/apache/kafka/pull/19140 As title. It should be 'user1' not 'userA'. https://github.com/user-attachments/assets/07996442-1ebc-481a-8e6b-9cbb38b13485"; /> -- This is an automated message from the Apache Gi

[jira] [Created] (KAFKA-18954) Add a metric to track the election based on ELR

2025-03-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-18954: -- Summary: Add a metric to track the election based on ELR Key: KAFKA-18954 URL: https://issues.apache.org/jira/browse/KAFKA-18954 Project: Kafka Issue Type: Sub-t

Re: [PR] KAFKA-18046; High CPU usage when using Log4j2 [kafka]

2025-03-11 Thread via GitHub
dajac merged PR #19138: URL: https://github.com/apache/kafka/pull/19138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Improve Debugging and Logging in testElectPreferredLeaders [kafka]

2025-03-11 Thread via GitHub
github-actions[bot] closed pull request #17677: MINOR: Improve Debugging and Logging in testElectPreferredLeaders URL: https://github.com/apache/kafka/pull/17677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-11 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1987602902 ## committer-tools/reviewers.py: ## @@ -35,6 +37,30 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): +

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-11 Thread via GitHub
mumrah merged PR #19159: URL: https://github.com/apache/kafka/pull/19159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18613: Add describeStreamsGroup to Admin API [kafka]

2025-03-11 Thread via GitHub
lucasbru commented on code in PR #19116: URL: https://github.com/apache/kafka/pull/19116#discussion_r1983469822 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeStreamsGroupsResult.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] MINOR: Revert migrate LogFetchInfo, Assignment and RequestAndCompletionHandler to java record [kafka]

2025-03-11 Thread via GitHub
mingyen066 opened a new pull request, #19177: URL: https://github.com/apache/kafka/pull/19177 As discussed in https://github.com/apache/kafka/pull/19062#issuecomment-2709637352 If a class has mutable fields, we shouldn't migrate it to Java record because record assume all fields are

Re: [PR] KAFKA-18929: Log a warning when time based segment delete is blocked by a future timestamp [kafka]

2025-03-11 Thread via GitHub
viktorsomogyi commented on code in PR #19137: URL: https://github.com/apache/kafka/pull/19137#discussion_r1983354737 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1522,6 +1522,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, val startMs = time.milliseco

[PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-11 Thread via GitHub
Parkerhiphop opened a new pull request, #19134: URL: https://github.com/apache/kafka/pull/19134 Revert the following commits: https://github.com/apache/kafka/commit/2ee7e4d22c942045b960540918edc4960629a8a2 https://github.com/apache/kafka/commit/d1952e854202c574c1c19a48b17cc00e9d2eccd5

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-11 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986736109 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -427,29 +426,20 @@ private CompletableFuture shareFetchData, +public ShareFetchCo

Re: [PR] MINOR Fixup develocity report [kafka]

2025-03-11 Thread via GitHub
mumrah commented on PR #19179: URL: https://github.com/apache/kafka/pull/19179#issuecomment-2711641460 Here is the report it generated for me just now (locally) https://gist.github.com/mumrah/233f7221a05832328f04dc71e3611884 -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-11 Thread via GitHub
m1a2st commented on code in PR #18091: URL: https://github.com/apache/kafka/pull/18091#discussion_r1987411819 ## docs/compatibility.html: ## @@ -0,0 +1,225 @@ + + + + + + +Compatibility +With the release of Kafka 4.0, significant changes have been introduced

[jira] [Commented] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-11 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933727#comment-17933727 ] Rameshkanna N commented on KAFKA-18938: --- Hi [~yangpoan] , I am getting the same ex

[jira] [Updated] (KAFKA-18930) KRaft MigrationEvent won't retry when failing to write data to ZK

2025-03-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-18930: -- Description: When running ZK migrating to KRaft, there will be a dual-write mode. In that mode, metad

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-11 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986994843 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -258,14 +257,14 @@ public CompletableFuture> fetchMessages( FetchParams fetc

Re: [PR] KAFKA-18915: Migrate AdminClientRebootstrapTest to use new test infra [kafka]

2025-03-11 Thread via GitHub
clarkwtc commented on code in PR #19094: URL: https://github.com/apache/kafka/pull/19094#discussion_r1983331810 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -84,7 +85,8 @@ public void testRebootstrap(ClusterInstance clusterInstance) throws Executi

Re: [PR] HOTFIX remove protected_branches from asf.yaml [kafka]

2025-03-11 Thread via GitHub
mumrah commented on PR #19182: URL: https://github.com/apache/kafka/pull/19182#issuecomment-2714588967 I've been chatting with them in `#asfinfra` https://infra.apache.org/slack.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] MINOR: Fix minor issues in ops doc [kafka]

2025-03-11 Thread via GitHub
MahsaSeifikar commented on PR #19158: URL: https://github.com/apache/kafka/pull/19158#issuecomment-2714402464 I opened this [PR](https://github.com/apache/kafka-site/pull/667) in kafka-site repository -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-11 Thread via GitHub
m1a2st commented on code in PR #18091: URL: https://github.com/apache/kafka/pull/18091#discussion_r1989425716 ## docs/compatibility.html: ## @@ -0,0 +1,225 @@ + + + + + + +Compatibility +With the release of Kafka 4.0, significant changes have been introduced

Re: [PR] HOTFIX remove protected_branches from asf.yaml [kafka]

2025-03-11 Thread via GitHub
mumrah commented on PR #19182: URL: https://github.com/apache/kafka/pull/19182#issuecomment-2714536101 We are using the "next gen" .asf.yaml parser which has had a few bugs. I think this (lack of support for `~`) was one of them. I'm waiting to hear back from Infra if this change is needed

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2714539239 @Parkerhiphop could you please add some changes to print more information? ``` def is_version(node, version_list, proc_grep_string="kafka", logger=None): """Heuristic to check

[jira] [Comment Edited] (KAFKA-18956) Enable junit tests to optionally use more than one KRaft controller

2025-03-11 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934264#comment-17934264 ] Kevin Wu edited comment on KAFKA-18956 at 3/11/25 4:13 PM: --- Hi

Re: [PR] KAFKA-18915: Migrate AdminClientRebootstrapTest to use new test infra [kafka]

2025-03-11 Thread via GitHub
clarkwtc commented on code in PR #19094: URL: https://github.com/apache/kafka/pull/19094#discussion_r1989660240 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (KAFKA-18956) Enable junit tests to optionally use more than one KRaft controller

2025-03-11 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934264#comment-17934264 ] Kevin Wu commented on KAFKA-18956: -- The ask is to have the junit tests that rely on `Qu

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-11 Thread via GitHub
soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1989669227 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] KAFKA-18915: Migrate AdminClientRebootstrapTest to use new test infra [kafka]

2025-03-11 Thread via GitHub
clarkwtc commented on code in PR #19094: URL: https://github.com/apache/kafka/pull/19094#discussion_r1989679560 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Created] (KAFKA-18957) Impossible to recover hanging transactions in Kafka 3.9 in KRaft mode using EOS

2025-03-11 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-18957: -- Summary: Impossible to recover hanging transactions in Kafka 3.9 in KRaft mode using EOS Key: KAFKA-18957 URL: https://issues.apache.org/jira/browse/KAFKA-18957 P

Re: [PR] MINOR: Downgrade log messages of swallowed exception to warnings [kafka]

2025-03-11 Thread via GitHub
bbejeck commented on code in PR #19185: URL: https://github.com/apache/kafka/pull/19185#discussion_r1989282679 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1473,13 +1475,15 @@ private void closeTaskDirty(final Task task, final b

Re: [PR] KAFKA-18925: Add streams groups support to Admin.listGroups [kafka]

2025-03-11 Thread via GitHub
lucasbru merged PR #19155: URL: https://github.com/apache/kafka/pull/19155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   3   >