[
https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934153#comment-17934153
]
Bruno Cadonna commented on KAFKA-18913:
---------------------------------------
[~janchilling],
since I mainly worked on the state updater, I will give you an overview.
First of all, if you want to know more about the state updater, you can have a
look into the slides this talk:
https://www.slideshare.net/slideshow/restoring-restorations-reputation-in-kafka-streams-with-bruno-cadonna-lucas-brutschy/258205394
or watch the recordings of the talk:
https://www.confluent.io/events/kafka-summit-london-2023/restoring-restorations-reputation-in-kafka-streams/.
I added more details to the description of this ticket. Basically, you need to
find the usages of the internal feature flag {{__state.updater.enabled__}} and
remove the code that is guarded by its negation. An example is provided in the
description of the ticket. Of course in the end, you also need to remove the
internal feature flag itself. Additionally, you also need to get rid of the
tests that verify the old code.
Hope that helps, otherwise let me know.
> Consider removing state-updater feature flag
> --------------------------------------------
>
> Key: KAFKA-18913
> URL: https://issues.apache.org/jira/browse/KAFKA-18913
> Project: Kafka
> Issue Type: Task
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Janindu Pathirana
> Priority: Blocker
> Fix For: 4.1.0
>
>
> We did enable the new StateUpdated thread with 3.8 release.
> We should consider removing the internal feature flag
> {{__state.updater.enabled__}}, and drop the old code that restores state
> stores in the poll loop by the stream thread.
> The entry point of the old restoration code is the following:
> https://github.com/apache/kafka/blob/138c2a211ad90e3966b01b99c4570df50ec48ea2/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L1100
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
