dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1989645469
########## docs/upgrade.html: ########## @@ -19,6 +19,10 @@ <script id="upgrade-template" type="text/x-handlebars-template"> +<h4><a id="client_upgrade_4" href="#client_upgrade_4">Kafka Client upgrade path for 4.x</a></h4> Review Comment: This new section feels a bit weird because all the other section are per version. @ijuma and I discussed offline and we suggest to follow the same pattern for clients. Basically, we could have the following: ``` <h4><a id="upgrade_4_1_0" href="#upgrade_4_1_0">Upgrading Servers to 4.1.0 from any version 3.3.x through 4.0.x</a></h4> <h4><a id="upgrade_4_1_0" href="#upgrade_clients_4_1_0">Upgrading Clients to 4.1.0</a></h4> <h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from any version 3.3.x through 3.9.x</a></h4> Here we keep the current content. <h4><a id="upgrade_4_0_0" href="#upgrade_clients_4_0_0">Upgrading Clients to 4.0.0 </a></h4> Here we adds bit about rolling upgrade clients, similarly to what we have for the servers. Moreover, we add a not about the upgrade path and link the KIP. ``` We could follow this pattern for next releases. In the future, we could also consider moving the notable changes related to the clients to the clients section but this is not necessary for 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
