[PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-03-09 Thread via GitHub
frankvicky opened a new pull request, #19167: URL: https://github.com/apache/kafka/pull/19167 JIRA: KAFKA-18935 This patch ensures the broker will not return null records in FetchResponse. For more details, please refer to the ticket. -- This is an automated message from

Re: [PR] KAFKA-18944: Remove unused setters from ClusterConfig [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #19166: URL: https://github.com/apache/kafka/pull/19166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-18942) Add reviewers to PR body with committer-tools

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18942: --- Fix Version/s: 4.1.0 > Add reviewers to PR body with committer-tools > -

[PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
mingyen066 opened a new pull request, #19168: URL: https://github.com/apache/kafka/pull/19168 Enhance `reviewers.py` to append reviewer message to the PR body. Add a comfirmation propmt to prevent human errors. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-09 Thread via GitHub
TaiJuWu commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2708878915 > > If the request number exceeds maxInFlightRequestsPerConnection, the LeaveGroup request would be not sent in time when closing. > > why does it exceed the `maxInFlightRequestsPer

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1986334149 ## committer-tools/reviewers.py: ## @@ -35,6 +37,31 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): +

[jira] [Commented] (KAFKA-18947) refactor MetadataShell

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933639#comment-17933639 ] Chia-Ping Tsai commented on KAFKA-18947: {code:java} chia7712@chia7712-ubuntu:~/

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2708891288 @TaiJuWu thanks for your sharing. Do you know why consumer sends join-group and sync-group request before receiving response of FindCoordinatorRequestData? for another, is it flaky on cl

[jira] [Resolved] (KAFKA-18420) Find out the license which is in the license file but is not in distribution

2025-03-09 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangning.li resolved KAFKA-18420. - Resolution: Duplicate > Find out the license which is in the license file but is not in distribu

Re: [PR] MINOR:correct user reference in quota configuration from 'userA' to 'user1' [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #19140: URL: https://github.com/apache/kafka/pull/19140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19069: URL: https://github.com/apache/kafka/pull/19069#discussion_r1986355627 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -437,14 +436,14 @@ private void checkSection( /** * The se

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19071: URL: https://github.com/apache/kafka/pull/19071#issuecomment-2708926789 @clarkwtc #17767 introduces another similar issue. could you please it in this PR as well? ``` > Task :tools:compileTestJava Note: /home/chia7712/project/kafka/tools/src/test/ja

[jira] [Resolved] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-09 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18845. --- Resolution: Fixed > Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled > ---

[jira] [Updated] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-09 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18845: -- Attachment: Screenshot 2025-03-09 at 11.46.53 PM.png > Fail test QuorumControllerTest#testUncleanShutd

Re: [PR] KAFKA-10863: Convert ControRecordType schema to use auto-generated protocol [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19110: URL: https://github.com/apache/kafka/pull/19110#discussion_r1986358115 ## clients/src/main/resources/common/message/ControlRecordType.json: ## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// con

Re: [PR] MINOR KIP link change to use immutable link [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #19153: URL: https://github.com/apache/kafka/pull/19153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-18946) Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18946: --- Summary: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module (

[jira] [Created] (KAFKA-18948) Move DynamicLogConfig to server module

2025-03-09 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-18948: --- Summary: Move DynamicLogConfig to server module Key: KAFKA-18948 URL: https://issues.apache.org/jira/browse/KAFKA-18948 Project: Kafka Issue Type: Sub-task

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-09 Thread via GitHub
sjhajharia commented on PR #19069: URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708939212 Thanks @chia7712 for looking into the PR. I have addressed the comments. PTAL when possible! -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-18003: add test to make sure `Admin#deleteRecords` can handle the corrupted records [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #17840: URL: https://github.com/apache/kafka/pull/17840#discussion_r1986365438 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1543,6 +1547,76 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

[jira] [Commented] (KAFKA-18949) fix testDeleteRecordsAfterCorruptRecords for consumer protocol

2025-03-09 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933648#comment-17933648 ] PoAn Yang commented on KAFKA-18949: --- Hi [~chia7712], if you're not working on this, ma

[jira] [Created] (KAFKA-18949) fix testDeleteRecordsAfterCorruptRecords for consumer protocol

2025-03-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18949: -- Summary: fix testDeleteRecordsAfterCorruptRecords for consumer protocol Key: KAFKA-18949 URL: https://issues.apache.org/jira/browse/KAFKA-18949 Project: Kafka

[jira] [Assigned] (KAFKA-18949) fix testDeleteRecordsAfterCorruptRecords for consumer protocol

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18949: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > fix testDeleteRecordsAfterCorruptRecords

[jira] [Commented] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-09 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933645#comment-17933645 ] PoAn Yang commented on KAFKA-18845: --- The QuorumControllerTest#testUncleanShutdownBroke

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-09 Thread via GitHub
mimaison commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1986366041 ## raft/src/test/java/org/apache/kafka/raft/QuorumConfigTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[jira] [Created] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs

2025-03-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18945: -- Summary: Enahnce the docs of Admin#describeCluster and Admin#describeConfigs Key: KAFKA-18945 URL: https://issues.apache.org/jira/browse/KAFKA-18945 Project: Kafk

[jira] [Updated] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-controller

2025-03-09 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng updated KAFKA-18945: -- Description: in the [https://github.com/apache/kafka/pull/19100|https://github.com/apache/kaf

[jira] [Commented] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-controller

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933623#comment-17933623 ] Chia-Ping Tsai commented on KAFKA-18945: # the cluster returned by describeClust

[jira] [Assigned] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-controller

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18945: -- Assignee: Kuan Po Tseng (was: Chia-Ping Tsai) > Enahnce the docs of Admin#describeCl

[jira] [Updated] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-controller

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18945: --- Summary: Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-c

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-09 Thread via GitHub
junrao commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1983832557 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finali

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1986329085 ## committer-tools/reviewers.py: ## @@ -35,6 +37,31 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): +

[jira] [Commented] (KAFKA-18945) Enahnce the docs of Admin#describeCluster and Admin#describeConfigs for bootstrap-controller

2025-03-09 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933621#comment-17933621 ] Kuan Po Tseng commented on KAFKA-18945: --- Hi [~chia7712], may I take over this issu

Re: [PR] KAFKA-18909: Move DynamicThreadPool to server module [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19081: URL: https://github.com/apache/kafka/pull/19081#issuecomment-2708761638 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-18606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-18909) Move DynamicThreadPool to server module

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18909. Fix Version/s: 4.1.0 Resolution: Fixed > Move DynamicThreadPool to server module >

Re: [PR] KAFKA-18909: Move DynamicThreadPool to server module [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #19081: URL: https://github.com/apache/kafka/pull/19081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18944) Remove unused setters from ClusterConfig

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18944. Fix Version/s: 4.1.0 Resolution: Fixed > Remove unused setters from ClusterConfig >

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2708850790 > If the request number exceeds maxInFlightRequestsPerConnection, the LeaveGroup request would be not sent in time when closing. why does it exceed the `maxInFlightRequestsPerConne

[jira] [Assigned] (KAFKA-18946) Move DynamicLogConfig, BrokerReconfigurable, and DynamicProducerStateManagerConfig to server module

2025-03-09 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18946: --- Assignee: TengYao Chi (was: Chia-Ping Tsai) > Move DynamicLogConfig, BrokerReconfigurable,

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19168: URL: https://github.com/apache/kafka/pull/19168#issuecomment-2708854016 @mingyen066 could you please take a look at following error? ``` chia7712@chia7712-ubuntu:~/project/kafka$ ./committer-tools/reviewers.py /home/chia7712/project/kafka/./committer

Re: [PR] KAFKA-17856 Move ConfigCommandTest and ConfigCommandIntegrationTest to tool module [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #17767: URL: https://github.com/apache/kafka/pull/17767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18946) Move DynamicLogConfig, BrokerReconfigurable, and DynamicProducerStateManagerConfig to server module

2025-03-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18946: -- Summary: Move DynamicLogConfig, BrokerReconfigurable, and DynamicProducerStateManagerConfig to server module Key: KAFKA-18946 URL: https://issues.apache.org/jira/browse/KAFKA-

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
mingyen066 commented on PR #19168: URL: https://github.com/apache/kafka/pull/19168#issuecomment-2708858624 @chia7712 Fixed by adding another escape(two backslash) for python. It's weired that one backslash is working fine in mac. -- This is an automated message from the Apache Git Service

Re: [PR] [KAFKA-18941] Removes unneeded tests from upgrade_tests.py [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2708849438 @josefk31 in #18386 we made the e2e work for the "valid" upgrade path - single folder. Hence, could you please share more details of the description "upgrade test in question is not supp

[jira] [Assigned] (KAFKA-18947) refactor MetadataShell

2025-03-09 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-18947: -- Assignee: Ming-Yen Chung (was: Chia-Ping Tsai) > refactor MetadataShell > --

[jira] [Created] (KAFKA-18947) refactor MetadataShell

2025-03-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18947: -- Summary: refactor MetadataShell Key: KAFKA-18947 URL: https://issues.apache.org/jira/browse/KAFKA-18947 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1986315184 ## committer-tools/reviewers.py: ## @@ -87,9 +112,16 @@ def prompt_for_user(): continue if selected_reviewers: -out = "\n\nReviewers: " -

[jira] [Resolved] (KAFKA-18706) Move AclPublisher to metadata module

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18706. Fix Version/s: 4.1.0 Resolution: Fixed > Move AclPublisher to metadata module > ---

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #18802: URL: https://github.com/apache/kafka/pull/18802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18858: Refactor FeatureControlManager to avoid using uninitialized MV [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19040: URL: https://github.com/apache/kafka/pull/19040#issuecomment-2708841989 @FrankYang0529 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-17856) Move ConfigCommandTest and ConfigCommandIntegrationTest to tool module

2025-03-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17856. Fix Version/s: 4.1.0 Resolution: Fixed > Move ConfigCommandTest and ConfigCommandIn

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-09 Thread via GitHub
snehashisp commented on PR #17988: URL: https://github.com/apache/kafka/pull/17988#issuecomment-2708848557 Hi @gharris1727. Apologies for the delay in getting this PR updated. Please review when you get some time. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-09 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1986320862 ## committer-tools/reviewers.py: ## @@ -87,9 +112,16 @@ def prompt_for_user(): continue if selected_reviewers: -out = "\n\nReviewers: " -

Re: [PR] MINOR KIP link change to use immutable link [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19153: URL: https://github.com/apache/kafka/pull/19153#issuecomment-2708849650 @m1a2st could you please sync code to run CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: Update upgrade steps [kafka]

2025-03-09 Thread via GitHub
dajac merged PR #19132: URL: https://github.com/apache/kafka/pull/19132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-09 Thread Janindu Pathirana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933655#comment-17933655 ] Janindu Pathirana commented on KAFKA-18913: --- Hi [~mjsax] , Would you please b

[PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-09 Thread via GitHub
mingyen066 opened a new pull request, #19169: URL: https://github.com/apache/kafka/pull/19169 * Remove unused `raftManager` in `metadataShell` * Enhance error message when no snapshot provided. * Since `raftManager` is removed, make `snapshot` a required argument. Result when n

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986418726 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -258,14 +257,14 @@ public CompletableFuture> fetchMessages( FetchParams fetch

[jira] [Resolved] (KAFKA-18023) Enforcing Explicit Naming for Kafka Streams Internal Topics (KIP-1111)

2025-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-18023. - Fix Version/s: 4.1.0 Resolution: Fixed > Enforcing Explicit Naming for Kafka Stre

Re: [PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-09 Thread via GitHub
Yunyung commented on code in PR #19169: URL: https://github.com/apache/kafka/pull/19169#discussion_r1986574459 ## shell/src/test/java/org/apache/kafka/shell/MetadataShellIntegrationTest.java: ## @@ -84,9 +84,9 @@ public void close() { @ValueSource(booleans = {false, true})

Re: [PR] MINOR: Fix minor issues in ops doc [kafka]

2025-03-09 Thread via GitHub
MahsaSeifikar closed pull request #19158: MINOR: Fix minor issues in ops doc URL: https://github.com/apache/kafka/pull/19158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (KAFKA-7302) Remove Java7 examples from Streams Docs

2025-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-7302: -- Assignee: (was: Vijay) > Remove Java7 examples from Streams Docs > ---

Re: [PR] MINOR: Fix minor issues in ops doc [kafka]

2025-03-09 Thread via GitHub
MahsaSeifikar commented on PR #19158: URL: https://github.com/apache/kafka/pull/19158#issuecomment-2709166623 Thanks for letting me know! I'll go ahead and close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-09 Thread via GitHub
clarkwtc commented on PR #19071: URL: https://github.com/apache/kafka/pull/19071#issuecomment-2709276660 @chia7712 No problem. I fixed that similar issue. Update the information at the top of the conversation. -- This is an automated message from the Apache Git Service. To respon

[PR] KAFKA-17808: InstanceAlreadyExistsException: kafka.admin.client:type=app-info,id=connector-dlq-adminclient- when add connector with tasks [kafka]

2025-03-09 Thread via GitHub
Yunyung opened a new pull request, #19171: URL: https://github.com/apache/kafka/pull/19171 ## Description Fix id typo for connector-dlq-adminclient. Please see Jira: https://issues.apache.org/jira/browse/KAFKA-17808 ## Verification ### Setup Steps: Moefiy default `config/conn

[jira] [Commented] (KAFKA-17808) InstanceAlreadyExistsException: kafka.admin.client:type=app-info,id=connector-dlq-adminclient- when add connector with tasks

2025-03-09 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933701#comment-17933701 ] Jhen-Yung Hsu commented on KAFKA-17808: --- Since the admin is not exposed, it is har

[jira] [Resolved] (KAFKA-7079) ValueTransformerWithKeySupplier is not mentioned in the documentation

2025-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-7079. Resolution: Won't Fix > ValueTransformerWithKeySupplier is not mentioned in the documentati

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-09 Thread via GitHub
clarkwtc commented on code in PR #19071: URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517381 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java: ## @@ -587,19 +577,16 @@ public void shouldThrowNullPointerOnTransformValuesW

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-09 Thread via GitHub
clarkwtc commented on code in PR #19071: URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517609 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java: ## @@ -587,19 +577,16 @@ public void shouldThrowNullPointerOnTransformValuesW

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-09 Thread via GitHub
clarkwtc commented on code in PR #19071: URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517982 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java: ## @@ -391,24 +386,20 @@ public void testStateStore() { public void shou

Re: [PR] Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19165: URL: https://github.com/apache/kafka/pull/19165#issuecomment-2709273480 @ahuang98 is there a existent jira? if not, could you please add "MINOR:" to the title? thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-09 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986588598 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSession.java: ## @@ -110,25 +109,20 @@ public synchronized LastUsedKey lastUsedKey() {

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-09 Thread via GitHub
showuon commented on PR #19172: URL: https://github.com/apache/kafka/pull/19172#issuecomment-2709433524 @dajac , I think we should merge this PR to v4.0.0, though it's not a blocker for the RC3. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-09 Thread via GitHub
chia7712 merged PR #19141: URL: https://github.com/apache/kafka/pull/19141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19062: URL: https://github.com/apache/kafka/pull/19062#issuecomment-2709553640 > For the classes without hashCode/equals, we are verifying that it's ok to change the implementation of hashCode and equals? Regarding `LogAppendInfo`, `LogFetchInfo`, and `Snapsh

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1986684323 ## docs/upgrade.html: ## @@ -31,6 +31,12 @@ Notable changes in 4 Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +Note: Apache Kafka 4.0 only sup

Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-09 Thread via GitHub
ijuma commented on PR #18697: URL: https://github.com/apache/kafka/pull/18697#issuecomment-2709277315 @mumrah A bit hard to comment without understanding the goal. Is the goal to move client integration tests outside of `core`? -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-09 Thread via GitHub
ijuma commented on PR #19046: URL: https://github.com/apache/kafka/pull/19046#issuecomment-2709290586 We should probably create the clients integration test module before doing these conversions so that the Java classes end up in a Java only module. -- This is an automated message from th

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-09 Thread via GitHub
ijuma commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1986524784 ## build.gradle: ## @@ -1531,15 +1531,15 @@ project(':test-common:test-common-runtime') { } dependencies { -implementation project(':test-common:test-common-i

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-03-09 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2709316719 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-09 Thread via GitHub
Yunyung commented on code in PR #19141: URL: https://github.com/apache/kafka/pull/19141#discussion_r1986550265 ## docs/upgrade.html: ## @@ -385,21 +385,21 @@ Notable changes in 4 See https://cwiki.apache.org/confluence/x/jA3OEg";>KIP-1074 for more details.

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-09 Thread via GitHub
showuon commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1986687663 ## docs/upgrade.html: ## @@ -31,6 +31,12 @@ Notable changes in 4 Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +Note: Apache Kafka 4.0 only supp

Re: [PR] MINOR Improve PR linter output [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19159: URL: https://github.com/apache/kafka/pull/19159#discussion_r1986686393 ## .github/workflows/README.md: ## @@ -122,6 +122,15 @@ structure of the PR Note that the pr-reviewed.yml workflow uses the `ci-approved` mechanism described above.

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1986702996 ## docs/upgrade.html: ## @@ -31,6 +31,12 @@ Notable changes in 4 Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +Note: Apache Kafka 4.0 only sup

[jira] [Created] (KAFKA-18951) Validate client code and documentation in examples/ directory

2025-03-09 Thread Kirk True (Jira)
Kirk True created KAFKA-18951: - Summary: Validate client code and documentation in examples/ directory Key: KAFKA-18951 URL: https://issues.apache.org/jira/browse/KAFKA-18951 Project: Kafka Issu

[jira] [Updated] (KAFKA-18951) Validate client code and documentation in examples/ directory

2025-03-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18951: -- Description: The {{examples/}} directory contains example client code that might be a bit neglected. T

Re: [PR] KAFKA-10863: Convert ControRecordType schema to use auto-generated protocol [kafka]

2025-03-09 Thread via GitHub
dengziming commented on code in PR #19110: URL: https://github.com/apache/kafka/pull/19110#discussion_r1986514556 ## clients/src/main/resources/common/message/ControlRecordType.json: ## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// c

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-09 Thread via GitHub
ijuma commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1986524784 ## build.gradle: ## @@ -1531,15 +1531,15 @@ project(':test-common:test-common-runtime') { } dependencies { -implementation project(':test-common:test-common-i

[jira] [Resolved] (KAFKA-7302) Remove Java7 examples from Streams Docs

2025-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-7302. Fix Version/s: 4.0.0 Resolution: Fixed I believe we did do this cleanup during 4.0.0

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-09 Thread via GitHub
chia7712 commented on PR #19141: URL: https://github.com/apache/kafka/pull/19141#issuecomment-2708923054 @MahsaSeifikar could you please fix the conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Resolved] (KAFKA-8871) Allow timestamp manipulation in ValueTransformerWithKey

2025-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-8871. Resolution: Won't Fix With the new type-safe PAPI (v2) `ValueTransformerWithKey` is going t