Yunyung commented on code in PR #19169:
URL: https://github.com/apache/kafka/pull/19169#discussion_r1986574459
##########
shell/src/test/java/org/apache/kafka/shell/MetadataShellIntegrationTest.java:
##########
@@ -84,9 +84,9 @@ public void close() {
@ValueSource(booleans = {false, true})
public void testLock(boolean canLock) throws Exception {
try (IntegrationEnv env = new IntegrationEnv()) {
- env.shell = new MetadataShell(null,
+ env.shell = new MetadataShell(
new File(new File(env.tempDir, "__cluster_metadata-0"),
"00000000000122906351-0000000226.checkpoint").getAbsolutePath(),
- env.faultHandler);
Review Comment:
The tab should NOT be removed here.
##########
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##########
@@ -292,4 +251,4 @@ void waitUntilCaughtUp() throws InterruptedException {
Thread.sleep(10);
}
}
-}
+}
Review Comment:
Please add a space at the end of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
