ijuma commented on code in PR #19144:
URL: https://github.com/apache/kafka/pull/19144#discussion_r1986524784
##########
build.gradle:
##########
@@ -1531,15 +1531,15 @@ project(':test-common:test-common-runtime') {
}
dependencies {
- implementation project(':test-common:test-common-internal-api')
- implementation project(':clients')
- implementation project(':core')
- implementation project(':group-coordinator')
- implementation project(':metadata')
- implementation project(':raft')
- implementation project(':server')
- implementation project(':server-common')
- implementation project(':storage')
+ api project(':core')
Review Comment:
Is that a good idea though? Generally speaking, we should only declare `api`
if the public classes in this module accept/return apis from the relevant
module. Also, any module that uses classes from a given module should declare a
dependency on that module (versus relying on transitive dependencies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
