Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-03-05 Thread via GitHub
chia7712 merged PR #18918: URL: https://github.com/apache/kafka/pull/18918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-03-05 Thread via GitHub
xijiu commented on PR #18299: URL: https://github.com/apache/kafka/pull/18299#issuecomment-2700736205 @chia7712 Thanks for CR and I have fixed them. There is a small point that when I executed the python script locally, it prompted that I needed to provide parameters. Please take a look

[PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19108: URL: https://github.com/apache/kafka/pull/19108 This PR includes a new flag in VerifiableShareConsumer.java called admin.client.config to include a properties file for admin client related configs Reference: [KAFKA-18811](https://issu

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981276951 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

[jira] [Assigned] (KAFKA-18924) Running the storage module tests produces a storage/storage.log file

2025-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18924: --- Assignee: 黃竣陽 > Running the storage module tests produces a storage/storage.log file >

Re: [PR] MINOR: Refactor GroupCoordinatorConfig [kafka]

2025-03-05 Thread via GitHub
dajac merged PR #19092: URL: https://github.com/apache/kafka/pull/19092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-10864: Convert end txn marker schema to use auto-generated protocol [kafka]

2025-03-05 Thread via GitHub
chia7712 merged PR #9766: URL: https://github.com/apache/kafka/pull/9766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Created] (KAFKA-18924) Running the storage module tests produces a storage/storage.log file

2025-03-05 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18924: -- Summary: Running the storage module tests produces a storage/storage.log file Key: KAFKA-18924 URL: https://issues.apache.org/jira/browse/KAFKA-18924 Project: Kaf

Re: [PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19108: URL: https://github.com/apache/kafka/pull/19108#discussion_r1981287886 ## tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java: ## @@ -562,6 +557,13 @@ private static ArgumentParser argParser() { .met

Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

2025-03-05 Thread via GitHub
dengziming commented on PR #19109: URL: https://github.com/apache/kafka/pull/19109#issuecomment-2700803255 Hello @chia7712 , sorry for my negligence, I accidentally set highest version in all cases, it's influential currently but is a time bomb for future. -- This is an automated message

[jira] [Commented] (KAFKA-17808) InstanceAlreadyExistsException: kafka.admin.client:type=app-info,id=connector-dlq-adminclient- when add connector with tasks

2025-03-05 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932554#comment-17932554 ] Jhen-Yung Hsu commented on KAFKA-17808: --- [~ignat233] Could you provide the steps t

Re: [PR] [MINOR] Cleanup Storage Module [kafka]

2025-03-05 Thread via GitHub
sjhajharia commented on PR #19072: URL: https://github.com/apache/kafka/pull/19072#issuecomment-2700255546 Thanks @m1a2st Seems like I missed it as it looked different. Have fixed the same. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-05 Thread via GitHub
TaiJuWu opened a new pull request, #19105: URL: https://github.com/apache/kafka/pull/19105 Jira: https://issues.apache.org/jira/browse/KAFKA-18031 This test expose an issue: If the request number exceeds `maxInFlightRequestsPerConnection`, the `LeaveGroup` request would be not sent

Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on code in PR #19077: URL: https://github.com/apache/kafka/pull/19077#discussion_r1981043279 ## docs/security.html: ## @@ -1248,11 +1248,15 @@ https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface";>KIP-11 and resourc

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-05 Thread via GitHub
apoorvmittal10 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2700506846 @mumrah Can you please review it as well and help merging then changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981156216 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-05 Thread via GitHub
TaiJuWu commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2700559090 @lianetm Please take a look when you are available, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981166972 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

[PR] MINOR: KAFKA-18876 4.0 docs follow-up [kafka]

2025-03-05 Thread via GitHub
mingdaoy opened a new pull request, #19107: URL: https://github.com/apache/kafka/pull/19107 https://github.com/apache/kafka/pull/19103#issuecomment-2700303106 Fixed the snapshot file format: ![image](https://github.com/user-attachments/assets/7acf4c81-b684-4b1d-9479-1c03096b05a3)

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
chia7712 commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981171909 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $ b

[jira] [Commented] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2025-03-05 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932594#comment-17932594 ] Deng Ziming commented on KAFKA-15371: - [~chia7712] As far as I can see, the .log fil

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
frankvicky commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981192398 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-05 Thread via GitHub
clolov merged PR #18983: URL: https://github.com/apache/kafka/pull/18983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981152506 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

Re: [PR] MINOR: zk2kraft: add more information about kafka-configs.sh [kafka]

2025-03-05 Thread via GitHub
chia7712 commented on code in PR #19100: URL: https://github.com/apache/kafka/pull/19100#discussion_r1981121079 ## docs/zk2kraft.html: ## @@ -153,6 +153,67 @@ Configurations +Dynamic Log Levels + + + +The

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-05 Thread via GitHub
clolov commented on PR #18983: URL: https://github.com/apache/kafka/pull/18983#issuecomment-2700629939 That's a good question, I will merge as-is and reachout to people to hear their opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
frankvicky commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981192398 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $

Re: [PR] KAFKA-18817: ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]

2025-03-05 Thread via GitHub
clolov merged PR #19083: URL: https://github.com/apache/kafka/pull/19083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-05 Thread via GitHub
clolov commented on PR #18983: URL: https://github.com/apache/kafka/pull/18983#issuecomment-2700635940 I will also let you resolve the JIRA appropriately and move the KIP to the correct section + update the Kafka version in which it will be going out! -- This is an automated message from

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
Yunyung commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $ bi

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
Yunyung commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $ bi

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
Yunyung commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $ bi

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981217329 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981225722 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-05 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1981230458 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STR

[jira] [Updated] (KAFKA-16936) Upgrade slf4j to 2.0.9 and integrate "-Dslf4j.provider" to kafka script

2025-03-05 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-16936: Summary: Upgrade slf4j to 2.0.9 and integrate "-Dslf4j.provider" to kafka script (was: Upgrade sl

Re: [PR] KAFKA-18886: add behavior change of CreateTopicPolicy and AlterConfigPolicy to zk2kraft [kafka]

2025-03-05 Thread via GitHub
chia7712 merged PR #19087: URL: https://github.com/apache/kafka/pull/19087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18804) Remove slf4j warning when using tool script.

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18804. Fix Version/s: 4.1.0 Resolution: Fixed > Remove slf4j warning when using tool scrip

[PR] MINOR: transformValues test improvment [kafka]

2025-03-05 Thread via GitHub
lucasbru opened a new pull request, #19106: URL: https://github.com/apache/kafka/pull/19106 Follow-up to 295760d3eb68178eac96ee4211fa75dfdbddfa95. Also check the set of state stores as suggested in reviews. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Resolved] (KAFKA-12903) Replace producer state entry with auto-generated protocol

2025-03-05 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-12903. - Resolution: Duplicate Already fixed in KAFKA-17056 > Replace producer state entry with auto-gen

[jira] [Updated] (KAFKA-18910) Remove kafka.utils.json

2025-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18910: Summary: Remove kafka.utils.json (was: Romve kafka.utils.json ) > Remove kafka.utils.json > ---

Re: [PR] MINOR: transformValues test improvement [kafka]

2025-03-05 Thread via GitHub
cadonna commented on code in PR #19106: URL: https://github.com/apache/kafka/pull/19106#discussion_r1981351538 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableTransformValuesTest.java: ## @@ -410,6 +410,8 @@ public void shouldCalculateCorrectOldValuesI

Re: [PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19108: URL: https://github.com/apache/kafka/pull/19108#discussion_r1981366175 ## tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java: ## @@ -596,18 +599,29 @@ public static VerifiableShareConsumer createFromArgs(Argume

Re: [PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19108: URL: https://github.com/apache/kafka/pull/19108#discussion_r1981368859 ## tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java: ## @@ -562,6 +557,13 @@ private static ArgumentParser argParser() { .met

Re: [PR] KAFKA-18736: Decide when a heartbeat should be sent [kafka]

2025-03-05 Thread via GitHub
cadonna commented on PR #19121: URL: https://github.com/apache/kafka/pull/19121#issuecomment-2701535257 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR Add a required status check for trunk [kafka]

2025-03-05 Thread via GitHub
mumrah commented on code in PR #19122: URL: https://github.com/apache/kafka/pull/19122#discussion_r1981866135 ## .asf.yaml: ## @@ -45,3 +45,19 @@ github: squash_commit_message: PR_TITLE_AND_DESC merge: false rebase: false + + protected_branches: +trunk: +

Re: [PR] MINOR Add a required status check for trunk [kafka]

2025-03-05 Thread via GitHub
jolshan commented on code in PR #19122: URL: https://github.com/apache/kafka/pull/19122#discussion_r1981864951 ## .asf.yaml: ## @@ -45,3 +45,19 @@ github: squash_commit_message: PR_TITLE_AND_DESC merge: false rebase: false + + protected_branches: +trunk: +

Re: [PR] MINOR Add a required status check for trunk [kafka]

2025-03-05 Thread via GitHub
mumrah commented on PR #19122: URL: https://github.com/apache/kafka/pull/19122#issuecomment-2701616024 Here's how Pulsar has their repo configured: https://github.com/apache/pulsar/blob/master/.asf.yaml -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on code in PR #19077: URL: https://github.com/apache/kafka/pull/19077#discussion_r1981867953 ## docs/security.html: ## @@ -1248,11 +1248,16 @@ https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface";>KIP-11 and resourc

Re: [PR] MINOR: zk2kraft: add more information about kafka-configs.sh [kafka]

2025-03-05 Thread via GitHub
cmccabe commented on code in PR #19100: URL: https://github.com/apache/kafka/pull/19100#discussion_r1981929991 ## docs/zk2kraft.html: ## @@ -153,6 +153,67 @@ Configurations +Dynamic Log Levels + + + +The d

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-03-05 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1981925892 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

Re: [PR] MINOR: zk2kraft: add more information about kafka-configs.sh [kafka]

2025-03-05 Thread via GitHub
cmccabe commented on code in PR #19100: URL: https://github.com/apache/kafka/pull/19100#discussion_r1981933910 ## docs/zk2kraft.html: ## @@ -153,6 +153,67 @@ Configurations +Dynamic Log Levels + + + +The d

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum (wip) [kafka]

2025-03-05 Thread via GitHub
jsancio commented on PR #18685: URL: https://github.com/apache/kafka/pull/18685#issuecomment-2701811371 @FrankYang0529 is this still a WIP? I would like to get this fixed and included in the 4.0.0 release. cc @dajac @junrao -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-18920) kafka-feature doesn't report the correct kraft.version

2025-03-05 Thread Mahsa Seifikar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932713#comment-17932713 ] Mahsa Seifikar commented on KAFKA-18920: There is a similar Jira ticket https:/

Re: [PR] KAFKA-18919 Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde [kafka]

2025-03-05 Thread via GitHub
chia7712 merged PR #19104: URL: https://github.com/apache/kafka/pull/19104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-05 Thread via GitHub
lucasbru opened a new pull request, #19114: URL: https://github.com/apache/kafka/pull/19114 Basic streams group heartbeat handling. The main part of are the unit tests that make sure that we behave, for the most part, like a consumer group. - No support for static membership - No s

Re: [PR] MINOR: KAFKA-18876 4.0 docs follow-up (2) [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981577358 ## docs/ops.html: ## @@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the state of the cluster metadata partition: - $ b

Re: [PR] KAFKA-18422: add Kafka client upgrade path [kafka]

2025-03-05 Thread via GitHub
chia7712 commented on code in PR #19097: URL: https://github.com/apache/kafka/pull/19097#discussion_r1981591563 ## docs/upgrade.html: ## @@ -46,6 +46,9 @@ Upgrading to 4.0.0 from any vers Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/

Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]

2025-03-05 Thread via GitHub
Iamoshione commented on PR #19077: URL: https://github.com/apache/kafka/pull/19077#issuecomment-2701402395 ![Screenshot from 2025-03-05 11-07-40](https://github.com/user-attachments/assets/9bfb4c59-2226-48a0-a05a-115e1b2b9dde) Hey @AndrewJSchofield , thank you for acknowledging my PR. I h

[jira] [Updated] (KAFKA-18922) RequestContext#principalSerde should not be optional as it is now always present

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18922: --- Fix Version/s: 4.1.0 > RequestContext#principalSerde should not be optional as it is now alw

Re: [PR] MINOR: KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-05 Thread via GitHub
ijuma commented on PR #19119: URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701424539 I have some thoughts on this, will share them later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-18922) RequestContext#principalSerde should not be optional as it is now always present

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932684#comment-17932684 ] Chia-Ping Tsai commented on KAFKA-18922: According to discussion in KAFKA-18919,

Re: [PR] MINOR: Improve the example of kafka-metadata-shell.sh [kafka]

2025-03-05 Thread via GitHub
m1a2st commented on code in PR #19107: URL: https://github.com/apache/kafka/pull/19107#discussion_r1981739755 ## docs/ops.html: ## @@ -3983,7 +3983,7 @@ - + Note: -00.checkpoint does not contain cluster metadata. Use a valid snapshot file when exam

[jira] [Comment Edited] (KAFKA-18919) Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde

2025-03-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932685#comment-17932685 ] Ismael Juma edited comment on KAFKA-18919 at 3/5/25 4:19 PM: -

[jira] [Commented] (KAFKA-18919) Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde

2025-03-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932685#comment-17932685 ] Ismael Juma commented on KAFKA-18919: - Perhaps. I think it would be a good idea to h

Re: [PR] KAFKA-18900: Experimental share consumer acknowledge mode config [kafka]

2025-03-05 Thread via GitHub
mumrah commented on PR #19113: URL: https://github.com/apache/kafka/pull/19113#issuecomment-2701366305 @AndrewJSchofield there was a broken commit on trunk, that's why things are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-18919) Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932683#comment-17932683 ] Chia-Ping Tsai commented on KAFKA-18919: [~mimaison][~ijuma] Thank you for your

[jira] [Updated] (KAFKA-18926) `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde`

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18926: --- Labels: need-kip (was: ) > `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde` > --

[jira] [Created] (KAFKA-18926) `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde`

2025-03-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18926: -- Summary: `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde` Key: KAFKA-18926 URL: https://issues.apache.org/jira/browse/KAFKA-18926 Project: Kafka

[jira] [Commented] (KAFKA-18919) Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932686#comment-17932686 ] Chia-Ping Tsai commented on KAFKA-18919: {quote} Perhaps. I think it would be a

[jira] [Commented] (KAFKA-18922) RequestContext#principalSerde should not be optional as it is now always present

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932687#comment-17932687 ] Chia-Ping Tsai commented on KAFKA-18922: Please ignore above comment as we have

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
junrao commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981900730 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-05 Thread via GitHub
mumrah commented on PR #19069: URL: https://github.com/apache/kafka/pull/19069#issuecomment-2701677430 @sjhajharia just a quick note -- if you force push your branch after someone has reviewed your PR, it basically destroys the history of the review and inline conversations. It's best to me

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981904870 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; im

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-03-05 Thread via GitHub
mumrah commented on code in PR #18684: URL: https://github.com/apache/kafka/pull/18684#discussion_r1981899587 ## server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java: ## @@ -47,6 +48,7 @@ T getDelta(Revertable owner) { } void setDelta(Revertable owner

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-03-05 Thread via GitHub
mumrah commented on PR #18684: URL: https://github.com/apache/kafka/pull/18684#issuecomment-270121 Can you please merge trunk into this PR and let the CI run again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MINOR Add a required status check for trunk [kafka]

2025-03-05 Thread via GitHub
mumrah commented on code in PR #19122: URL: https://github.com/apache/kafka/pull/19122#discussion_r1981908712 ## .asf.yaml: ## @@ -45,3 +45,19 @@ github: squash_commit_message: PR_TITLE_AND_DESC merge: false rebase: false + + protected_branches: +trunk: +

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
smjn commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981910462 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.ut

[PR] MINOR Add a required status check for trunk [kafka]

2025-03-05 Thread via GitHub
mumrah opened a new pull request, #19122: URL: https://github.com/apache/kafka/pull/19122 Add a single job that runs after the whole CI pipeline and make it a required check before merging a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]

2025-03-05 Thread via GitHub
Iamoshione closed pull request #19077: KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer URL: https://github.com/apache/kafka/pull/19077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
szetszwo commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1981829797 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java: ## @@ -190,7 +190,7 @@ private void setState(State state) { priv

[jira] [Commented] (KAFKA-17014) ScramFormatter should not use String for password.

2025-03-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932697#comment-17932697 ] Tsz-wo Sze commented on KAFKA-17014: [~mingdaoy], I just have commented on your pr.

Re: [PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on code in PR #19108: URL: https://github.com/apache/kafka/pull/19108#discussion_r1981863839 ## tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java: ## @@ -596,18 +599,29 @@ public static VerifiableShareConsumer createFromArgs(Argu

Re: [PR] KAFKA-18637: Fix max connections per ip and override reconfigurations [kafka]

2025-03-05 Thread via GitHub
azhar2407 commented on code in PR #19099: URL: https://github.com/apache/kafka/pull/19099#discussion_r1981949803 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -482,6 +482,30 @@ class DynamicBrokerReconfigurationTest extends Quorum

Re: [PR] MINOR: zk2kraft: add more information about kafka-configs.sh [kafka]

2025-03-05 Thread via GitHub
ijuma commented on code in PR #19100: URL: https://github.com/apache/kafka/pull/19100#discussion_r1981944751 ## docs/zk2kraft.html: ## @@ -153,6 +153,67 @@ Configurations +Dynamic Log Levels + + + +The dyn

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-03-05 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932712#comment-17932712 ] Jun Rao commented on KAFKA-18477: - [~chia7712] : Good point. If the follower doesn't hav

Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]

2025-03-05 Thread via GitHub
Iamoshione commented on PR #19077: URL: https://github.com/apache/kafka/pull/19077#issuecomment-2701858209 @AndrewJSchofield Hello there I have adjusted the indentation and removed the unnecessary div tag at the end of the page -- This is an automated message from the Apache Git Service.

[jira] [Updated] (KAFKA-18422) add Kafka client upgrade path

2025-03-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18422: Fix Version/s: 4.0.0 > add Kafka client upgrade path > - > >

[jira] [Updated] (KAFKA-18074) Add kafka client compatibility matrix

2025-03-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18074: Fix Version/s: 4.0.0 > Add kafka client compatibility matrix > ---

Re: [PR] KAFKA-18919 Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde [kafka]

2025-03-05 Thread via GitHub
chia7712 commented on PR #19104: URL: https://github.com/apache/kafka/pull/19104#issuecomment-2700934771 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18811: Included admin.client.config in VerifiableShareConsumer.java [kafka]

2025-03-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19108: URL: https://github.com/apache/kafka/pull/19108#discussion_r1981377611 ## tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java: ## @@ -596,18 +599,29 @@ public static VerifiableShareConsumer createFromArgs(Argume

[jira] [Resolved] (KAFKA-18882) Remove BaseKey, TxnKey, and UnknownKey

2025-03-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18882. Fix Version/s: 4.1.0 Resolution: Fixed > Remove BaseKey, TxnKey, and UnknownKey > -

Re: [PR] KAFKA-18919 Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde [kafka]

2025-03-05 Thread via GitHub
chia7712 commented on PR #19104: URL: https://github.com/apache/kafka/pull/19104#issuecomment-2700919321 ![螢幕快照 2025-03-05 21-22-32](https://github.com/user-attachments/assets/8933593a-b41e-47b5-a95d-e8a7c5887dc8) check the web site. LGTM -- This is an automated message from the Ap

Re: [PR] MINOR: Fix typos in multiple files [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on PR #19102: URL: https://github.com/apache/kafka/pull/19102#issuecomment-2701103358 Reviewers: Andrew Schofield -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] MINOR: Fix typos in multiple files [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield merged PR #19102: URL: https://github.com/apache/kafka/pull/19102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-03-05 Thread via GitHub
mingyen066 commented on code in PR #19062: URL: https://github.com/apache/kafka/pull/19062#discussion_r1981696171 ## raft/src/main/java/org/apache/kafka/raft/internals/LogHistory.java: ## @@ -76,42 +75,5 @@ public interface LogHistory { */ void clear(); -final c

[jira] [Commented] (KAFKA-18919) Clarify that KafkaPrincipalBuilder classes must also implement KafkaPrincipalSerde

2025-03-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932678#comment-17932678 ] Mickael Maison commented on KAFKA-18919: Any existing KafkaPrincipalBuilder impl

Re: [PR] MINOR: Fix java docs [kafka]

2025-03-05 Thread via GitHub
lucasbru commented on PR #19118: URL: https://github.com/apache/kafka/pull/19118#issuecomment-2701355948 Reverted on trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18422: add Kafka client upgrade path [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19097: URL: https://github.com/apache/kafka/pull/19097#discussion_r1981698752 ## docs/upgrade.html: ## @@ -46,6 +46,9 @@ Upgrading to 4.0.0 from any vers Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/

Re: [PR] HOTFIX client java doc compile error [kafka]

2025-03-05 Thread via GitHub
lucasbru commented on PR #19115: URL: https://github.com/apache/kafka/pull/19115#issuecomment-2701354757 Hey - the change was reverted on trunk instead, we can close thois. Again, sorry for the disturance. It seems CI didn't run at all for that PR -- This is an automated message from

  1   2   3   >