apoorvmittal10 commented on code in PR #19108:
URL: https://github.com/apache/kafka/pull/19108#discussion_r1981287886
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -562,6 +557,13 @@ private static ArgumentParser argParser() {
.metavar("CONFIG_FILE")
.help("Consumer config properties file (config options shared with
command line parameters will be overridden).");
+ parser.addArgument("--admin.client.config")
Review Comment:
Just an observation, the arguments for the file are mostly `-` separated
with an exception of `consumer.config` and `admin.client.config`, why?
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -596,18 +599,29 @@ public static VerifiableShareConsumer
createFromArgs(ArgumentParser parser, Stri
StringDeserializer deserializer = new StringDeserializer();
KafkaShareConsumer<String, String> consumer = new
KafkaShareConsumer<>(consumerProps, deserializer, deserializer);
+ Properties adminClientProps = new Properties();
+ if (adminClientConfigFile != null) {
+ try {
+
adminClientProps.putAll(Utils.loadProps(adminClientConfigFile));
+ } catch (IOException e) {
+ throw new ArgumentParserException(e.getMessage(), parser);
+ }
+ }
+
+ adminClientProps.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG,
brokerHostandPort);
Review Comment:
This means the bootstrap server which is also generally included in client
config will be ignored for admin client property file, rather
`consumer.config`'s bootstrap server will be used. What admin properties do you
need so an explicit admin.client.config is required to be passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
