Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on PR #19065: URL: https://github.com/apache/kafka/pull/19065#issuecomment-2694720187 @chia7712 @dajac ![image](https://github.com/user-attachments/assets/c2680a23-93d4-4797-8860-b2d3665bd2f9) -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-18867: add tests to describe topic configs with empty name [kafka]

2025-03-03 Thread via GitHub
Rancho-7 commented on code in PR #19075: URL: https://github.com/apache/kafka/pull/19075#discussion_r1977580342 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-18867: add tests to describe topic configs with empty name [kafka]

2025-03-03 Thread via GitHub
Rancho-7 commented on code in PR #19075: URL: https://github.com/apache/kafka/pull/19075#discussion_r1977584859 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-03-03 Thread via GitHub
patronovski commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2694740863 Any updates on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
dajac commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977703481 ## docs/ops.html: ## @@ -1343,7 +1343,7 @@ Check and wait until the Lag is small for a majority of the controllers. If the leader's end offset is not increasing, you can

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-03-03 Thread via GitHub
nilmadhab commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2694913447 > Any updates on this? https://github.com/apache/kafka/pull/19005 I have created a new PR. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2025-03-03 Thread via GitHub
mjsax commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2694932880 This PR introduced a regression for EOS, and was reverted for `4.0.0` release. https://github.com/apache/kafka/pull/19078 -- This is an automated message from the Apache Git Servic

Re: [PR] HOTFIX: Revert "KAFKA-18067: Kafka Streams can leak Producer client under EOS (#17931)" [kafka]

2025-03-03 Thread via GitHub
mjsax commented on PR #19078: URL: https://github.com/apache/kafka/pull/19078#issuecomment-2694935812 This was merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

[PR] KAFKA-18909: Move DynamicThreadPool to server module [kafka]

2025-03-03 Thread via GitHub
clarkwtc opened a new pull request, #19081: URL: https://github.com/apache/kafka/pull/19081 * Add `DynamicThreadPool.java` to the server module. * Remove the old DynamicThreadPool object in the `DynamicBrokerConfig.scala`. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-18878: Added share session cache and delayed share fetch metrics (KIP-1103) [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield merged PR #19059: URL: https://github.com/apache/kafka/pull/19059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-03 Thread via GitHub
clolov commented on PR #18983: URL: https://github.com/apache/kafka/pull/18983#issuecomment-2694686895 Heya, thanks for the updated code! I will have a look at it tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-03-03 Thread via GitHub
mumrah commented on code in PR #18684: URL: https://github.com/apache/kafka/pull/18684#discussion_r1977651214 ## server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java: ## @@ -47,7 +47,9 @@ T getDelta(Revertable owner) { } void setDelta(Revertable owner

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-03 Thread via GitHub
brandboat commented on PR #18983: URL: https://github.com/apache/kafka/pull/18983#issuecomment-2694696867 > Heya, thanks for the updated code! I will have a look at it tomorrow! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977695832 ## docs/ops.html: ## @@ -4187,7 +4187,7 @@ org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor interface and specifying the full class name

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977695832 ## docs/ops.html: ## @@ -4187,7 +4187,7 @@ org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor interface and specifying the full class name

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-03 Thread via GitHub
frankvicky commented on code in PR #18983: URL: https://github.com/apache/kafka/pull/18983#discussion_r1977696277 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -1922,6 +1922,135 @@ public void testReassignPartitions(short version

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977695832 ## docs/ops.html: ## @@ -4187,7 +4187,7 @@ org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor interface and specifying the full class name

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-03-03 Thread via GitHub
mumrah commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1977721741 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/README.md: ## @@ -104,7 +104,7 @@ For each generated invocation: * Non-static `@A

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-03 Thread via GitHub
frankvicky commented on code in PR #18983: URL: https://github.com/apache/kafka/pull/18983#discussion_r1977728460 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -1922,6 +1922,135 @@ public void testReassignPartitions(short version

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977729557 ## docs/ops.html: ## @@ -1343,13 +1343,13 @@ Check and wait until the Lag is small for a majority of the controllers. If the leader's end offset is not increasing, yo

Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

2025-03-03 Thread via GitHub
brandboat commented on code in PR #18983: URL: https://github.com/apache/kafka/pull/18983#discussion_r1977713877 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -1922,6 +1922,135 @@ public void testReassignPartitions(short version)

[jira] [Updated] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-18871: - Attachment: controller_logs.zip kraft-rollback-kafka-default-pool-1.zip

[jira] [Updated] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-18871: - Attachment: kraft-rollback-kafka-default-pool-0.zip > KRaft migration rollback causes downtime >

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932017#comment-17932017 ] Daniel Urban commented on KAFKA-18871: -- [~showuon] Managed to reproduce with debug

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977801099 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977722899 ## docs/ops.html: ## @@ -1343,7 +1343,7 @@ Check and wait until the Lag is small for a majority of the controllers. If the leader's end offset is not increasing, you

[jira] [Created] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18913: --- Summary: Consider removing state-updater feature flag Key: KAFKA-18913 URL: https://issues.apache.org/jira/browse/KAFKA-18913 Project: Kafka Issue Type

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on code in PR #17264: URL: https://github.com/apache/kafka/pull/17264#discussion_r1977096640 ## server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java: ## @@ -40,18 +40,18 @@ public class ClientMetricsTestUtils { public

[PR] Revert "KAFKA-18067: Kafka Streams can leak Producer client under EOS (#17931)" [kafka]

2025-03-03 Thread via GitHub
cadonna opened a new pull request, #19078: URL: https://github.com/apache/kafka/pull/19078 This reverts commit e8837465a5fc478f1c79d1ad475b43e00a39a5d7. The commit that is reverted prevents Kafka Streams from re-initializing its transactional producer. If an exception that fences the

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) [kafka]

2025-03-03 Thread via GitHub
FrankYang0529 commented on PR #19058: URL: https://github.com/apache/kafka/pull/19058#issuecomment-2693758227 @dajac, I think we can just cherry-picked it, because there is no conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931922#comment-17931922 ] Luke Chen commented on KAFKA-18871: --- [~durban] , thanks for sharing the logs and thank

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
apoorvmittal10 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977242641 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +ena

[jira] [Commented] (KAFKA-18911) alterPartition gets stuck when getting out-of-date errors

2025-03-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931923#comment-17931923 ] Luke Chen commented on KAFKA-18911: --- Had another look, it looks like we're OK to stay

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931936#comment-17931936 ] Daniel Urban commented on KAFKA-18871: -- [~showuon] Thanks for looking into it - wil

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931925#comment-17931925 ] Luke Chen commented on KAFKA-18871: --- Had another look for (1), it is not a problem now

[jira] [Reopened] (KAFKA-18067) Kafka Streams can leak Producer client under EOS

2025-03-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-18067: --- We had to revert the fix for this bug (https://github.com/apache/kafka/pull/19078) because it i

[jira] [Updated] (KAFKA-18067) Kafka Streams can leak Producer client under EOS

2025-03-03 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-18067: -- Fix Version/s: (was: 4.0.0) > Kafka Streams can leak Producer client under EOS > -

Re: [PR] KAFKA-18843: Fix MirrorMaker2 workerId is not unique, but use the sam… [kafka]

2025-03-03 Thread via GitHub
k0b3rIT commented on PR #18994: URL: https://github.com/apache/kafka/pull/18994#issuecomment-2693628006 @viktorsomogyi @C0urante Can you please kindly check this fix when you have free capacity. Thank you! -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977114543 ## build.gradle: ## @@ -353,17 +353,14 @@ subprojects { if (!shouldPublishWithShadow) { from components.java } else { -

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #19058: URL: https://github.com/apache/kafka/pull/19058#issuecomment-2693750609 @FrankYang0529 Do we also need a PR for 4.0 or was it already cherry-picked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-10864: Convert end txn marker schema to use auto-generated protocol [kafka]

2025-03-03 Thread via GitHub
dengziming commented on code in PR #9766: URL: https://github.com/apache/kafka/pull/9766#discussion_r1977186279 ## clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java: ## @@ -95,32 +76,35 @@ public int hashCode() { private static void ensureTran

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-03-03 Thread via GitHub
cadonna merged PR #19043: URL: https://github.com/apache/kafka/pull/19043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-03 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1977276265 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -16,44 +16,2351 @@ */ package org.apache.kafka.storage.internals.log; +impo

[jira] [Commented] (KAFKA-17808) InstanceAlreadyExistsException: kafka.admin.client:type=app-info,id=connector-dlq-adminclient- when add connector with tasks

2025-03-03 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931929#comment-17931929 ] Muralidhar Basani commented on KAFKA-17808: --- [~yung] thanks for asking. It wo

Re: [PR] KAFKA-17808 : Append connector name to admin client id - dlq sink reporter [kafka]

2025-03-03 Thread via GitHub
muralibasani commented on PR #17538: URL: https://github.com/apache/kafka/pull/17538#issuecomment-2693947539 > @muralibasani Thanks for the patch. Do you have time to revisit this? Otherwise, I'd like to continue this PR and add some tests. @Yunyung thank you and pls take over. It wou

Re: [PR] HOTFIX: Revert "KAFKA-18067: Kafka Streams can leak Producer client under EOS (#17931)" [kafka]

2025-03-03 Thread via GitHub
cadonna merged PR #19078: URL: https://github.com/apache/kafka/pull/19078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18904) Listing of configs for dynamically created resources is mysterious

2025-03-03 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931909#comment-17931909 ] Andrew Schofield commented on KAFKA-18904: -- [~yangpoan]Absolutely, please go ah

Re: [PR] KAFKA-18887 Implement Streams Admin APIs [kafka]

2025-03-03 Thread via GitHub
lucasbru commented on code in PR #19049: URL: https://github.com/apache/kafka/pull/19049#discussion_r1977177176 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteStreamsGroupOffsetsResult.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1977193479 ## build.gradle: ## @@ -1916,6 +1913,10 @@ project(':clients') { generator project(':generator') } + tasks.withType(GenerateModuleMetadata) { +enabled

Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield merged PR #19055: URL: https://github.com/apache/kafka/pull/19055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-03-03 Thread via GitHub
lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1977199932 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -397,7 +397,7 @@ public void testStressfulSituation() throws Exc

[jira] [Created] (KAFKA-18911) alterPartition gets stuck when getting out-of-date errors

2025-03-03 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18911: - Summary: alterPartition gets stuck when getting out-of-date errors Key: KAFKA-18911 URL: https://issues.apache.org/jira/browse/KAFKA-18911 Project: Kafka Issue Typ

[jira] [Resolved] (KAFKA-18911) alterPartition gets stuck when getting out-of-date errors

2025-03-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-18911. --- Resolution: Invalid > alterPartition gets stuck when getting out-of-date errors > --

[jira] [Commented] (KAFKA-16936) Upgrade slf4k to 2.0.9 and integrate "-Dslf4j.provider" to kafka script

2025-03-03 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931926#comment-17931926 ] Muralidhar Basani commented on KAFKA-16936: --- Hi [~frankvicky] sorry, could not

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
apoorvmittal10 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2693906211 @dejan2609 Can you please merge the upstream changes and re-run the build to see if tests pass. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-03 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1977352466 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -16,44 +16,2351 @@ */ package org.apache.kafka.storage.internals.log; +impo

Re: [PR] KAFKA-18899: Limit retry time for ShareConsumer.commitAsync [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on PR #19060: URL: https://github.com/apache/kafka/pull/19060#issuecomment-2693753771 Converting to draft PR. Additional testing revealed that the time-out logic needs to be a bit more sophisticated. -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-03 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2694058225 > @dejan2609 Can you please merge the upstream changes and re-run the build to see if tests pass. @apoorvmittal10 Done, PR is rebased onto trunk. I opted to keep all commits sepa

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-03-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931915#comment-17931915 ] Chia-Ping Tsai commented on KAFKA-18477: {quote} It's unlikely that any topic wo

Re: [PR] [MINOR] Clean up metadata module [kafka]

2025-03-03 Thread via GitHub
sjhajharia commented on PR #19069: URL: https://github.com/apache/kafka/pull/19069#issuecomment-2694200768 Thanks @m1a2st for catching those classes. Updated the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2025-03-03 Thread via GitHub
chia7712 commented on PR #17264: URL: https://github.com/apache/kafka/pull/17264#issuecomment-2694338122 @AndrewJSchofield could you please check the build error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-18912) Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk

2025-03-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931965#comment-17931965 ] Chia-Ping Tsai commented on KAFKA-18912: It seem the KAFKA-4650 is related to st

[PR] KAFKA-13022: Optimize ClientQuotasImage#describe (wip) [kafka]

2025-03-03 Thread via GitHub
FrankYang0529 opened a new pull request, #19079: URL: https://github.com/apache/kafka/pull/19079 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add som

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-03 Thread via GitHub
mimaison commented on PR #19030: URL: https://github.com/apache/kafka/pull/19030#issuecomment-2694168281 Thanks @chia7712 for the review! I pushed an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-03-03 Thread via GitHub
m1a2st commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r1977444283 ## build.gradle: ## @@ -1075,7 +1075,6 @@ project(':core') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configurati

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
m1a2st commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977515801 ## docs/ops.html: ## @@ -4187,7 +4187,7 @@ org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor interface and specifying the full class name i

[jira] [Commented] (KAFKA-18912) Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk

2025-03-03 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931961#comment-17931961 ] Lorcan commented on KAFKA-18912: Hi [~chia7712], thanks for the information, I wasn't aw

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19026: URL: https://github.com/apache/kafka/pull/19026#discussion_r1977260665 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -454,6 +466,77 @@ public CompletableFuture shareGrou

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-03 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1977414967 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -16,44 +16,2351 @@ */ package org.apache.kafka.storage.internals.log; +impo

[jira] [Created] (KAFKA-18912) Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk

2025-03-03 Thread Lorcan (Jira)
Lorcan created KAFKA-18912: -- Summary: Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk Key: KAFKA-18912 URL: https://issues.apache.org/jira/browse/KAFKA-18912 Project: Kafka

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-03 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1977414279 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -16,44 +16,2351 @@ */ package org.apache.kafka.storage.internals.log; +impo

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-03-03 Thread via GitHub
chia7712 commented on PR #18926: URL: https://github.com/apache/kafka/pull/18926#issuecomment-2694325084 @leaf-soba could you please fix the build error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-18912) Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk

2025-03-03 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan updated KAFKA-18912: --- Description: I am unable to build (up to date as of 03/03) trunk with no local changes due to a failed test

[jira] [Commented] (KAFKA-18912) Failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit on Trunk

2025-03-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931958#comment-17931958 ] Chia-Ping Tsai commented on KAFKA-18912: [~lorcanj] If all you want to do is to

Re: [PR] KAFKA-18867: add tests to describe topic configs with empty name [kafka]

2025-03-03 Thread via GitHub
Rancho-7 commented on code in PR #19075: URL: https://github.com/apache/kafka/pull/19075#discussion_r1977580342 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-18867: add tests to describe topic configs with empty name [kafka]

2025-03-03 Thread via GitHub
Rancho-7 commented on code in PR #19075: URL: https://github.com/apache/kafka/pull/19075#discussion_r1977584859 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #19036: URL: https://github.com/apache/kafka/pull/19036#issuecomment-2694537335 @junrao I cherry-picked the commit to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] MINOR: Don't print cleaning group metadata log if empty [kafka]

2025-03-03 Thread via GitHub
dajac opened a new pull request, #19080: URL: https://github.com/apache/kafka/pull/19080 The new group coordinator prints the following line at fixed interval even if no groups were deleted: ``` Generated 0 tombstone records while cleaning up group metadata in 0 milliseconds. (org

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r1977599300 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1206,6 +1210,93 @@ public CompletableFuture delete

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #19058: URL: https://github.com/apache/kafka/pull/19058#issuecomment-2694563500 > @dajac, I think we can just cherry-picked it, because there is no conflict. Sounds good. I did it. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-03-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18864: Fix Version/s: 4.0.0 (was: 4.1.0) > remove the Evolving tag from stable pub

Re: [PR] KAFKA-18878: Added share session cache and delayed share fetch metrics (KIP-1103) [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19059: URL: https://github.com/apache/kafka/pull/19059#discussion_r1977587676 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -1118,6 +1119,23 @@ public void testPartitionMaxBytesFromUniformStrategyInCombineLo

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2694548745 I cherry-picked the commit to 4.0. cc @junrao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #19065: URL: https://github.com/apache/kafka/pull/19065#issuecomment-2694557772 @mingdaoy Would you have time for addressing @chia7712's comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18878: Added share session cache and delayed share fetch metrics (KIP-1103) [kafka]

2025-03-03 Thread via GitHub
apoorvmittal10 commented on code in PR #19059: URL: https://github.com/apache/kafka/pull/19059#discussion_r1977614076 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -1118,6 +1119,23 @@ public void testPartitionMaxBytesFromUniformStrategyInCombineLogR

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-03-03 Thread via GitHub
AndrewJSchofield commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r1977606102 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteShareGroupOffsetsHandler.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
dajac commented on PR #19065: URL: https://github.com/apache/kafka/pull/19065#issuecomment-2694553565 @chia7712 Good catch! I missed that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Don't allow cloning a ProducerStateEntry with a different producer id [kafka]

2025-03-03 Thread via GitHub
github-actions[bot] commented on PR #18990: URL: https://github.com/apache/kafka/pull/18990#issuecomment-2691891283 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Resolved] (KAFKA-17981) add Integration test for ConfigCommand to add config `key=[val1,val2]`

2025-03-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17981. Fix Version/s: 4.1.0 Resolution: Fixed > add Integration test for ConfigCommand to

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
mingdaoy commented on PR #19065: URL: https://github.com/apache/kafka/pull/19065#issuecomment-2694625874 @dajac Doing it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

2025-03-03 Thread via GitHub
dajac commented on code in PR #19065: URL: https://github.com/apache/kafka/pull/19065#discussion_r1977913129 ## docs/ops.html: ## @@ -1343,13 +1343,13 @@ Check and wait until the Lag is small for a majority of the controllers. If the leader's end offset is not increasing, you c

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-03-03 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1977923340 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-03-03 Thread via GitHub
mjsax merged PR #19052: URL: https://github.com/apache/kafka/pull/19052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) [kafka]

2025-03-03 Thread via GitHub
junrao closed pull request #19058: KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) URL: https://github.com/apache/kafka/pull/19058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: Prevent broker fencing by adjusting resendExponentialBackoff in BrokerLifecycleManager [kafka]

2025-03-03 Thread via GitHub
cmccabe merged PR #19061: URL: https://github.com/apache/kafka/pull/19061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

  1   2   >