dejan2609 commented on code in PR #18018:
URL: https://github.com/apache/kafka/pull/18018#discussion_r1977235728
##########
build.gradle:
##########
@@ -1916,6 +1913,10 @@ project(':clients') {
generator project(':generator')
}
+ tasks.withType(GenerateModuleMetadata) {
+ enabled = false
Review Comment:
Just to sum it up: @poom-kitti (and mine) intention is to have exact
behavior for `kafka-clients` dependency (in external projects, that is) and
hence I opted to honor his findings and to [disable gradle module metadata
publication](https://docs.gradle.org/8.10.2/userguide/publishing_gradle_module_metadata.html#sub:disabling-gmm-publication)
for `project(':clients')` (i.e. for `kafka-clients` artifacts)
All in all: we ended up with a situation where we are trying to have all
these three things at once:
- switch shadow plugin (i.e. us GradleUp/shadow plugin)
- have exactly the same dependency tree in external projects (with
`kafka-clients` dependency)
- publish gradle module metadata for `project(':clients' (`kafka-clients`
artifacts)
I dare to assume that this could be addressed on
https://github.com/GradleUp/shadow side, maybe @Goooler can provide at least
some insights.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
