Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-25 Thread via GitHub
frankvicky commented on code in PR #19019: URL: https://github.com/apache/kafka/pull/19019#discussion_r1969165413 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-25 Thread via GitHub
frankvicky commented on code in PR #19019: URL: https://github.com/apache/kafka/pull/19019#discussion_r1969197649 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-25 Thread via GitHub
gongxuanzhang commented on code in PR #19019: URL: https://github.com/apache/kafka/pull/19019#discussion_r1969198382 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-25 Thread via GitHub
gongxuanzhang commented on code in PR #19019: URL: https://github.com/apache/kafka/pull/19019#discussion_r1969207466 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Assigned] (KAFKA-18760) Deprecate Optional and return String from public EndPoint#Listener

2025-02-25 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18760: --- Assignee: PoAn Yang (was: TaiJuWu) > Deprecate Optional and return String from public EndPoint#Lis

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-25 Thread via GitHub
Rancho-7 commented on PR #18966: URL: https://github.com/apache/kafka/pull/18966#issuecomment-2681141800 I did not add a `` test case for `ip` type, because if we use the `ip` type and set it to default, [configKeysForEntityType](https://github.com/apache/kafka/blob/1c82b89b4cfee4692f6ec3e2

Re: [PR] KAFKA-18613: Auto-creation of internal topics in streams group heartbeat [kafka]

2025-02-25 Thread via GitHub
lucasbru commented on code in PR #18981: URL: https://github.com/apache/kafka/pull/18981#discussion_r1969291186 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -10040,6 +10040,86 @@ class KafkaApisTest extends Logging { assertEquals("Use of Kafka interna

[PR] MINOR : Add missing error code in ConsumerHeartbeatRequestManagerTest. [kafka]

2025-02-25 Thread via GitHub
ShivsundarR opened a new pull request, #19024: URL: https://github.com/apache/kafka/pull/19024 ***What*** PR fixes a minor bug in https://github.com/apache/kafka/pull/18986/files#diff-9fbddcb7950c03d236f3791df42fe4de0feb6d4ff25c7d8bec80545ff9378af3R585. The test was previously no

Re: [PR] KAFKA-18813: [2/N] Client support for TopicAuthException in HB path [kafka]

2025-02-25 Thread via GitHub
ShivsundarR commented on code in PR #18986: URL: https://github.com/apache/kafka/pull/18986#discussion_r1969299960 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManagerTest.java: ## @@ -582,6 +582,11 @@ public void testHeartbeatResp

Re: [PR] KAFKA-17351: Improved handling of compacted topics in share partition (2/N) [kafka]

2025-02-25 Thread via GitHub
adixitconfluent commented on code in PR #19010: URL: https://github.com/apache/kafka/pull/19010#discussion_r1969052794 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -615,13 +615,44 @@ public long nextFetchOffset() { * Acquire the fetched records for t

Re: [PR] KAFKA-17037:KIP-919 supports for `describeClientQuotas` and `alterClientQuotas` [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #17339: URL: https://github.com/apache/kafka/pull/17339#issuecomment-2680344685 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] [MINOR] Fix the docs for share group metric functions [kafka]

2025-02-25 Thread via GitHub
apoorvmittal10 commented on PR #19023: URL: https://github.com/apache/kafka/pull/19023#issuecomment-2681377892 Not sure why there are scan failures, also I have seen same on other PRs since yesterday. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-17351: Improved handling of compacted topics in share partition (2/N) [kafka]

2025-02-25 Thread via GitHub
apoorvmittal10 commented on code in PR #19010: URL: https://github.com/apache/kafka/pull/19010#discussion_r1969396237 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1061,33 +1100,105 @@ void updateCacheAndOffsets(long logStartOffset) { } } +

[jira] [Assigned] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-25 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18860: --- Assignee: TengYao Chi > Clarify the KRaft missing feature > ---

[jira] [Commented] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-25 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930271#comment-17930271 ] TengYao Chi commented on KAFKA-18860: - Hi [~showuon]  I will deal this one if it is

Re: [PR] KAFKA-17351: Improved handling of compacted topics in share partition (2/N) [kafka]

2025-02-25 Thread via GitHub
apoorvmittal10 commented on code in PR #19010: URL: https://github.com/apache/kafka/pull/19010#discussion_r1969368571 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -615,13 +615,44 @@ public long nextFetchOffset() { * Acquire the fetched records for th

Re: [PR] MINOR: Adjust docs for the committed message [kafka]

2025-02-25 Thread via GitHub
AndrewJSchofield commented on code in PR #19022: URL: https://github.com/apache/kafka/pull/19022#discussion_r1969318235 ## docs/design.html: ## @@ -264,7 +264,8 @@

Re: [PR] KAFKA-18828: Update share group metrics per new init and call mechanism. [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on PR #18962: URL: https://github.com/apache/kafka/pull/18962#issuecomment-2681371500 LGTM @smjn thanks for this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #17264: URL: https://github.com/apache/kafka/pull/17264#discussion_r1969426571 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

[jira] [Commented] (KAFKA-18330) Update documentation to remove controller deployment limitations

2025-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930243#comment-17930243 ] ASF GitHub Bot commented on KAFKA-18330: chia7712 merged PR #659: URL: https://g

[jira] [Commented] (KAFKA-18859) honor the error message of UnregisterBrokerResponse

2025-02-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930248#comment-17930248 ] 黃竣陽 commented on KAFKA-18859: - Hello [~chia7712], if you won't work on this, may I take it?

[jira] [Commented] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930251#comment-17930251 ] Luke Chen commented on KAFKA-18860: --- [~cmccabe] [~jsancio], any thought about this? [

[jira] [Created] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-25 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18860: - Summary: Clarify the KRaft missing feature Key: KAFKA-18860 URL: https://issues.apache.org/jira/browse/KAFKA-18860 Project: Kafka Issue Type: Bug Repor

Re: [PR] KAFKA-17351: Improved handling of compacted topics in share partition (2/N) [kafka]

2025-02-25 Thread via GitHub
adixitconfluent commented on code in PR #19010: URL: https://github.com/apache/kafka/pull/19010#discussion_r1969452108 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1061,33 +1100,105 @@ void updateCacheAndOffsets(long logStartOffset) { } }

Re: [PR] KAFKA-17836: Move RackAwareTest to server module [kafka]

2025-02-25 Thread via GitHub
chia7712 merged PR #19021: URL: https://github.com/apache/kafka/pull/19021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [MINOR] Fix the docs for share group metric functions [kafka]

2025-02-25 Thread via GitHub
AndrewJSchofield merged PR #19023: URL: https://github.com/apache/kafka/pull/19023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-17836) Move RackAwareTest to server module

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17836. Fix Version/s: 4.1.0 Resolution: Fixed > Move RackAwareTest to server module > ---

[jira] [Assigned] (KAFKA-18859) honor the error message of UnregisterBrokerResponse

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18859: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > honor the error message of UnregisterBrokerRes

[PR] MINOR: Add README.md test command [kafka]

2025-02-25 Thread via GitHub
mingdaoy opened a new pull request, #19025: URL: https://github.com/apache/kafka/pull/19025 Reason: https://github.com/apache/kafka/pull/18770#discussion_r1968575877 ![image](https://github.com/user-attachments/assets/43d16929-c04a-4cc3-b1be-e926a067404e) ### Committer Chec

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
chia7712 merged PR #18961: URL: https://github.com/apache/kafka/pull/18961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-15146) Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures

2025-02-25 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930504#comment-17930504 ] kangning.li commented on KAFKA-15146: - This test has succeeded consistently over the

[jira] [Created] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18864: --- Summary: remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage Key: KAFKA-18864 URL: https://issues.apache.org/jira/browse/KAFKA-18864 Pr

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970794134 ## server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java: ## @@ -136,14 +136,16 @@ public class ServerLogConfigs { public static final

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970799319 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -172,13 +172,15 @@ public class TopicConfig { public static final String MIN_IN_SY

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970794134 ## server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java: ## @@ -136,14 +136,16 @@ public class ServerLogConfigs { public static final

Re: [PR] merge [kafka]

2025-02-25 Thread via GitHub
memedadexiaobai closed pull request #19032: merge URL: https://github.com/apache/kafka/pull/19032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-25 Thread via GitHub
mjsax merged PR #18988: URL: https://github.com/apache/kafka/pull/18988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-25 Thread via GitHub
mjsax commented on PR #18988: URL: https://github.com/apache/kafka/pull/18988#issuecomment-2683785351 Merged to `trunk` and cherry-picked to `4.0` release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-25 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1970835148 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] KAFKA-1792: change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #18903: URL: https://github.com/apache/kafka/pull/18903#issuecomment-2683787805 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2683787840 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #18949: URL: https://github.com/apache/kafka/pull/18949#issuecomment-2683787764 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930520#comment-17930520 ] Ismael Juma commented on KAFKA-18864: - Yeah, this should not be used for stable APIs

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-02-25 Thread via GitHub
xijiu commented on PR #18299: URL: https://github.com/apache/kafka/pull/18299#issuecomment-2683795730 @chia7712 I have added it, PTAL. For test, I added the invalid content to `LICENSE-binary`: https://github.com/user-attachments/assets/eb505eb8-5284-449c-b6c3-d00b19255891"; />

[PR] merge [kafka]

2025-02-25 Thread via GitHub
memedadexiaobai opened a new pull request, #19032: URL: https://github.com/apache/kafka/pull/19032 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add s

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #17908: URL: https://github.com/apache/kafka/pull/17908#issuecomment-2683813615 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2025-02-25 Thread via GitHub
github-actions[bot] commented on PR #17969: URL: https://github.com/apache/kafka/pull/17969#issuecomment-2683813640 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Specify ArrayDeque init size to NUM_BATCHES_TO_RETAIN in ProducerStateEntry [kafka]

2025-02-25 Thread via GitHub
dao-jun commented on PR #18991: URL: https://github.com/apache/kafka/pull/18991#issuecomment-2683822342 > Hi @dao-jun Could you please rebase the branch onto the `trunk` ? Kafka recently applied the new CI flow; it would be better if the patch could walk through it. merged -- This

[PR] MINOR: Remove old message format documentation [kafka]

2025-02-25 Thread via GitHub
ijuma opened a new pull request, #19033: URL: https://github.com/apache/kafka/pull/19033 Link to the older version of the documentation for people who care. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970616675 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -172,13 +172,15 @@ public class TopicConfig { public static final String MIN_IN_SY

[jira] [Commented] (KAFKA-18862) Review testHeartbeatResponseOnErrorHandling duplicate logic in ShareHeartbeatRequestManagerTest

2025-02-25 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930481#comment-17930481 ] Lianet Magrans commented on KAFKA-18862: Sure, thanks! > Review testHeartbeatRe

[jira] [Assigned] (KAFKA-18862) Review testHeartbeatResponseOnErrorHandling duplicate logic in ShareHeartbeatRequestManagerTest

2025-02-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18862: - Assignee: PoAn Yang > Review testHeartbeatResponseOnErrorHandling duplicate logic in > ShareHe

[jira] [Commented] (KAFKA-18862) Review testHeartbeatResponseOnErrorHandling duplicate logic in ShareHeartbeatRequestManagerTest

2025-02-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930480#comment-17930480 ] PoAn Yang commented on KAFKA-18862: --- Hi [~lianetm], if you're not working on this, may

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1970705554 ## core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala: ## @@ -561,5 +568,17 @@ abstract class EndToEndAuthorizationTest extends IntegrationTest

[jira] [Created] (KAFKA-18865) Improve KRaft handling of kraft.version

2025-02-25 Thread Jira
José Armando García Sancio created KAFKA-18865: -- Summary: Improve KRaft handling of kraft.version Key: KAFKA-18865 URL: https://issues.apache.org/jira/browse/KAFKA-18865 Project: Kafka

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970761578 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970761435 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930492#comment-17930492 ] xuanzhang gong commented on KAFKA-18864: Hi,I will handle this issue,plz ticket

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970745986 ## raft/src/main/java/org/apache/kafka/raft/VoterSet.java: ## @@ -343,6 +343,10 @@ public ReplicaKey voterKey() { return voterKey; } +p

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930493#comment-17930493 ] Chia-Ping Tsai commented on KAFKA-18864: [~junrao] Is InterfaceStability.Evolvin

[jira] [Commented] (KAFKA-18817) ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe

2025-02-25 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930494#comment-17930494 ] Lan Ding commented on KAFKA-18817: -- Hi [~shivsundar] , are you still working on this? M

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -487,6 +555,12 @@ private EventScheduler schedulerWithDefaultInvariants(Cluster clus

[jira] [Updated] (KAFKA-18844) Stale features information in QuorumController#registerBroker

2025-02-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18844: -- Summary: Stale features information in QuorumController#registerBroker (was: Fix flaky QuorumControll

[jira] [Updated] (KAFKA-18844) Stale features information in QuorumController#registerBroker

2025-02-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18844: -- Description: In https://github.com/apache/kafka/pull/16848, we added kraft.version to finalized featu

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-25 Thread via GitHub
FrankYang0529 commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2683668617 Hi @junrao, thanks for the review. Updated title and description on Jira and the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Assigned] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18864: -- Assignee: xuanzhang gong > remove the Evolving tag from public interfaces in > org.a

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-25 Thread via GitHub
gongxuanzhang commented on PR #19019: URL: https://github.com/apache/kafka/pull/19019#issuecomment-2683672839 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -487,6 +555,12 @@ private EventScheduler schedulerWithDefaultInvariants(Cluster clus

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2683361926 have checked the PR on 4.0 manually. cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970576760 ## server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java: ## @@ -136,14 +136,16 @@ public class ServerLogConfigs { public static final Str

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970582069 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -172,13 +172,15 @@ public class TopicConfig { public static final String MIN_IN_SYNC_

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425 ## raft/src/main/java/org/apache/kafka/raft/VoterSet.java: ## @@ -343,6 +343,10 @@ public ReplicaKey voterKey() { return voterKey; } +

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -487,6 +555,12 @@ private EventScheduler schedulerWithDefaultInvariants(Cluster clus

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425 ## raft/src/main/java/org/apache/kafka/raft/VoterSet.java: ## @@ -343,6 +343,10 @@ public ReplicaKey voterKey() { return voterKey; } +

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-25 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425 ## raft/src/main/java/org/apache/kafka/raft/VoterSet.java: ## @@ -343,6 +343,10 @@ public ReplicaKey voterKey() { return voterKey; } +

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-25 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1970784603 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

[jira] [Commented] (KAFKA-16936) Upgrade slf4k to 2.0.9 and integrate "-Dslf4j.provider" to kafka script

2025-02-25 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930524#comment-17930524 ] TengYao Chi commented on KAFKA-16936: - Gentle Ping [~muralibasani]  I would like to

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970902496 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r197090 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SYNC_

[PR] KAFKA-3987: Replacing config of the hash algorithm used by the log cleaner [kafka]

2025-02-25 Thread via GitHub
Jeri-jose opened a new pull request, #19035: URL: https://github.com/apache/kafka/pull/19035 Replace MD5 with SHA-256 for FIPS 140-3 compliance in Log Cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (KAFKA-3987) Allow configuration of the hash algorithm used by the LogCleaner's offset map

2025-02-25 Thread jeri jose (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930539#comment-17930539 ] jeri jose commented on KAFKA-3987: -- To align with FIPS 140-3 compliance requirements, MD

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970906033 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SYNC_

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970904949 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SYNC_

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1970955890 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2592,6 +2607,34 @@ class KafkaApis(val requestChannel: RequestChannel, response.groups.addAll(

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930550#comment-17930550 ] Chia-Ping Tsai commented on KAFKA-18864: I list the public APIs which are existe

Re: [PR] KAFKA-10864: Convert end txn marker schema to use auto-generated protocol [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #9766: URL: https://github.com/apache/kafka/pull/9766#discussion_r1971065624 ## clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java: ## @@ -95,32 +71,28 @@ public int hashCode() { private static void ensureTransa

[jira] (KAFKA-18393) Remove code deprecated to implement KIP-1043

2025-02-25 Thread Hyunsang Han (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18393 ] Hyunsang Han deleted comment on KAFKA-18393: -- was (Author: JIRAUSER307848): I'll take care of it! > Remove code deprecated to implement KIP-1043 > --

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-25 Thread via GitHub
rajinisivaram commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1971087726 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -645,6 +645,7 @@ class BrokerServer( .withGroupCoordinatorMetrics(new GroupCoordinatorMetr

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930553#comment-17930553 ] Ismael Juma commented on KAFKA-18864: - Seems reasonable to remove from all of those.

[jira] [Commented] (KAFKA-18393) Remove code deprecated to implement KIP-1043

2025-02-25 Thread Hyunsang Han (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930554#comment-17930554 ] Hyunsang Han commented on KAFKA-18393: -- I'll take care of it! > Remove code deprec

Re: [PR] MINOR: Remove old message format documentation [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19033: URL: https://github.com/apache/kafka/pull/19033#discussion_r1970992722 ## docs/implementation.html: ## @@ -103,67 +103,8 @@ 5.3.3 Old Message Format -Prior to Kafka 0.11, messages were transferred and stored in message sets. I

[jira] [Comment Edited] (KAFKA-18864) remove the Evolving tag from public interfaces in org.apache.kafka.server.log.remote.storage

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930550#comment-17930550 ] Chia-Ping Tsai edited comment on KAFKA-18864 at 2/26/25 6:48 AM: -

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970909685 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SYNC_

Re: [PR] MINOR: Remove old message format documentation [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on code in PR #19033: URL: https://github.com/apache/kafka/pull/19033#discussion_r1970972098 ## docs/implementation.html: ## @@ -103,67 +103,8 @@ 5.3.3 Old Message Format -Prior to Kafka 0.11, messages were transferred and stored in message sets

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930558#comment-17930558 ] Chia-Ping Tsai commented on KAFKA-18864: [~gongxuanzhang] I update the title. Pl

[jira] [Commented] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-02-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930559#comment-17930559 ] Ismael Juma commented on KAFKA-18864: - You mean we have the evolving annotation on s

[jira] [Comment Edited] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-02-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930559#comment-17930559 ] Ismael Juma edited comment on KAFKA-18864 at 2/26/25 6:52 AM:

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1971104486 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SY

[jira] [Updated] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-02-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18864: --- Attachment: 螢幕快照 2025-02-26 14-56-31.png > remove the Evolving tag from stable public interf

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-25 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1971049031 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {

  1   2   3   >