[PR] MINOR: fix KStream#to incorrect javadoc [kafka]

brandboat opened a new pull request, #18838: URL: https://github.com/apache/kafka/pull/18838 before:  after: ![image](https://github.com/user-attachments/assets/e7c65a6a-e137-457e-ad07-6cad

[PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

mjsax opened a new pull request, #18840: URL: https://github.com/apache/kafka/pull/18840 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] KAFKA-18607 - migrated jfreechart from jfreechart to org.jfreechart [kafka]

shubham-s-del opened a new pull request, #18841: URL: https://github.com/apache/kafka/pull/18841 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

mjsax commented on code in PR #18840: URL: https://github.com/apache/kafka/pull/18840#discussion_r1947484456 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -682,7 +682,7 @@ public class StreamsConfig extends AbstractConfig { /** {@code process

Re: [PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

mjsax commented on code in PR #18840: URL: https://github.com/apache/kafka/pull/18840#discussion_r1947484637 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1002,9 +1052,9 @@ public void shouldGetClientTagsMapWhenSet() { props.put(Stream

Re: [PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

mjsax commented on code in PR #18840: URL: https://github.com/apache/kafka/pull/18840#discussion_r1947484523 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -234,6 +281,7 @@ public void testGetRestoreConsumerConfigs() { assertNull(returne

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

bbejeck commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1947288775 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -190,6 +202,55 @@ public GroupCoordinatorMetrics(Metri

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2644022430 > @kirktrue : Thanks for updated PR. The code LGTM. Are the flaky test failure related to this PR? > > ``` > FLAKY ⚠️ EagerConsumerCoordinatorTest > testOutdatedCoordinatorAss

Re: [PR] MINOR: Refactor method name for consistency [kafka]

AndrewJSchofield merged PR #18779: URL: https://github.com/apache/kafka/pull/18779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-16368: Update defaults for LOG_MESSAGE_TIMESTAMP_AFTER_MAX_MS_D… [kafka]

mjsax commented on PR #18106: URL: https://github.com/apache/kafka/pull/18106#issuecomment-2644031334 @jayteej @divijvaidya This PR did break two of our Kafka Streams system tests. And the changes you put into the KS integrations test where not really "correct". Cf https://github.co

[jira] [Updated] (KAFKA-18760) Consider to deprecate Optional and return String from public EndPoint

[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu updated KAFKA-18760: Summary: Consider to deprecate Optional and return String from public EndPoint (was: Consider to remove O

[jira] [Assigned] (KAFKA-16580) Write simulation tests for kraft membership change

[ https://issues.apache.org/jira/browse/KAFKA-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu reassigned KAFKA-16580: Assignee: Kevin Wu (was: TaiJuWu) > Write simulation tests for kraft membership change > ---

Re: [PR] KAFKA-18743: leader.imbalance.per.broker.percentage is not supported by Kraft [kafka]

chia7712 commented on PR #18821: URL: https://github.com/apache/kafka/pull/18821#issuecomment-264415 @Yunyung could you please rebase code to run QA again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (KAFKA-16580) Write simulation tests for kraft membership change

[ https://issues.apache.org/jira/browse/KAFKA-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925042#comment-17925042 ] Kevin Wu commented on KAFKA-16580: -- Will tackle this issue incrementally, since it's so

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947194285 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Updated] (KAFKA-18627) add allowed modules to JaasUtils

[ https://issues.apache.org/jira/browse/KAFKA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18627: --- Labels: need-kip (was: ) > add allowed modules to JaasUtils > -

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

lianetm commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1947203398 ## docs/upgrade.html: ## @@ -89,6 +89,27 @@ Notable changes in 4 Broker +The new Consum

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

lianetm commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1947202768 ## docs/upgrade.html: ## @@ -89,6 +89,27 @@ Notable changes in 4 Broker +The new Consum

[jira] [Assigned] (KAFKA-18627) add allowed modules to JaasUtils

[ https://issues.apache.org/jira/browse/KAFKA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18627: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > add allowed modules to JaasUtils >

Re: [PR] KAFKA-18607 - migrated jfreechart from jfreechart to org.jfreechart [kafka]

shubham-s-del closed pull request #18841: KAFKA-18607 - migrated jfreechart from jfreechart to org.jfreechart URL: https://github.com/apache/kafka/pull/18841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (KAFKA-18760) Consider to deprecate Optional and return String from public EndPoint#Listener

[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu updated KAFKA-18760: Summary: Consider to deprecate Optional and return String from public EndPoint#Listener (was: Consider t

[jira] [Updated] (KAFKA-18760) Deprecate Optional and return String from public EndPoint#Listener

[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu updated KAFKA-18760: Summary: Deprecate Optional and return String from public EndPoint#Listener (was: Consider to deprecate

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947194285 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18654[2/2]: Transction V2 retry add partitions on the server side when handling produce request. [kafka]

jolshan commented on code in PR #18810: URL: https://github.com/apache/kafka/pull/18810#discussion_r1947135137 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2252,6 +2252,75 @@ class ReplicaManagerTest { } } + @ParameterizedTest + @EnumSour

Re: [PR] KAFKA-18654[2/2]: Transction V2 retry add partitions on the server side when handling produce request. [kafka]

jolshan commented on code in PR #18810: URL: https://github.com/apache/kafka/pull/18810#discussion_r1947135137 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2252,6 +2252,75 @@ class ReplicaManagerTest { } } + @ParameterizedTest + @EnumSour

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

mumrah commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2644336340 There's an unrelated javadoc error causing the step to fail. From the logs ``` 2025-02-07T18:56:50.9446556Z 2025-02-07T18:56:50.9449623Z FAILURE: Build failed with an exception

[jira] [Updated] (KAFKA-18573) Add support for OAuth jwt_bearer grant type

[ https://issues.apache.org/jira/browse/KAFKA-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18573: -- Summary: Add support for OAuth jwt_bearer grant type (was: Improve OAuth client logic to support more

[PR] MINOR: cleanup KStream JavaDocs (11/N) - stream-stream-left-join [kafka]

mjsax opened a new pull request, #18836: URL: https://github.com/apache/kafka/pull/18836 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

lianetm commented on PR #18756: URL: https://github.com/apache/kafka/pull/18756#issuecomment-2644174306 All comments addressed, and created the GA release notes with more details (linked from the upgrade notes) https://cwiki.apache.org/confluence/display/KAFKA/The+Next+Generation+of+the+Con

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax commented on PR #18747: URL: https://github.com/apache/kafka/pull/18747#issuecomment-2644185694 Java 17: ``` Found 2 flaky test failures: FLAKY ⚠️ ReplicationQuotasTest > initializationError FLAKY ⚠️ RequestQuotaTest > initializationError ``` Java 23: ``` Found

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax merged PR #18747: URL: https://github.com/apache/kafka/pull/18747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join [kafka]

bbejeck commented on code in PR #18813: URL: https://github.com/apache/kafka/pull/18813#discussion_r1947234658 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2074,283 +2080,54 @@ KStream join(final KTable table, *

Re: [PR] MINOR: cleanup KStream JavaDocs (9/N) - flatMap[Values] [kafka]

mjsax merged PR #18805: URL: https://github.com/apache/kafka/pull/18805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: cleanup KStream JavaDocs (9/N) - flatMap[Values] [kafka]

mjsax commented on PR #18805: URL: https://github.com/apache/kafka/pull/18805#issuecomment-2644260559 Java 17: ``` Found 4 flaky test failures: FLAKY ⚠️ CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() FLAKY ⚠️ AbstractCoordinatorTest > testWakeupAfterSy

Re: [PR] MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join [kafka]

mjsax commented on PR #18813: URL: https://github.com/apache/kafka/pull/18813#issuecomment-2644425018 Java 17: ``` Found 2 flaky test failures: FLAKY ⚠️ CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() FLAKY ⚠️ KRaftClusterTest > testDescribeQuorumReques

Re: [PR] MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join [kafka]

mjsax merged PR #18813: URL: https://github.com/apache/kafka/pull/18813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18627:add allowed modules to JaasUtils [kafka]

gongxuanzhang commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r1947403553 ## clients/src/main/java/org/apache/kafka/common/security/JaasContext.java: ## @@ -103,12 +104,31 @@ else if (contextModules.length != 1) return defa

Re: [PR] KAFKA-15995: Adding KIP-877 support to Connect [kafka]

mimaison commented on code in PR #17804: URL: https://github.com/apache/kafka/pull/17804#discussion_r194700 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java: ## @@ -63,6 +64,11 @@ public void raiseError(Exception e) { her

Re: [PR] Refactor heartbeat response to include standbys [kafka]

bbejeck commented on PR #18827: URL: https://github.com/apache/kafka/pull/18827#issuecomment-2643704863 Thanks for the reviews @cadonna and @lucasbru - I've addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Resolved] (KAFKA-17644) TLA+ spec modifications

[ https://issues.apache.org/jira/browse/KAFKA-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang resolved KAFKA-17644. -- Resolution: Fixed > TLA+ spec modifications > --- > > Key:

[PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

mjsax opened a new pull request, #18835: URL: https://github.com/apache/kafka/pull/18835 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: Fix streams smoke test flush records [kafka]

mjsax commented on PR #18830: URL: https://github.com/apache/kafka/pull/18830#issuecomment-2644152619 Cherry-picked this fix to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947194285 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] Refactor heartbeat response to include standbys [kafka]

bbejeck commented on code in PR #18827: URL: https://github.com/apache/kafka/pull/18827#discussion_r1946972414 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apach

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

junrao commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2644228905 @kirktrue : Thanks. Do you know why two of the builds were red? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

junrao commented on code in PR #18804: URL: https://github.com/apache/kafka/pull/18804#discussion_r1947187901 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java: ## @@ -74,4 +87,62 @@ public static void validateRotatedMapEquals( ass

Re: [PR] Refactor heartbeat response to include standbys [kafka]

bbejeck commented on code in PR #18827: URL: https://github.com/apache/kafka/pull/18827#discussion_r1946995780 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/taskassignor/StickyTaskAssignorTest.java: ## @@ -18,6 +18,7 @@ package org.apache.kafka.coordinat

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947132452 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Created] (KAFKA-18760) Consider to remove Optional from public EndPoint

TaiJuWu created KAFKA-18760: --- Summary: Consider to remove Optional from public EndPoint Key: KAFKA-18760 URL: https://issues.apache.org/jira/browse/KAFKA-18760 Project: Kafka Issue Type: Improvemen

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947132948 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1947077467 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -414,7 +415,15 @@ private void process(final ResetOffs

[jira] [Updated] (KAFKA-18627) add allowed modules to JaasUtils

[ https://issues.apache.org/jira/browse/KAFKA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18627: --- Fix Version/s: 4.1.0 (was: 4.0.0) > add allowed modules to JaasUtils

Re: [PR] KAFKA-18627:add allowed modules to JaasUtils [kafka]

chia7712 commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r1947202861 ## clients/src/main/java/org/apache/kafka/common/security/JaasContext.java: ## @@ -103,12 +104,31 @@ else if (contextModules.length != 1) return defaultCo

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1946904610 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -414,7 +415,15 @@ private void process(final ResetO

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

chia7712 commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1946881984 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[jira] [Commented] (KAFKA-16320) CreateTopics, DeleteTopics and CreatePartitions differences between Zookeeper and KRaft

[ https://issues.apache.org/jira/browse/KAFKA-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924963#comment-17924963 ] Emanuele Sabellico commented on KAFKA-16320: Found the corresponding KIP:  i

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

chia7712 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1946886539 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,38 @@ private boolean canConvertToRelativeOffset(long offset) thro

[jira] [Commented] (KAFKA-18759) The replicas followers may create mismatches indexes

[ https://issues.apache.org/jira/browse/KAFKA-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924964#comment-17924964 ] Chia-Ping Tsai commented on KAFKA-18759: 4.0 has no such bug as it was fixed by

[jira] [Created] (KAFKA-18759) The replicas followers may create mismatches indexes

Chia-Ping Tsai created KAFKA-18759: -- Summary: The replicas followers may create mismatches indexes Key: KAFKA-18759 URL: https://issues.apache.org/jira/browse/KAFKA-18759 Project: Kafka Iss

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

junrao commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1946918497 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,38 @@ private boolean canConvertToRelativeOffset(long offset) throws

[jira] [Commented] (KAFKA-18758) NullPointerException in shutdown following InvalidConfigurationException

[ https://issues.apache.org/jira/browse/KAFKA-18758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924969#comment-17924969 ] Edoardo Comar commented on KAFKA-18758: --- same on 4.0 branch   [2025-02-07 17:40:

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2643591288 commit also cherry picks cleanly on 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (KAFKA-18758) NullPointerException in shutdown following InvalidConfigurationException

[ https://issues.apache.org/jira/browse/KAFKA-18758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924969#comment-17924969 ] Edoardo Comar edited comment on KAFKA-18758 at 2/7/25 5:43 PM: ---

[jira] [Updated] (KAFKA-18758) NullPointerException in shutdown following InvalidConfigurationException

[ https://issues.apache.org/jira/browse/KAFKA-18758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-18758: -- Affects Version/s: 4.0.0 4.1.0 > NullPointerException in shutdown follo

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

chia7712 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1946945523 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,38 @@ private boolean canConvertToRelativeOffset(long offset) thro

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

mimaison commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1946948278 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

Re: [PR] Refactor heartbeat response to include standbys [kafka]

bbejeck commented on code in PR #18827: URL: https://github.com/apache/kafka/pull/18827#discussion_r1946950485 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apach

Re: [PR] MINOR: cleanup KStream JavaDocs (9/N) - flatMap[Values] [kafka]

lucasbru commented on code in PR #18805: URL: https://github.com/apache/kafka/pull/18805#discussion_r1946880377 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -283,89 +283,47 @@ KStream map(final KeyValueMapper - * The provided {@link KeyValu

Re: [PR] MINOR: Fix streams smoke test flush records [kafka]

lucasbru merged PR #18830: URL: https://github.com/apache/kafka/pull/18830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

ijuma commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947155710 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947166952 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… [kafka]

github-actions[bot] commented on PR #18762: URL: https://github.com/apache/kafka/pull/18762#issuecomment-2644456317 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-18759) The replicas followers may create mismatches indexes

[ https://issues.apache.org/jira/browse/KAFKA-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925115#comment-17925115 ] PoAn Yang commented on KAFKA-18759: --- Hi [~chia7712], thanks for filing the issue. I wi

[jira] [Assigned] (KAFKA-18759) The replicas followers may create mismatches indexes

[ https://issues.apache.org/jira/browse/KAFKA-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18759: - Assignee: PoAn Yang (was: Chia-Ping Tsai) > The replicas followers may create mismatches index

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1947492571 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -414,7 +415,15 @@ private void process(final ResetO

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

m1a2st commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1947493458 ## docs/upgrade.html: ## @@ -89,6 +89,29 @@ Notable changes in 4 Broker +The new group c

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1947493357 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -234,7 +239,10 @@ private void process(final AsyncC

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1947492932 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java: ## @@ -117,6 +117,14 @@ public String rackId() { return ra

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947132452 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947132948 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

ijuma commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947143747 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947149658 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

TaiJuWu commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947149658 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

chia7712 commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947179714 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[jira] [Updated] (KAFKA-18760) Consider to remove Optional from public EndPoint

[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu updated KAFKA-18760: Labels: need-kip (was: ) > Consider to remove Optional from public EndPoint > ---

[PR] KAFKA-16720: Support multiple groups in DescribeShareGroupOffsets RPC [kafka]

AndrewJSchofield opened a new pull request, #18834: URL: https://github.com/apache/kafka/pull/18834 Add support for multiple groups in the DescribeShareGroupOffsets RPC. The admin client method supports multiple groups, but the RPC does not. Trivially extending the RPC definition aligns the

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

chia7712 commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1947182256 ## server/src/main/java/org/apache/kafka/network/EndPoint.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[PR] Fix an incorrect assignment in StreamsUncaughtExceptionHandlerIntegrationTest [kafka]

cushon opened a new pull request, #18837: URL: https://github.com/apache/kafka/pull/18837 This constructor was not initializing a field with the constructor argument, the extra `} {` was ending the constructor body and creating an instance initializer block that assigned the field to itself

Re: [PR] KAFKA-18745: Handle network related errors in persister. [kafka]

AndrewJSchofield commented on code in PR #18824: URL: https://github.com/apache/kafka/pull/18824#discussion_r1946219601 ## server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java: ## @@ -356,16 +367,48 @@ public void onComplete(ClientRespon

[jira] [Updated] (KAFKA-18754) Allow PlainSaslServer to pass client info through the negotiated properties.

[ https://issues.apache.org/jira/browse/KAFKA-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18754: Fix Version/s: (was: 4.0.0) (was: 3.9.1) (was: 3.

[jira] [Updated] (KAFKA-18754) Allow PlainSaslServer to pass client info through the negotiated properties.

[ https://issues.apache.org/jira/browse/KAFKA-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18754: Affects Version/s: 3.8.1 3.7.2 3.9.0 > Allow PlainSa

[jira] [Commented] (KAFKA-18754) Allow PlainSaslServer to pass client info through the negotiated properties.

[ https://issues.apache.org/jira/browse/KAFKA-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924803#comment-17924803 ] David Jacot commented on KAFKA-18754: - I filled in the affects versions field and re

[jira] [Updated] (KAFKA-18298) Fix flaky PlaintextAdminIntegrationTest#testConsumerGroupsDeprecatedConsumerGroupState

[ https://issues.apache.org/jira/browse/KAFKA-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18298: Priority: Major (was: Blocker) > Fix flaky > PlaintextAdminIntegrationTest#testConsumerGroupsDep

[jira] [Updated] (KAFKA-18297) Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups

[ https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18297: Priority: Major (was: Blocker) > Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups > ---

[jira] [Commented] (KAFKA-18297) Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups

[ https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924807#comment-17924807 ] David Jacot commented on KAFKA-18297: - The PR is still ongoing. It is clear that the

[jira] [Commented] (KAFKA-18298) Fix flaky PlaintextAdminIntegrationTest#testConsumerGroupsDeprecatedConsumerGroupState

[ https://issues.apache.org/jira/browse/KAFKA-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924806#comment-17924806 ] David Jacot commented on KAFKA-18298: - The PR is still ongoing. It is clear that the

[jira] [Created] (KAFKA-18755) Align timeout in kafka-share-groups.sh with other group-related tools

Andrew Schofield created KAFKA-18755: Summary: Align timeout in kafka-share-groups.sh with other group-related tools Key: KAFKA-18755 URL: https://issues.apache.org/jira/browse/KAFKA-18755 Project

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

JimmyWang6 commented on PR #18819: URL: https://github.com/apache/kafka/pull/18819#issuecomment-2642418590 @apoorvmittal10 @AndrewJSchofield I have completed the basic part of AdminClient.alterShareGroupOffsets Please take a look when you have time. Thanks! -- This is an automated mes

Re: [PR] Refactor heartbeat response to include standbys [kafka]

lucasbru commented on code in PR #18827: URL: https://github.com/apache/kafka/pull/18827#discussion_r1946213076 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java: ## @@ -292,6 +292,22 @@ void testSuccessfulResponse(

Re: [PR] KAFKA-18745: Handle network related errors in persister. [kafka]

smjn commented on code in PR #18824: URL: https://github.com/apache/kafka/pull/18824#discussion_r1946270238 ## server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java: ## @@ -356,16 +367,48 @@ public void onComplete(ClientResponse response)

  1   2   >