kirktrue commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2644022430
> @kirktrue : Thanks for updated PR. The code LGTM. Are the flaky test failure related to this PR? > > ``` > FLAKY ⚠️ EagerConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() > FLAKY ⚠️ StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription(boolean).hasConsumerRack = false > FLAKY ⚠️ UserQuotaTest > testThrottledProducerConsumer(String, String).quorum=kraft.groupProtocol=classic > FLAKY ⚠️ ClientIdQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=consumer > FLAKY ⚠️ ReplicationQuotasTest > initializationError > FLAKY ⚠️ RequestQuotaTest > initializationError > ``` I don't believe so, no. They're part of the flaky gang that I see even on `trunk` builds still 😞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org