mjsax commented on PR #18106: URL: https://github.com/apache/kafka/pull/18106#issuecomment-2644031334
@jayteej @divijvaidya This PR did break two of our Kafka Streams system tests. And the changes you put into the KS integrations test where not really "correct". Cf https://github.com/apache/kafka/pull/18830 It's already fixed, so no action needed, but I think it would be ideal to asked for a review from somebody who knows the KS code base (same applies to other component like Connect, ect) when you change stuff in this part of the code. It took us many hours to identify the problem of the failing system test what could have been avoided if we were aware of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
