[jira] [Created] (KAFKA-18432) Remove AutoTopicCreationManager

2025-01-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18432: -- Summary: Remove AutoTopicCreationManager Key: KAFKA-18432 URL: https://issues.apache.org/jira/browse/KAFKA-18432 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
frankvicky commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2575260003 Hi @AndrewJSchofield @chia7712 Since the KIP has been accepted, I think we could merge this one. WDYT? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-01-07 Thread via GitHub
m1a2st commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r1905417391 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String payloadDelimi

Re: [PR] KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig [kafka]

2025-01-07 Thread via GitHub
chia7712 merged PR #18352: URL: https://github.com/apache/kafka/pull/18352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala [kafka]

2025-01-07 Thread via GitHub
chia7712 merged PR #17365: URL: https://github.com/apache/kafka/pull/17365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15057: Use new interface from zstd-jni [kafka]

2025-01-07 Thread via GitHub
mimaison commented on PR #13814: URL: https://github.com/apache/kafka/pull/13814#issuecomment-2575469133 This seemed like a potential significant performance improvement. Any specific reason you're abandoning this change? If it's due to lack of time, we may want to find if anybody else is i

[PR] KAFKA-18415: Fix for event queue metric and flaky test [kafka]

2025-01-07 Thread via GitHub
lianetm opened a new pull request, #18416: URL: https://github.com/apache/kafka/pull/18416 Fix for flaky unit test. The test used to fail when asserting the queue size metric after adding an event, because of a race condition (the background thread could have set the metric back to 0 when p

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1905584608 ## build.gradle: ## @@ -1326,6 +1326,42 @@ project(':core') { from(project(':tools:tools-api').jar) { into("libs/") } from(project(':tools:tools-api').config

Re: [PR] KAFKA-17921: Support SASL_PLAINTEXT protocol with java.security.auth.login.config [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #17671: URL: https://github.com/apache/kafka/pull/17671#discussion_r1905589260 ## test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -176,6 +179,15 @@ private KafkaConfig createNodeConfig(TestKitNode node) thr

[jira] [Created] (KAFKA-18434) enrich the authorization error message of connecting to controller

2025-01-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18434: -- Summary: enrich the authorization error message of connecting to controller Key: KAFKA-18434 URL: https://issues.apache.org/jira/browse/KAFKA-18434 Project: Kafka

Re: [PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2025-01-07 Thread via GitHub
mimaison commented on code in PR #18094: URL: https://github.com/apache/kafka/pull/18094#discussion_r1905622701 ## raft/src/main/java/org/apache/kafka/raft/TimingWheelExpirationService.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Resolved] (KAFKA-18380) Remove KafkaApisTest `raftSupport` and change test to Kraft mode

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18380. - Resolution: Duplicate > Remove KafkaApisTest `raftSupport` and change test to Kraft mode > -

[jira] [Commented] (KAFKA-18380) Remove KafkaApisTest `raftSupport` and change test to Kraft mode

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910662#comment-17910662 ] 黃竣陽 commented on KAFKA-18380: - This Jira would be merge into https://issues.apache.org/jira/

Re: [PR] KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1905622310 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -1005,4 +1023,20 @@ class ControllerApis(val requestChannel: RequestChannel, } } } +

[PR] MINOR: Remove Sanitizer document with zookeeper description [kafka]

2025-01-07 Thread via GitHub
m1a2st opened a new pull request, #18420: URL: https://github.com/apache/kafka/pull/18420 As we depreacate Zk in Kafka 4.0, we should clean the document with zk description. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Veri

[jira] [Created] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-07 Thread Jira
黃竣陽 created KAFKA-18435: --- Summary: Remove zookeeper dependencies in build.gradle Key: KAFKA-18435 URL: https://issues.apache.org/jira/browse/KAFKA-18435 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18435: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove zookeeper dependencies in build.grad

Re: [PR] KAFKA-13093: Log compaction should write new segments with record version v2 (KIP-724) [kafka]

2025-01-07 Thread via GitHub
junrao commented on code in PR #18321: URL: https://github.com/apache/kafka/pull/18321#discussion_r1905814075 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -509,8 +509,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private def initializeLeaderEpoc

Re: [PR] KAFKA-18415: Fix for event queue metric and flaky test [kafka]

2025-01-07 Thread via GitHub
lianetm commented on PR #18416: URL: https://github.com/apache/kafka/pull/18416#issuecomment-2575853893 This doesn't affect the unit test in `BackgroundEventHandlerTest` in the same way because the the app thread does not automatically remove from the background event queue (it requires exp

[jira] [Updated] (KAFKA-18216) High water mark or last stable offset aren't always updated after a fetch request is completed

2025-01-07 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18216: --- Labels: consumer-threading-refactor (was: ) > High water mark or last stable offset aren't

[jira] [Commented] (KAFKA-18398) Log a warning if actual topic configs are inconsistent with the required topic configs

2025-01-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910552#comment-17910552 ] Lucas Brutschy commented on KAFKA-18398: Yes, we could make this slightly less a

Re: [PR] MINOR: Fix typo in CommitRequestManager [kafka]

2025-01-07 Thread via GitHub
dajac merged PR #18407: URL: https://github.com/apache/kafka/pull/18407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18427) Remove KafkaZkClient and ZooKeeperClient

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18427: Summary: Remove KafkaZkClient and ZooKeeperClient (was: Remove KafkaZkClient) > Remove KafkaZkClient and ZooKeep

[jira] [Created] (KAFKA-18427) Remove KafkaZkClient

2025-01-07 Thread Jira
黃竣陽 created KAFKA-18427: --- Summary: Remove KafkaZkClient Key: KAFKA-18427 URL: https://issues.apache.org/jira/browse/KAFKA-18427 Project: Kafka Issue Type: Improvement Reporter: 黃竣陽

[jira] [Updated] (KAFKA-18429) Remove ZkFinalizedFeatureCache

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18429: Parent: KAFKA-17611 Issue Type: Sub-task (was: Bug) > Remove ZkFinalizedFeatureCache > --

[jira] [Created] (KAFKA-18429) Remove ZkFinalizedFeatureCache

2025-01-07 Thread Jira
黃竣陽 created KAFKA-18429: --- Summary: Remove ZkFinalizedFeatureCache Key: KAFKA-18429 URL: https://issues.apache.org/jira/browse/KAFKA-18429 Project: Kafka Issue Type: Bug Reporter: 黃竣陽

[jira] [Updated] (KAFKA-18430) Remove ZkNodeChangeNotificationListener

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18430: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove ZkNodeChangeNotificationListener > -

[jira] [Updated] (KAFKA-18427) Remove KafkaZkClient and ZooKeeperClient

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18427: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove KafkaZkClient and ZooKeeperClient >

[jira] [Created] (KAFKA-18428) Measure share consumers performance

2025-01-07 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-18428: - Summary: Measure share consumers performance Key: KAFKA-18428 URL: https://issues.apache.org/jira/browse/KAFKA-18428 Project: Kafka Issue Type: Sub-task

[PR] MINOR: Replace ImplicitConversions with CollectionConverters [kafka]

2025-01-07 Thread via GitHub
frankvicky opened a new pull request, #18412: URL: https://github.com/apache/kafka/pull/18412 `ImplicitConversion` has been deprecated since Scala 2.13, we should replace it with `CollectionConverters` Reference: https://www.scala-lang.org/api/2.13.9/scala/collection/convert/ImplicitConv

[jira] [Created] (KAFKA-18430) Remove ZkNodeChangeNotificationListener

2025-01-07 Thread Jira
黃竣陽 created KAFKA-18430: --- Summary: Remove ZkNodeChangeNotificationListener Key: KAFKA-18430 URL: https://issues.apache.org/jira/browse/KAFKA-18430 Project: Kafka Issue Type: Improvement Rep

[jira] [Commented] (KAFKA-18413) Remove AdminZkClient

2025-01-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910597#comment-17910597 ] 黃竣陽 commented on KAFKA-18413: - Should also remove TopicAlreadyMarkedForDeletionException >

[jira] [Commented] (KAFKA-18297) Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups

2025-01-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910601#comment-17910601 ] David Jacot commented on KAFKA-18297: - I have a PR for fix one case: [https://github

Re: [PR] KAFKA-18384 Remove ZkAlterPartitionManager [kafka]

2025-01-07 Thread via GitHub
m1a2st commented on PR #18364: URL: https://github.com/apache/kafka/pull/18364#issuecomment-2575152665 Thanks for @mimaison review, addressed all comments :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] KAFKA-18411 Remove ZkProducerIdManager [kafka]

2025-01-07 Thread via GitHub
m1a2st opened a new pull request, #18413: URL: https://github.com/apache/kafka/pull/18413 Jira: https://issues.apache.org/jira/browse/KAFKA-18411 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[jira] [Updated] (KAFKA-18413) Remove AdminZkClient and TopicAlreadyMarkedForDeletionException

2025-01-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18413: Summary: Remove AdminZkClient and TopicAlreadyMarkedForDeletionException (was: Remove AdminZkClie

[jira] [Commented] (KAFKA-18413) Remove AdminZkClient

2025-01-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910606#comment-17910606 ] TengYao Chi commented on KAFKA-18413: - You're right, I will add it to this ticket.

Re: [PR] Bump the default Consumer group command timeout default to 30 sec [kafka]

2025-01-07 Thread via GitHub
omkreddy merged PR #16406: URL: https://github.com/apache/kafka/pull/16406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-18360) Remove config in ZkConfigs, ZKConfig, and ZKClientConfig

2025-01-07 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18360: -- Summary: Remove config in ZkConfigs, ZKConfig, and ZKClientConfig (was: Remove config in ZkConfigs)

Re: [PR] MINOR: Remove RaftManager.maybeDeleteMetadataLogDir [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on PR #17365: URL: https://github.com/apache/kafka/pull/17365#issuecomment-2575265039 oh, sorry that the PR I just merge causes the conflicts on `AutoTopicCreationManagerTest.scala`. I will fix the conflicts and then merge this PR since the `AutoTopicCreationManagerTest.s

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
AndrewJSchofield commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2575281857 @frankvicky It is unfortunate this behaviour change didn't make the 4.0 deadline. Personally, because the old behaviour was liable to cause deadlocks, I'm good with making such a

[jira] [Assigned] (KAFKA-18432) Remove AutoTopicCreationManager

2025-01-07 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Logan Zhu reassigned KAFKA-18432: - Assignee: Logan Zhu (was: Chia-Ping Tsai) > Remove AutoTopicCreationManager >

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
AndrewJSchofield commented on code in PR #17946: URL: https://github.com/apache/kafka/pull/17946#discussion_r1905447643 ## docs/upgrade.html: ## @@ -202,6 +202,8 @@ Notable changes in 4 The deprecated sendOffsetsToTransaction(M

Re: [PR] MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups [kafka]

2025-01-07 Thread via GitHub
dajac merged PR #18409: URL: https://github.com/apache/kafka/pull/18409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-18412) Remove EmbeddedZookeeper

2025-01-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18412. Resolution: Fixed > Remove EmbeddedZookeeper > > >

Re: [PR] KAFKA-18412: Remove EmbeddedZookeeper [kafka]

2025-01-07 Thread via GitHub
mimaison commented on PR #18399: URL: https://github.com/apache/kafka/pull/18399#issuecomment-2575720963 Applied to 4.0: https://github.com/apache/kafka/commit/8b6f8cf60dabc25192aeff68d46b82e7a4d36ad8 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] KAFKA-18418: Use CDL to block the thread termination to avoid flaky tests [kafka]

2025-01-07 Thread via GitHub
aoli-al opened a new pull request, #18418: URL: https://github.com/apache/kafka/pull/18418 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* This PR fixes [KAF

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
AndrewJSchofield merged PR #17946: URL: https://github.com/apache/kafka/pull/17946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2025-01-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-10790. -- Resolution: Fixed > Detect/Prevent Deadlock on Producer Network Thread > -

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (part 1) [kafka]

2025-01-07 Thread via GitHub
m1a2st commented on code in PR #18417: URL: https://github.com/apache/kafka/pull/18417#discussion_r1905629931 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -9705,77 +9514,6 @@ class KafkaApisTest extends Logging { assertEquals(expectedError, leaderAndI

[PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (part 1) [kafka]

2025-01-07 Thread via GitHub
m1a2st opened a new pull request, #18417: URL: https://github.com/apache/kafka/pull/18417 Jira: https://issues.apache.org/jira/browse/KAFKA-18399 I will check these test is valid in Kraft, if it is replies on zookeeper, I will remove it. - `shouldNotResignCoordinatorsIfStopReplicaR

Re: [PR] KAFKA-17921: Support SASL_PLAINTEXT protocol with java.security.auth.login.config [kafka]

2025-01-07 Thread via GitHub
FrankYang0529 commented on code in PR #17671: URL: https://github.com/apache/kafka/pull/17671#discussion_r1905618223 ## test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java: ## @@ -331,4 +344,111 @@ public void testControllerL

[PR] KAFKA-18428: Measure share consumers performance [kafka]

2025-01-07 Thread via GitHub
adixitconfluent opened a new pull request, #18415: URL: https://github.com/apache/kafka/pull/18415 ### About Added code to measure performance of share consumer/consumers in a share group.Added the following files - 1. `ShareConsumerPerformance.java` - Code which measures the perf

Re: [PR] KAFKA-15057: Use new interface from zstd-jni [kafka]

2025-01-07 Thread via GitHub
divijvaidya closed pull request #13814: KAFKA-15057: Use new interface from zstd-jni URL: https://github.com/apache/kafka/pull/13814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #17946: URL: https://github.com/apache/kafka/pull/17946#discussion_r1905457391 ## docs/upgrade.html: ## @@ -202,6 +202,8 @@ Notable changes in 4 The deprecated sendOffsetsToTransaction(Map

Re: [PR] Minor : Improve Exception log [kafka]

2025-01-07 Thread via GitHub
omkreddy merged PR #12394: URL: https://github.com/apache/kafka/pull/12394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18418) Flaky test in KafkaStreamsTest::shouldThrowOnCleanupWhileShuttingDownStreamClosedWithCloseOptionLeaveGroupFalse

2025-01-07 Thread Ao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910687#comment-17910687 ] Ao Li commented on KAFKA-18418: --- [~mjsax] Thanks for your comments! I've submitted a new P

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-07 Thread via GitHub
m1a2st commented on code in PR #18050: URL: https://github.com/apache/kafka/pull/18050#discussion_r1905777105 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -196,6 +198,14 @@ public NetworkClientDelegate.PollResult poll(fina

Re: [PR] MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups [kafka]

2025-01-07 Thread via GitHub
dajac commented on PR #18409: URL: https://github.com/apache/kafka/pull/18409#issuecomment-2575439307 Merged to trunk and to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #17099: URL: https://github.com/apache/kafka/pull/17099#discussion_r1905466781 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1546,6 +1547,7 @@ private AppendCallbacks(Callback userCallback, ProducerInterce

Re: [PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2025-01-07 Thread via GitHub
divijvaidya commented on code in PR #18094: URL: https://github.com/apache/kafka/pull/18094#discussion_r1905471308 ## raft/src/main/java/org/apache/kafka/raft/TimingWheelExpirationService.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] MINOR: improvement MetadataShell to use System.out.println [kafka]

2025-01-07 Thread via GitHub
m1a2st closed pull request #18117: MINOR: improvement MetadataShell to use System.out.println URL: https://github.com/apache/kafka/pull/18117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] KAFKA-18397: Added null check before sending background event from ShareConsumeRequestManager. [kafka]

2025-01-07 Thread via GitHub
ShivsundarR opened a new pull request, #18419: URL: https://github.com/apache/kafka/pull/18419 *What* Added a null check for acknowledgements before sending background event from ShareConsumeRequestManager. Added a unit test which verifies the change. -- This is an automated messag

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-01-07 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r1905788910 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String pay

Re: [PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2025-01-07 Thread via GitHub
mimaison commented on code in PR #18094: URL: https://github.com/apache/kafka/pull/18094#discussion_r1905794800 ## raft/src/main/java/org/apache/kafka/raft/TimingWheelExpirationService.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2025-01-07 Thread via GitHub
mimaison commented on code in PR #18094: URL: https://github.com/apache/kafka/pull/18094#discussion_r1905795147 ## raft/src/main/java/org/apache/kafka/raft/TimingWheelExpirationService.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-18384 Remove ZkAlterPartitionManager [kafka]

2025-01-07 Thread via GitHub
mimaison merged PR #18364: URL: https://github.com/apache/kafka/pull/18364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18368) Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig

2025-01-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18368. Fix Version/s: 4.0.0 Resolution: Fixed trunk: https://github.com/apache/kafka/comm

[jira] [Commented] (KAFKA-18297) Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups

2025-01-07 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910634#comment-17910634 ] Mingdao Yang commented on KAFKA-18297: -- [~dajac] The GitHub URL has an extra period

[jira] [Created] (KAFKA-18431) Remove KafkaController

2025-01-07 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18431: - Summary: Remove KafkaController Key: KAFKA-18431 URL: https://issues.apache.org/jira/browse/KAFKA-18431 Project: Kafka Issue Type: Sub-task Reporter: P

Re: [PR] MINOR: Remove RaftManager.maybeDeleteMetadataLogDir [kafka]

2025-01-07 Thread via GitHub
mimaison commented on PR #17365: URL: https://github.com/apache/kafka/pull/17365#issuecomment-2575187788 The test failure is https://issues.apache.org/jira/browse/KAFKA-18297, so it's not related to this PR. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Created] (KAFKA-18433) Adjust ShareFetchRequest RPC to optimise fetching and acknowledgement

2025-01-07 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18433: Summary: Adjust ShareFetchRequest RPC to optimise fetching and acknowledgement Key: KAFKA-18433 URL: https://issues.apache.org/jira/browse/KAFKA-18433 Project

Re: [PR] MINOR: Delete unused local var `oldConfig` in `LocalLog.java` [kafka]

2025-01-07 Thread via GitHub
divijvaidya merged PR #18410: URL: https://github.com/apache/kafka/pull/18410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

2025-01-07 Thread via GitHub
frankvicky commented on code in PR #17946: URL: https://github.com/apache/kafka/pull/17946#discussion_r1905476456 ## docs/upgrade.html: ## @@ -202,6 +202,8 @@ Notable changes in 4 The deprecated sendOffsetsToTransaction(Map

Re: [PR] KAFKA-17921: Support SASL_PLAINTEXT protocol with java.security.auth.login.config [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on code in PR #17671: URL: https://github.com/apache/kafka/pull/17671#discussion_r1905506205 ## test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -602,6 +637,13 @@ public void close() throws Exception { waitFor

Re: [PR] Revert Multiversioning Changes from 4.0 release. [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on PR #18411: URL: https://github.com/apache/kafka/pull/18411#issuecomment-2575386897 @snehashisp could you please add the jira number to the title? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18412: Remove EmbeddedZookeeper [kafka]

2025-01-07 Thread via GitHub
mimaison merged PR #18399: URL: https://github.com/apache/kafka/pull/18399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18384) Remove ZkAlterPartitionManager

2025-01-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18384. Fix Version/s: 4.0.0 Resolution: Fixed > Remove ZkAlterPartitionManager >

[jira] [Created] (KAFKA-18436) Revert KIP-891 from 4.0 release

2025-01-07 Thread Greg Harris (Jira)
Greg Harris created KAFKA-18436: --- Summary: Revert KIP-891 from 4.0 release Key: KAFKA-18436 URL: https://issues.apache.org/jira/browse/KAFKA-18436 Project: Kafka Issue Type: Task Comp

[jira] [Updated] (KAFKA-18376) High CPU load when AsyncKafkaConsumer uses a small max poll value

2025-01-07 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18376: --- Labels: consumer-threading-refactor (was: ) > High CPU load when AsyncKafkaConsumer uses a

Re: [PR] KAFKA-18384 Remove ZkAlterPartitionManager [kafka]

2025-01-07 Thread via GitHub
mimaison commented on PR #18364: URL: https://github.com/apache/kafka/pull/18364#issuecomment-2575863864 Applied to 4.0: https://github.com/apache/kafka/commit/5bcbf247dfa85d4bdb552a59dcc00d0b7841c77b -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-13093: Log compaction should write new segments with record version v2 (KIP-724) [kafka]

2025-01-07 Thread via GitHub
junrao commented on code in PR #18321: URL: https://github.com/apache/kafka/pull/18321#discussion_r1905814075 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -509,8 +509,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private def initializeLeaderEpoc

[jira] [Updated] (KAFKA-18217) Slow HWM/LSO update might have subtle effect on the consumer lag reporting

2025-01-07 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18217: --- Labels: consumer-threading-refactor (was: ) > Slow HWM/LSO update might have subtle effect

Re: [PR] KAFKA-13093: Log compaction should write new segments with record version v2 (KIP-724) [kafka]

2025-01-07 Thread via GitHub
junrao commented on code in PR #18321: URL: https://github.com/apache/kafka/pull/18321#discussion_r1905822853 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -757,7 +769,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, leaderEpoch: Int,

Re: [PR] KAFKA-18436: Revert Multiversioning Changes from 4.0 release. [kafka]

2025-01-07 Thread via GitHub
gharris1727 merged PR #18411: URL: https://github.com/apache/kafka/pull/18411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Updated] (KAFKA-18120) KIP-891: Support for multiple versions of connect plugins.

2025-01-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-18120: Affects Version/s: 4.1.0 (was: 4.0.0) > KIP-891: Support for multiple v

[jira] [Updated] (KAFKA-18215) Accept plugin.version configurations for connector and converters

2025-01-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-18215: Fix Version/s: (was: 4.0.0) > Accept plugin.version configurations for connector and converter

[jira] [Commented] (KAFKA-17675) Add tests to RaftEventSimulationTest

2025-01-07 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910741#comment-17910741 ] Alyssa Huang commented on KAFKA-17675: -- Hey Mingdao, sorry for the late response. T

[jira] [Commented] (KAFKA-18215) Accept plugin.version configurations for connector and converters

2025-01-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910735#comment-17910735 ] Greg Harris commented on KAFKA-18215: - Reverted from 4.0 in KAFKA-18436 > Accept pl

[jira] [Created] (KAFKA-18437) Correct version of ShareUpdateValue record from v1 to v0

2025-01-07 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18437: Summary: Correct version of ShareUpdateValue record from v1 to v0 Key: KAFKA-18437 URL: https://issues.apache.org/jira/browse/KAFKA-18437 Project: Kafka

[jira] [Assigned] (KAFKA-18439) Add invariant to Raft simulation test for prevote

2025-01-07 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned KAFKA-18439: - Assignee: Peter Lee > Add invariant to Raft simulation test for prevote > -

Re: [PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2025-01-07 Thread via GitHub
divijvaidya commented on code in PR #18094: URL: https://github.com/apache/kafka/pull/18094#discussion_r1905940530 ## raft/src/main/java/org/apache/kafka/raft/SegmentPosition.java: ## @@ -14,10 +14,12 @@ * See the License for the specific language governing permissions and *

[jira] [Updated] (KAFKA-15057) Use new interface ZstdBufferDecompressingStreamNoFinalizer from zstd-jni

2025-01-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15057: - Fix Version/s: (was: 4.0.0) > Use new interface ZstdBufferDecompressingStreamNoFinalizer fro

[jira] [Updated] (KAFKA-15057) Use new interface ZstdBufferDecompressingStreamNoFinalizer from zstd-jni

2025-01-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15057: - Labels: performance (was: ) > Use new interface ZstdBufferDecompressingStreamNoFinalizer from z

Re: [PR] KAFKA-17921: Support SASL_PLAINTEXT protocol with java.security.auth.login.config [kafka]

2025-01-07 Thread via GitHub
chia7712 commented on PR #17671: URL: https://github.com/apache/kafka/pull/17671#issuecomment-2576076093 The failed tests are unrelated and they pass on my local -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-18436) Revert KIP-891 from 4.0 release

2025-01-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-18436. - Resolution: Fixed > Revert KIP-891 from 4.0 release > --- > >

[jira] [Updated] (KAFKA-18436) Revert KIP-891 from 4.0 release

2025-01-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-18436: Fix Version/s: 4.0.0 > Revert KIP-891 from 4.0 release > --- > >

[jira] [Commented] (KAFKA-18401) Transaction version 2 does not support commit transaction without records

2025-01-07 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910745#comment-17910745 ] Justine Olshan commented on KAFKA-18401: > where the EndTxnRequest is not sent i

[jira] [Updated] (KAFKA-16164) Pre-Vote 4.0 changes

2025-01-07 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang updated KAFKA-16164: - Summary: Pre-Vote 4.0 changes (was: Pre-Vote) > Pre-Vote 4.0 changes > > >

[PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2) [kafka]

2025-01-07 Thread via GitHub
TaiJuWu opened a new pull request, #18422: URL: https://github.com/apache/kafka/pull/18422 KRaft mode does not support follow RPC and this PR would remove them. - case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request) - case ApiKeys.STOP_REPLICA => handleStopReplicaReques

  1   2   3   >