junrao commented on code in PR #18321:
URL: https://github.com/apache/kafka/pull/18321#discussion_r1905822853
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -757,7 +769,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
leaderEpoch: Int,
requestLocal: Option[RequestLocal],
verificationGuard: VerificationGuard,
- ignoreRecordSize: Boolean): LogAppendInfo = {
+ ignoreRecordSize: Boolean,
+ toMagic: Byte = RecordBatch.CURRENT_MAGIC_VALUE):
LogAppendInfo = {
Review Comment:
There is some validation logic for v0/v1 records in `LogValidator`, which is
potentially useful for ingesting records of old format. So, we can keep this as
it is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
