chia7712 commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1905584608
########## build.gradle: ########## @@ -1326,6 +1326,42 @@ project(':core') { from(project(':tools:tools-api').jar) { into("libs/") } from(project(':tools:tools-api').configurations.runtimeClasspath) { into("libs/") } duplicatesStrategy 'exclude' + + doLast { + def prefixPath = "$rootDir/core/build/distributions/" + def bathPath = prefixPath + "kafka_${versions.baseScala}-${project.properties['version']}" + def tgzPath = bathPath + '.tgz' + exec { + commandLine 'tar', 'xzf', tgzPath, '-C', prefixPath + } + + def licenseFile = file(bathPath + '/LICENSE') + def libsDir = file(bathPath + '/libs') + def result = true + libsDir.eachFile { file -> + if (file.name.endsWith('.jar') + && !file.name.startsWith('kafka') + && !file.name.startsWith('connect') + && !file.name.startsWith('trogdor')) { + + def isLicensePresent = false + licenseFile.eachLine { line -> + if (line.contains(file.name - '.jar')) { + isLicensePresent = true + } + } + if (!isLicensePresent) { + println "warning: ${file.name} is missing in the license file" + result = false + } + } + } + + if (result) + println "LIBS LICENSE check succeed !" + else + println "LIBS LICENSE check failed !" Review Comment: should we mark the task failed to ensure developers have to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org