rajinisivaram commented on code in PR #17720:
URL: https://github.com/apache/kafka/pull/17720#discussion_r1835335844
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1236,6 +1316,12 @@ public void close() {
this.metadata.close();
rajinisivaram commented on PR #17720:
URL: https://github.com/apache/kafka/pull/17720#issuecomment-2466164414
@apoorvmittal10 Thanks for the review, I have responded to the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rajinisivaram commented on code in PR #17720:
URL: https://github.com/apache/kafka/pull/17720#discussion_r1835335426
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##
@@ -289,17 +304,24 @@ public void update(Cluster cluster, long now
rajinisivaram commented on code in PR #17720:
URL: https://github.com/apache/kafka/pull/17720#discussion_r1835335638
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -166,11 +169,51 @@ public NetworkClient(Selectable selector,
time,
kirktrue commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835554434
##
core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala:
##
@@ -43,8 +43,9 @@ class FetchRequestTestDowngrade extends BaseRequestTest {
chia7712 commented on code in PR #17734:
URL: https://github.com/apache/kafka/pull/17734#discussion_r1835604703
##
gradle/wrapper/gradle-wrapper.properties:
##
@@ -1,7 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionSha256Sum=682b4df7fe5a
[
https://issues.apache.org/jira/browse/KAFKA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896991#comment-17896991
]
Kamal Chandraprakash commented on KAFKA-17928:
--
[~peterxcli]
The KIP got
KTKTK-HZ commented on code in PR #16950:
URL: https://github.com/apache/kafka/pull/16950#discussion_r1835609331
##
build.gradle:
##
@@ -41,7 +41,7 @@ plugins {
id "com.github.spotbugs" version '6.0.25' apply false
id 'org.scoverage' version '8.0.3' apply false
- id 'io.
frankvicky opened a new pull request, #17736:
URL: https://github.com/apache/kafka/pull/17736
JIRA: KAFKA-17569
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentat
KTKTK-HZ commented on code in PR #16950:
URL: https://github.com/apache/kafka/pull/16950#discussion_r1835609331
##
build.gradle:
##
@@ -41,7 +41,7 @@ plugins {
id "com.github.spotbugs" version '6.0.25' apply false
id 'org.scoverage' version '8.0.3' apply false
- id 'io.
[
https://issues.apache.org/jira/browse/KAFKA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Lee reassigned KAFKA-17928:
-
Assignee: Peter Lee
> Make remote log manager thread-pool configs dynamic
> ---
chiacyu opened a new pull request, #17734:
URL: https://github.com/apache/kafka/pull/17734
As titled, please
[KAFKA-17974](https://issues.apache.org/jira/browse/KAFKA-17974) for further
details.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impleme
[
https://issues.apache.org/jira/browse/KAFKA-17975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17975:
--
Assignee: Kuan Po Tseng (was: Chia-Ping Tsai)
> Remove ControllerQuorumVotersFutureM
kamalcph commented on code in PR #17659:
URL: https://github.com/apache/kafka/pull/17659#discussion_r1835568807
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java:
##
@@ -209,4 +209,18 @@ void onPartitionLeadershipChanges(Set
l
kamalcph commented on code in PR #17659:
URL: https://github.com/apache/kafka/pull/17659#discussion_r1835568807
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java:
##
@@ -209,4 +209,18 @@ void onPartitionLeadershipChanges(Set
l
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835569444
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-
[
https://issues.apache.org/jira/browse/KAFKA-17975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896984#comment-17896984
]
Kuan Po Tseng commented on KAFKA-17975:
---
Gentle ping [~chia7712] , I can help on t
kamalcph opened a new pull request, #17735:
URL: https://github.com/apache/kafka/pull/17735
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
kamalcph commented on PR #17735:
URL: https://github.com/apache/kafka/pull/17735#issuecomment-2466566407
Could you share the instructions to preview the upgrade notes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835570270
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-
kamalcph commented on PR #17724:
URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466572792
The patch LGTM, will wait for the CI to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mjsax merged PR #17710:
URL: https://github.com/apache/kafka/pull/17710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
wperlichek commented on PR #17724:
URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466602270
> The patch LGTM, will wait for the CI to complete.
Thanks for the help. Looks like CI successfully completed!
--
This is an automated message from the Apache Git Service.
To r
chia7712 commented on code in PR #17712:
URL: https://github.com/apache/kafka/pull/17712#discussion_r1835596925
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2087,6 +2087,128 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
kamalcph merged PR #17724:
URL: https://github.com/apache/kafka/pull/17724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
PoAn Yang created KAFKA-17978:
-
Summary: StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces
system tests fail
Key: KAFKA-17978
URL: https://issues.apache.org/jira/browse/KAFKA-17978
Project: Kafka
FrankYang0529 commented on PR #17673:
URL: https://github.com/apache/kafka/pull/17673#issuecomment-2466613195
Hi @chia7712, I think this PR is ready.
* For `client_compatibility_features_test.py` and
`client_compatibility_produce_consume_test.py` failed cases, versions 2.1.1,
2.2.2,
kirktrue commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835553656
##
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##
@@ -204,10 +205,19 @@ abstract class QuorumTestHarness extends Logging {
TestInfoUtils
kamalcph commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1835574783
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2466582626
The patch LGTM. It needs second set of eyes as we are re-opening a closed
index. cc @showuon @satishd PTAL.
--
This is an automated message from the Apache Git Service.
To respond to
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835576053
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835576053
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-
Chia-Ping Tsai created KAFKA-17976:
--
Summary: Remove zk-only test: `FetchRequestTestDowngrade`
Key: KAFKA-17976
URL: https://issues.apache.org/jira/browse/KAFKA-17976
Project: Kafka
Issue T
chia7712 commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835561177
##
core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala:
##
@@ -43,8 +43,9 @@ class FetchRequestTestDowngrade extends BaseRequestTest {
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835561960
##
tests/kafkatest/services/performance/consumer_performance.py:
##
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic,
messages, version=DEV_
[
https://issues.apache.org/jira/browse/KAFKA-17976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Chuan Yu reassigned KAFKA-17976:
-
Assignee: Chia-Chuan Yu (was: Chia-Ping Tsai)
> Remove zk-only test: `FetchRequestTest
[
https://issues.apache.org/jira/browse/KAFKA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17925.
Resolution: Fixed
> Convert Kafka Client integration tests to use KRaft
>
chia7712 commented on PR #17670:
URL: https://github.com/apache/kafka/pull/17670#issuecomment-2466555239
`SaslPlainPlaintextConsumerTest`, `ConsumerBounceTest`,
`TransactionsExpirationTest` they pass on my local
--
This is an automated message from the Apache Git Service.
To respond to th
mjsax commented on PR #17710:
URL: https://github.com/apache/kafka/pull/17710#issuecomment-2466555064
Merged to `trunk` and cherry-picked to `3.9`, `3.8`, and `3.7` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
chia7712 merged PR #17670:
URL: https://github.com/apache/kafka/pull/17670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
m1a2st opened a new pull request, #17732:
URL: https://github.com/apache/kafka/pull/17732
Jira: https://issues.apache.org/jira/browse/KAFKA-17688
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
kamalcph opened a new pull request, #17733:
URL: https://github.com/apache/kafka/pull/17733
This is a cherry-pick of #17676 PR
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [
[
https://issues.apache.org/jira/browse/KAFKA-17801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reopened KAFKA-17801:
--
> RemoteLogManager may compute inaccurate upperBoundOffset for aborted txns
>
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835567141
##
tests/kafkatest/services/performance/consumer_performance.py:
##
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic,
messages, version=DEV_BRANC
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835567388
##
tests/kafkatest/services/performance/consumer_performance.py:
##
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic,
messages, version=DEV_BRANC
Chia-Ping Tsai created KAFKA-17977:
--
Summary: Remove new_consumer from E2E
Key: KAFKA-17977
URL: https://issues.apache.org/jira/browse/KAFKA-17977
Project: Kafka
Issue Type: Sub-task
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835568028
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-
chia7712 commented on code in PR #17367:
URL: https://github.com/apache/kafka/pull/17367#discussion_r1835288947
##
clients/src/test/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategyIntegrationTest.java:
##
@@ -0,0 +1,494 @@
+/*
+ * Licensed to the Apache Soft
chia7712 merged PR #17722:
URL: https://github.com/apache/kafka/pull/17722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17970.
Fix Version/s: 4.0.0
Resolution: Fixed
> Move some purgatory classes from core to s
Chia-Ping Tsai created KAFKA-17975:
--
Summary: Remove ControllerQuorumVotersFutureManager
Key: KAFKA-17975
URL: https://issues.apache.org/jira/browse/KAFKA-17975
Project: Kafka
Issue Type: Im
[
https://issues.apache.org/jira/browse/KAFKA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17837.
Fix Version/s: 4.0.0
Resolution: Fixed
> Rewrite DeleteTopicTest
> ---
chia7712 merged PR #17579:
URL: https://github.com/apache/kafka/pull/17579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #17704:
URL: https://github.com/apache/kafka/pull/17704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835508337
##
tests/kafkatest/sanity_checks/test_performance_services.py:
##
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
-#
chia7712 merged PR #17730:
URL: https://github.com/apache/kafka/pull/17730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15549.
Resolution: Fixed
> Bump swagger dependency version
> ---
>
>
mimaison commented on PR #17704:
URL: https://github.com/apache/kafka/pull/17704#issuecomment-2466439939
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
chia7712 commented on PR #17670:
URL: https://github.com/apache/kafka/pull/17670#issuecomment-2466441612
@kirktrue Could you please fix the conflicts and comment
(https://github.com/apache/kafka/pull/17670#discussion_r1835100820)? I'd like
to merge this PR
--
This is an automated messag
chia7712 commented on code in PR #16950:
URL: https://github.com/apache/kafka/pull/16950#discussion_r1835503294
##
build.gradle:
##
@@ -41,7 +41,7 @@ plugins {
id "com.github.spotbugs" version '6.0.25' apply false
id 'org.scoverage' version '8.0.3' apply false
- id 'io.
mimaison commented on PR #17365:
URL: https://github.com/apache/kafka/pull/17365#issuecomment-2466454973
@cmccabe Can you rebase to resolve the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison commented on code in PR #17507:
URL: https://github.com/apache/kafka/pull/17507#discussion_r1835514323
##
core/src/test/java/kafka/admin/ConfigCommandTest.java:
##
@@ -508,100 +426,56 @@ public void testExpectedEntityTypeNames(List
expectedTypes, List
assertEq
FrankYang0529 opened a new pull request, #17731:
URL: https://github.com/apache/kafka/pull/17731
When Kafka brokers are connecting to other brokers this information is not
properly populated, we see the "unknown" value instead for both
`ClientSoftwareName` and `ClientSoftwareVersion`. The r
chia7712 merged PR #17729:
URL: https://github.com/apache/kafka/pull/17729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
64 matches
Mail list logo
