chia7712 commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835561177
##########
core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala:
##########
@@ -43,8 +43,9 @@ class FetchRequestTestDowngrade extends BaseRequestTest {
)
}
- @Test
- def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(): Unit = {
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_ZK_implicit"))
+ def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(quorum:
String, groupProtocol: String): Unit = {
Review Comment:
> The idea is that someone more knowledgeable about the tests would review
these and either a) remove the test, or b) update the test to run against
Kraft, if possible.
Yes, that will be a great reference, similar to #17727.
For example, FetchRequestTestDowngrade is for LeaderAndIsrRequest, which is
ZK-only, so it's okay to remove it in a follow-up
(https://issues.apache.org/jira/browse/KAFKA-17976).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
