Re: [PR] KAFKA-17317: Validate and maybe trigger downgrade after static member replacement [kafka]

2024-09-27 Thread via GitHub
dajac commented on code in PR #17286: URL: https://github.com/apache/kafka/pull/17286#discussion_r1778129613 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2727,33 +2782,39 @@ private CoordinatorResult consumerGroupFence

[jira] [Commented] (KAFKA-4566) Can't Symlink to Kafka bins

2024-09-27 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885283#comment-17885283 ] Edoardo Comar commented on KAFKA-4566: -- Hi [~itfromblighty] if you can test it on bo

[jira] [Updated] (KAFKA-15279) Implement client support for KIP-848 client-side assigner RPCs

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15279: --- Fix Version/s: (was: 4.0.0) > Implement client support for KIP-848 client-side assigner

[jira] [Updated] (KAFKA-15697) Add local assignor and ensure it cannot be used with server side assignor

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15697: --- Fix Version/s: (was: 4.0.0) > Add local assignor and ensure it cannot be used with serve

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
FrankYang0529 commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1778519271 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1805,15 +1813,23 @@ private boolean processBackgroundEvents()

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17283: URL: https://github.com/apache/kafka/pull/17283#discussion_r1778526104 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -119,18 +120,11 @@ public void onComplete() { }); log.trace("D

[jira] [Created] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Herbert Wespi (Jira)
Herbert Wespi created KAFKA-17635: - Summary: Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced Key: KAFKA-17635 URL: https://issues.apache.org/jira/browse/KAFKA-17635

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17283: URL: https://github.com/apache/kafka/pull/17283#discussion_r1778526687 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -46,59 +47,52 @@ public class ShareFetchUtils { // Process the replica manager fetch

[jira] [Updated] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Herbert Wespi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herbert Wespi updated KAFKA-17635: -- Description: In some of the Kafka streams applications we observed that some events are misse

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1778529486 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1279,7 +1281,10 @@ private void releaseAssignmentAndLeaveGroup(fina

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
FrankYang0529 commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1778532579 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1279,7 +1281,10 @@ private void releaseAssignmentAndLeaveGrou

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
AndrewJSchofield commented on code in PR #17283: URL: https://github.com/apache/kafka/pull/17283#discussion_r1778270660 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -46,59 +47,52 @@ public class ShareFetchUtils { // Process the replica manager fetc

Re: [PR] MINOR Don't run tests for draft PRs [kafka]

2024-09-27 Thread via GitHub
mumrah commented on PR #17299: URL: https://github.com/apache/kafka/pull/17299#issuecomment-2379381175 Example of the tests and build scans being skipped (from my fork): https://github.com/user-attachments/assets/82b39f48-c270-4eb6-af70-5e1a4a853c4a";> When I click "Ready For Re

Re: [PR] MINOR: Rename LeaderChangeBatch in test source [kafka]

2024-09-27 Thread via GitHub
viktorsomogyi closed pull request #11409: MINOR: Rename LeaderChangeBatch in test source URL: https://github.com/apache/kafka/pull/11409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-17643) Response handling for pre-vote set to True

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17643: Summary: Response handling for pre-vote set to True Key: KAFKA-17643 URL: https://issues.apache.org/jira/browse/KAFKA-17643 Project: Kafka Issue Type: Sub-ta

[jira] [Updated] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Herbert Wespi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herbert Wespi updated KAFKA-17635: -- Attachment: screenshot-1.png > Lost events on internal repartition topic when excatly_once_v2

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
junrao commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778967158 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesResponse

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
lianetm merged PR #17244: URL: https://github.com/apache/kafka/pull/17244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-27 Thread via GitHub
chia7712 commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2379733613 > So one option would be to fix that one first, and then come back here to attempt to simply do close(0) when closing interrupted. Thoughts? It's great that we've reached a consens

[jira] [Updated] (KAFKA-17640) Document Java 23 support and include release note

2024-09-27 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17640: Labels: newbie (was: ) > Document Java 23 support and include release note >

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2380082805 @ahuang98 For this KafkaService config ``` self.kafka = KafkaService(self.test_context, num_nodes=3, controller_num_nodes_override=1, zk

[PR] [Draft] KAFKA-17317 another implementation without scheduled downgrade task [kafka]

2024-09-27 Thread via GitHub
dongnuo123 opened a new pull request, #17306: URL: https://github.com/apache/kafka/pull/17306 This implementation doesn't change the existing downgrade path. In `classicGroupJoinToConsumerGroup`, if the group should be downgraded, it will be converted to a classic group at the end of

[jira] [Commented] (KAFKA-15321) Document consumer group member state machine

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885359#comment-17885359 ] Lianet Magrans commented on KAFKA-15321: Hey [~cmccabe], I would guess that this

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1779102908 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -547,6 +551,8 @@ static KafkaAdminClient createInternal( Metric

[jira] [Updated] (KAFKA-17637) Invert the search for LIST_OFFSETS request for remote storage topic

2024-09-27 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-17637: - Description: The timestamp in the records are non-monotonic so we begin the sear

[jira] [Created] (KAFKA-17645) KIP-1052: Enable warmup in producer performance test

2024-09-27 Thread Matt Welch (Jira)
Matt Welch created KAFKA-17645: -- Summary: KIP-1052: Enable warmup in producer performance test Key: KAFKA-17645 URL: https://issues.apache.org/jira/browse/KAFKA-17645 Project: Kafka Issue Type:

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
junrao commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778927545 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesResponse

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
ahuang98 commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379874423 @bbejeck what are the tests you are trying to run/does this change resolve your test failures? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-17644) TLA+ spec modifications

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17644: Summary: TLA+ spec modifications Key: KAFKA-17644 URL: https://issues.apache.org/jira/browse/KAFKA-17644 Project: Kafka Issue Type: Sub-task Repo

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
ahuang98 commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379884106 @chia7712 tried running message_format_change_test.py locally and it is passing with this change -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
chia7712 commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1778858527 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerSubscriptionTest.scala: ## @@ -227,11 +228,29 @@ class PlaintextConsumerSubscriptionTest extends Abstrac

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379891870 @ahuang98 the tests under `tests/kafkatest/tests/streams` I'll update trunk and re-run and let you know. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (KAFKA-17636) The StorageTool does not create SCRAM credentials when formatting disk

2024-09-27 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-17636: Description: When initializing a KRaft cluster with SCRAM inter-broker authentication, you

[jira] [Commented] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885426#comment-17885426 ] Bill Bejeck commented on KAFKA-17635: - Thanks for reporting this [~herbert.wespi] -

[jira] [Updated] (KAFKA-17637) Invert the search for LIST_OFFSETS request for remote storage topic

2024-09-27 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-17637: - Issue Type: Improvement (was: Task) > Invert the search for LIST_OFFSETS reques

Re: [PR] [WIP NO MERGE] Migrate embedded to kraft [kafka]

2024-09-27 Thread via GitHub
bbejeck closed pull request #17238: [WIP NO MERGE] Migrate embedded to kraft URL: https://github.com/apache/kafka/pull/17238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
cmccabe closed pull request #17296: KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster URL: https://github.com/apache/kafka/pull/17296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
cmccabe commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2380054296 Closing since #17016 already accomplished this. Thanks, all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
cmccabe commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2380059529 > @bbejeck : I noticed some diffs with how you updated the EmbeddedKafkaCluster I can take those on in a follow-up PR. WDYT? I think the way you did it, where you used `KafkaCluster

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-09-27 Thread via GitHub
mjsax commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1779165638 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -547,6 +551,8 @@ static KafkaAdminClient createInternal( MetricsContext

Re: [PR] MINOR Don't run tests for Draft PRs [kafka]

2024-09-27 Thread via GitHub
mumrah commented on code in PR #17299: URL: https://github.com/apache/kafka/pull/17299#discussion_r1779169161 ## .github/workflows/build.yml: ## @@ -39,11 +39,21 @@ jobs: matrix: java: [ 21, 17, 11, 8 ] name: Compile and Check Java ${{ matrix.java }} +ou

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
cmccabe commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2380057024 > @OmniaGM : Are we going to apply the same approach to the EmbeddedKafkaCluster in connect as well? I believe Connect's version of `EmbeddedKafkaCluster` was already updated to KR

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1779164631 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesRespons

Re: [PR] MINOR Don't run tests for Draft PRs [kafka]

2024-09-27 Thread via GitHub
mumrah commented on code in PR #17299: URL: https://github.com/apache/kafka/pull/17299#discussion_r1779170871 ## .github/actions/gh-api-update-check/action.yml: ## @@ -39,23 +39,43 @@ inputs: description: "The text to display next to the check" default: "" require

[jira] [Commented] (KAFKA-17286) Flaky PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopic

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885333#comment-17885333 ] Lianet Magrans commented on KAFKA-17286: Hey [~brandboat] , KAFKA-17581 is the r

[jira] [Commented] (KAFKA-13787) Failed to delete state store directory for it is not empty

2024-09-27 Thread Oleg Abrazhaev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885254#comment-17885254 ] Oleg Abrazhaev commented on KAFKA-13787: I have this issue right now on Mac with

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-27 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1778422140 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1805,15 +1807,26 @@ private boolean processBackgroundEvents() {

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
chia7712 commented on PR #17283: URL: https://github.com/apache/kafka/pull/17283#issuecomment-2378999445 Could you please clarify why you decided not to use `CompletableFuture` (https://github.com/apache/kafka/pull/16274#discussion_r1718405279)? -- This is an automated message from the Ap

[jira] [Created] (KAFKA-17634) Tighten up wakeup handling for share consumer

2024-09-27 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17634: Summary: Tighten up wakeup handling for share consumer Key: KAFKA-17634 URL: https://issues.apache.org/jira/browse/KAFKA-17634 Project: Kafka Issue T

[jira] [Updated] (KAFKA-16733) Add support for formatting new records written to offsets topic in kafka-dump-log.sh

2024-09-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16733: - Summary: Add support for formatting new records written to offsets topic in kafka-dump-l

[jira] [Commented] (KAFKA-16109) Write system tests cover the "simple consumer + commit" use case

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885375#comment-17885375 ] Lianet Magrans commented on KAFKA-16109: [~kirktrue] do you think this should be

Re: [PR] KAFKA-17473 Speed Up ClientTelemetryTest [kafka]

2024-09-27 Thread via GitHub
m1a2st commented on PR #17263: URL: https://github.com/apache/kafka/pull/17263#issuecomment-2379334067 The main reason is that when a consumer needs to close, the `ConsumerCoordinator` must also close. Therefore, when the `ConsumerCoordinator` attempts to close, it calls the `commitOffsetsS

Re: [PR] KAFKA-17473 Speed Up ClientTelemetryTest [kafka]

2024-09-27 Thread via GitHub
m1a2st commented on PR #17263: URL: https://github.com/apache/kafka/pull/17263#issuecomment-2379336920 | test name | type | time(Before) | time(After) | | --- | --- | --- | --- | | ClientTelemetryTest | | 36s 969ms | 7s 769ms | | testClientInstanceId | Type=Raft-Isolated, MetadataVe

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on PR #17283: URL: https://github.com/apache/kafka/pull/17283#issuecomment-2379151428 Thanks @AndrewJSchofield and @chia7712 for review, I have addressed the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Herbert Wespi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herbert Wespi updated KAFKA-17635: -- Description: In some of the Kafka streams applications we observed that some events are misse

[jira] [Updated] (KAFKA-16301) Review fenced member unsubscribe/subscribe callbacks interaction

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16301: --- Fix Version/s: (was: 4.0.0) > Review fenced member unsubscribe/subscribe callbacks inter

[jira] [Updated] (KAFKA-15954) Review minimal effort approach on consumer last heartbeat on unsubscribe

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15954: --- Priority: Minor (was: Major) > Review minimal effort approach on consumer last heartbeat on

[jira] [Updated] (KAFKA-15847) Consider partial metadata requests for client reconciliation

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15847: --- Issue Type: Task (was: Bug) > Consider partial metadata requests for client reconciliation

[jira] [Resolved] (KAFKA-17286) Flaky PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopic

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-17286. Resolution: Fixed > Flaky PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopic > --

Re: [PR] KAFKA-17620: Simplifying share partition acquire API (kip-932) [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on PR #17283: URL: https://github.com/apache/kafka/pull/17283#issuecomment-2379150535 > Could you please clarify why you decided not to use `CompletableFuture` ([#16274 (comment)](https://github.com/apache/kafka/pull/16274#discussion_r1718405279))? Hi @chia77

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-09-27 Thread via GitHub
FrankYang0529 commented on PR #17150: URL: https://github.com/apache/kafka/pull/17150#issuecomment-2379360813 Hi @lianetm and @kirktrue, thanks for the review. I may need more time for this. I found that `AsyncKafkaConsumer#interceptors` consume offsets. If we use background thread to get `

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778894503 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesRespons

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim [kafka]

2024-09-27 Thread via GitHub
gharris1727 commented on PR #16522: URL: https://github.com/apache/kafka/pull/16522#issuecomment-2379713050 Test failures are resolved, I'll merge this to trunk tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885372#comment-17885372 ] Lianet Magrans commented on KAFKA-16111: I downgraded the priority here given th

[jira] [Assigned] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-17635: --- Assignee: Bill Bejeck > Lost events on internal repartition topic when excatly_once_v2 is s

[jira] [Created] (KAFKA-17642) Add ProspectiveState and ProspectiveStateTest

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17642: Summary: Add ProspectiveState and ProspectiveStateTest Key: KAFKA-17642 URL: https://issues.apache.org/jira/browse/KAFKA-17642 Project: Kafka Issue Type: Sub

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778952117 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesRespons

[PR] KAFKA-17636 Fix scram bootstrap records [kafka]

2024-09-27 Thread via GitHub
mumrah opened a new pull request, #17305: URL: https://github.com/apache/kafka/pull/17305 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Created] (KAFKA-17638) Add support for Java 23

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17638: --- Summary: Add support for Java 23 Key: KAFKA-17638 URL: https://issues.apache.org/jira/browse/KAFKA-17638 Project: Kafka Issue Type: Improvement Affects Ver

[jira] [Updated] (KAFKA-17639) Add Java 23 to CI build matrix

2024-09-27 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17639: Labels: newbie (was: ) > Add Java 23 to CI build matrix > -- > >

[jira] [Created] (KAFKA-17639) Add Java 23 to CI build matrix

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17639: --- Summary: Add Java 23 to CI build matrix Key: KAFKA-17639 URL: https://issues.apache.org/jira/browse/KAFKA-17639 Project: Kafka Issue Type: Task Rep

[jira] [Updated] (KAFKA-17641) Update vote RPC with new pre-vote field

2024-09-27 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang updated KAFKA-17641: - Description: Brush off [https://github.com/apache/kafka/pull/15231/files] and handle v2 (additio

Re: [PR] KAFKA-17636 Fix scram bootstrap records [kafka]

2024-09-27 Thread via GitHub
cmccabe commented on code in PR #17305: URL: https://github.com/apache/kafka/pull/17305#discussion_r1779083029 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -139,6 +139,8 @@ object StorageTool extends Logging { if (namespace.getBoolean("standalone")) {

Re: [PR] KAFKA-14572: Migrate EmbeddedKafkaCluster used by Streams integration tests from EmbeddedZookeeper to KRaft [kafka]

2024-09-27 Thread via GitHub
bbejeck merged PR #17016: URL: https://github.com/apache/kafka/pull/17016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
ahuang98 commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379951796 @bbejeck thanks a bunch, taking a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-14572: Migrate EmbeddedKafkaCluster used by Streams integration tests from EmbeddedZookeeper to KRaft [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on PR #17016: URL: https://github.com/apache/kafka/pull/17016#issuecomment-2379952402 Merged #17016 to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
OmniaGM commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2379957350 > > Hmm, looks like this PR is further along than mine. Maybe I don't need this one > > @cmccabe yes #17016 is very close - it's building now - if we get a green build I was going

[jira] [Updated] (KAFKA-17627) ConfigProvider TTLs do not restart Tasks

2024-09-27 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17627: Labels: newbie (was: ) > ConfigProvider TTLs do not restart Tasks > -

[jira] [Created] (KAFKA-17640) Document Java 23 support and include release note

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17640: --- Summary: Document Java 23 support and include release note Key: KAFKA-17640 URL: https://issues.apache.org/jira/browse/KAFKA-17640 Project: Kafka Issue Type: T

[jira] [Created] (KAFKA-17641) Update vote RPC with new pre-vote field

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17641: Summary: Update vote RPC with new pre-vote field Key: KAFKA-17641 URL: https://issues.apache.org/jira/browse/KAFKA-17641 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778894503 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesRespons

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-27 Thread via GitHub
chia7712 commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2379598979 > I don't see how it's possible to satisfy both of these conditions: 1. Allow the user to "forcefully close the consumer" 2. Guarantee the consumer leaves the group Yes, you'r

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-27 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778973697 ## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesRespons

[jira] [Assigned] (KAFKA-17636) The StorageTool does not create SCRAM credentials when formatting disk

2024-09-27 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-17636: Assignee: David Arthur > The StorageTool does not create SCRAM credentials when formattin

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379918654 @ahuang98 I still get the following error ``` RemoteCommandError({'ssh_config': {'host': 'ducker03', 'hostname': 'ducker03', 'user': 'ducker', 'port': 22, 'password': '', 'ident

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1779093766 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -547,6 +551,8 @@ static KafkaAdminClient createInternal( MetricsContex

Re: [PR] MINOR Don't run tests for Draft PRs [kafka]

2024-09-27 Thread via GitHub
chia7712 commented on code in PR #17299: URL: https://github.com/apache/kafka/pull/17299#discussion_r1779097973 ## .github/actions/gh-api-update-check/action.yml: ## @@ -39,23 +39,43 @@ inputs: description: "The text to display next to the check" default: "" requi

Re: [PR] KAFKA-17525: Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17168: URL: https://github.com/apache/kafka/pull/17168#discussion_r1779108690 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java: ## @@ -133,8 +134,8 @@ private static void validateProperties(Properties prop

Re: [PR] KAFKA-17525: Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17168: URL: https://github.com/apache/kafka/pull/17168#discussion_r1779108690 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java: ## @@ -133,8 +134,8 @@ private static void validateProperties(Properties prop

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-09-27 Thread via GitHub
apoorvmittal10 commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1779102908 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -547,6 +551,8 @@ static KafkaAdminClient createInternal( Metric

Re: [PR] MINOR: Fix kafkatest advertised listeners [kafka]

2024-09-27 Thread via GitHub
ahuang98 commented on PR #17294: URL: https://github.com/apache/kafka/pull/17294#issuecomment-2379988457 @bbejeck I'm not seeing that error locally, I get the following with no obvious errors in the logs ``` TimeoutError("Kafka server didn't finish startup in 60 seconds") Traceb

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-09-27 Thread via GitHub
AndrewJSchofield commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1779110702 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -547,6 +551,8 @@ static KafkaAdminClient createInternal( Metr

Re: [PR] KAFKA-14572: Fix ZK dependency in EmbeddedKafkaCluster [kafka]

2024-09-27 Thread via GitHub
bbejeck commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2379992375 > > > Hmm, looks like this PR is further along than mine. Maybe I don't need this one > > > > > > @cmccabe yes #17016 is very close - it's building now - if we get a green buil

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim [kafka]

2024-09-27 Thread via GitHub
gharris1727 commented on code in PR #16522: URL: https://github.com/apache/kafka/pull/16522#discussion_r1778722815 ## clients/src/main/java/org/apache/kafka/common/internals/ReflectiveStrategy.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-27 Thread via GitHub
junrao commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1779239837 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/PersisterStateBatchCombiner.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Created] (KAFKA-17632) Custom `partitioner.class` with an even number of partitions always writes to even partitions

2024-09-27 Thread thanhlv (Jira)
thanhlv created KAFKA-17632: --- Summary: Custom `partitioner.class` with an even number of partitions always writes to even partitions Key: KAFKA-17632 URL: https://issues.apache.org/jira/browse/KAFKA-17632 P

[jira] [Updated] (KAFKA-17632) Custom `partitioner.class` with an even number of partitions always writes to even partitions

2024-09-27 Thread thanhlv (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] thanhlv updated KAFKA-17632: Description: Our project has some special logic that requires custom partitions. With an odd number of Par

Re: [PR] KAFKA-16733: Add share group record support to OffsetsMessageParser [kafka]

2024-09-27 Thread via GitHub
AndrewJSchofield commented on PR #17282: URL: https://github.com/apache/kafka/pull/17282#issuecomment-2378789662 3 unrelated test failures (features command). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17500: Metadata redirection for NOT_LEADER_OR_FOLLOWER [kafka]

2024-09-27 Thread via GitHub
AndrewJSchofield commented on PR #17279: URL: https://github.com/apache/kafka/pull/17279#issuecomment-2378792878 3 unrelated test failures (features command). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (KAFKA-17633) Implement formatter for share group state topic records

2024-09-27 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-17633: --- Summary: Implement formatter for share group state topic records Key: KAFKA-17633 URL: https://issues.apache.org/jira/browse/KAFKA-17633 Project: Kafka

  1   2   >