jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778894503
########## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ########## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesResponse", - "validVersions": "0-1", + "validVersions": "0-2", Review Comment: Ok so let me just summarize my understanding. V1 -- we short circuit the response when there is an error and put the error top level, but we still populate the results array for none and error cases V2 -- we short circuit the response when there is an error and put the error top level, no results array for any case For both the top level error will contain the feature that caused the error if there was one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
