cmccabe commented on PR #17296: URL: https://github.com/apache/kafka/pull/17296#issuecomment-2380059529
> @bbejeck : I noticed some diffs with how you updated the EmbeddedKafkaCluster I can take those on in a follow-up PR. WDYT? I think the way you did it, where you used `KafkaClusterTestKit`, is better than what I did :) I was just being lazy by using the Scala test harness. `KafkaClusterTestKit` is actually the better way since it will be easier to configure in the future, and doesn't drag in all that scala stuff. Feel free to grab any code from my PR that still looks useful, though. (Keep in mind that I didn't really get to the point of testing it, though.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
